You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2009/05/04 17:09:30 UTC
[jira] Created: (CASSANDRA-130) uniform logging of read/write paths
uniform logging of read/write paths
-----------------------------------
Key: CASSANDRA-130
URL: https://issues.apache.org/jira/browse/CASSANDRA-130
Project: Cassandra
Issue Type: Improvement
Affects Versions: trunk
Reporter: Jonathan Ellis
Assignee: Jonathan Ellis
Fix For: 0.3
lots of stuff is logged but mostly haphazardly. need to make it so we can usefully track data path for troubleshooting.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-130) uniform logging of read/write
paths
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12705700#action_12705700 ]
Jonathan Ellis commented on CASSANDRA-130:
------------------------------------------
I think that's local to your wc...
$ grep orig 130-v3.patch |wc
0 0 0
$ grep orig 130-v2.patch |wc
0 0 0
> uniform logging of read/write paths
> -----------------------------------
>
> Key: CASSANDRA-130
> URL: https://issues.apache.org/jira/browse/CASSANDRA-130
> Project: Cassandra
> Issue Type: Improvement
> Affects Versions: trunk
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.3
>
> Attachments: 130-v2.patch, 130-v3.patch, 130.patch
>
>
> lots of stuff is logged but mostly haphazardly. need to make it so we can usefully track data path for troubleshooting.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-130) uniform logging of read/write paths
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-130:
-------------------------------------
Attachment: 130-v2.patch
attach version against HEAD
> uniform logging of read/write paths
> -----------------------------------
>
> Key: CASSANDRA-130
> URL: https://issues.apache.org/jira/browse/CASSANDRA-130
> Project: Cassandra
> Issue Type: Improvement
> Affects Versions: trunk
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.3
>
> Attachments: 130-v2.patch, 130.patch
>
>
> lots of stuff is logged but mostly haphazardly. need to make it so we can usefully track data path for troubleshooting.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-130) uniform logging of read/write paths
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-130:
-------------------------------------
Attachment: 130.patch
move the important timing data into MBeans; remove the rest. clean up miscellaneous other logging.
> uniform logging of read/write paths
> -----------------------------------
>
> Key: CASSANDRA-130
> URL: https://issues.apache.org/jira/browse/CASSANDRA-130
> Project: Cassandra
> Issue Type: Improvement
> Affects Versions: trunk
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.3
>
> Attachments: 130.patch
>
>
> lots of stuff is logged but mostly haphazardly. need to make it so we can usefully track data path for troubleshooting.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-130) uniform logging of read/write paths
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-130:
-------------------------------------
Attachment: 130-v3.patch
v3
> uniform logging of read/write paths
> -----------------------------------
>
> Key: CASSANDRA-130
> URL: https://issues.apache.org/jira/browse/CASSANDRA-130
> Project: Cassandra
> Issue Type: Improvement
> Affects Versions: trunk
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.3
>
> Attachments: 130-v2.patch, 130-v3.patch, 130.patch
>
>
> lots of stuff is logged but mostly haphazardly. need to make it so we can usefully track data path for troubleshooting.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-130) uniform logging of read/write
paths
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12705674#action_12705674 ]
Eric Evans commented on CASSANDRA-130:
--------------------------------------
As you pointed out on IRC, this needs the following to successfully build:
diff --git a/src/java/org/apache/cassandra/service/StorageProxy.java b/src/java/
index 456b637..ea8ee40 100644
--- a/src/java/org/apache/cassandra/service/StorageProxy.java
+++ b/src/java/org/apache/cassandra/service/StorageProxy.java
@@ -674,7 +674,7 @@ public class StorageProxy implements StorageProxyMBean
// read response
// TODO send more requests if we need to span multiple nodes
- byte[] responseBody = iar.get(DatabaseDescriptor.getRpcTimeout(), T
+ byte[] responseBody = (byte[])iar.get(DatabaseDescriptor.getRpcTime
return RangeReply.read(responseBody).keys;
}
catch (Exception e)
Also, it looks like the patch creates a file named src/java/org/apache/cassandra/db/ColumnFamilyStore.java.orig, and I assume that was unintentional.
It looks possible for the {range,read,write}Operations of StorageProxy to be incremented beyond the limit of an int, (so maybe they should roll over to zero at overflow).
> uniform logging of read/write paths
> -----------------------------------
>
> Key: CASSANDRA-130
> URL: https://issues.apache.org/jira/browse/CASSANDRA-130
> Project: Cassandra
> Issue Type: Improvement
> Affects Versions: trunk
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.3
>
> Attachments: 130-v2.patch, 130.patch
>
>
> lots of stuff is logged but mostly haphazardly. need to make it so we can usefully track data path for troubleshooting.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-130) uniform logging of read/write
paths
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12705699#action_12705699 ]
Eric Evans commented on CASSANDRA-130:
--------------------------------------
The patch still adds src/java/org/apache/cassandra/db/ColumnFamilyStore.java.orig, but assuming you don't commit it, +1 from me. :)
> uniform logging of read/write paths
> -----------------------------------
>
> Key: CASSANDRA-130
> URL: https://issues.apache.org/jira/browse/CASSANDRA-130
> Project: Cassandra
> Issue Type: Improvement
> Affects Versions: trunk
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.3
>
> Attachments: 130-v2.patch, 130-v3.patch, 130.patch
>
>
> lots of stuff is logged but mostly haphazardly. need to make it so we can usefully track data path for troubleshooting.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-130) uniform logging of read/write
paths
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12706028#action_12706028 ]
Hudson commented on CASSANDRA-130:
----------------------------------
Integrated in Cassandra #59 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/59/])
clean up logging. move some of it into MBeans. patch by jbellis; reviewed by Eric Evans for
> uniform logging of read/write paths
> -----------------------------------
>
> Key: CASSANDRA-130
> URL: https://issues.apache.org/jira/browse/CASSANDRA-130
> Project: Cassandra
> Issue Type: Improvement
> Affects Versions: trunk
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.3
>
> Attachments: 130-v2.patch, 130-v3.patch, 130.patch
>
>
> lots of stuff is logged but mostly haphazardly. need to make it so we can usefully track data path for troubleshooting.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-130) uniform logging of read/write paths
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-130:
-------------------------------------
Fix Version/s: (was: 0.4)
0.3
> uniform logging of read/write paths
> -----------------------------------
>
> Key: CASSANDRA-130
> URL: https://issues.apache.org/jira/browse/CASSANDRA-130
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.3
>
> Attachments: 130-v2.patch, 130-v3.patch, 130.patch
>
>
> lots of stuff is logged but mostly haphazardly. need to make it so we can usefully track data path for troubleshooting.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.