Re: [PR] test(sql): migrate SQL leaf and Quidem tests to JUnit 5 (druid)

["FrankChen021 (via GitHub)" <gi...@apache.org>]

FrankChen021 commented on code in PR #19909:
URL: https://github.com/apache/druid/pull/19909#discussion_r3735948285


##########
multi-stage-query/src/test/java/org/apache/druid/msq/exec/MSQCompactionTaskRunTest.java:
##########
@@ -133,13 +134,14 @@
  * Tests for CompactionTask using MSQCompactionRunner.
  * Extends CompactionTaskRunTest to reuse all test infrastructure.
  */
-@RunWith(Parameterized.class)
+
+@ParameterizedClass
+@MethodSource("constructorFeeder")
 public class MSQCompactionTaskRunTest extends CompactionTaskRunBase

Review Comment:
   [P1] MSQ compaction test still depends on JUnit 4 base
   
   This class still extends CompactionTaskRunBase, whose fixture and inherited tests use JUnit 4 annotations and ExternalResource rules. This PR removes JUnit 4 and Vintage support from multi-stage-query, leaving the test fixture unresolved; even if it loads through another dependency, Jupiter will not discover the inherited JUnit 4 tests. Migrate the shared fixture or retain compatible support before removing Vintage.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org