You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/10/26 17:39:22 UTC
[GitHub] [arrow] vertexclique opened a new pull request #8531: ARROW-10393: [Rust] Apply fix for null reading in json reader for nested
vertexclique opened a new pull request #8531:
URL: https://github.com/apache/arrow/pull/8531
Apply fix for null reading in json reader for nested string builder variations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on pull request #8531: ARROW-10393: [Rust] Apply fix for null reading in json reader for nested
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #8531:
URL: https://github.com/apache/arrow/pull/8531#issuecomment-716926082
@vertexclique , could you check clippy?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao closed pull request #8531: ARROW-10393: [Rust] Apply fix for null reading in json reader for nested
Posted by GitBox <gi...@apache.org>.
jorgecarleitao closed pull request #8531:
URL: https://github.com/apache/arrow/pull/8531
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8531: ARROW-10393: [Rust] Apply fix for null reading in json reader for nested
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8531:
URL: https://github.com/apache/arrow/pull/8531#issuecomment-716717269
https://issues.apache.org/jira/browse/ARROW-10393
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on a change in pull request #8531: ARROW-10393: [Rust] Apply fix for null reading in json reader for nested
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on a change in pull request #8531:
URL: https://github.com/apache/arrow/pull/8531#discussion_r512157762
##########
File path: rust/arrow/test/data/list_string_dict_nested_nulls.json
##########
@@ -0,0 +1,3 @@
+{"machine": "a", "events": [null, "Elect Leader", "Do Ballot"]}
+{"machine": "b", "events": ["Do Ballot", null, "Send Data", "Elect Leader"]}
Review comment:
/r/oddlyspecific
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] vertexclique commented on a change in pull request #8531: ARROW-10393: [Rust] Apply fix for null reading in json reader for nested
Posted by GitBox <gi...@apache.org>.
vertexclique commented on a change in pull request #8531:
URL: https://github.com/apache/arrow/pull/8531#discussion_r512161259
##########
File path: rust/arrow/test/data/list_string_dict_nested_nulls.json
##########
@@ -0,0 +1,3 @@
+{"machine": "a", "events": [null, "Elect Leader", "Do Ballot"]}
+{"machine": "b", "events": ["Do Ballot", null, "Send Data", "Elect Leader"]}
Review comment:
lol, yes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org