You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Nitiraj Rathore <ni...@gmail.com> on 2015/11/23 10:28:05 UTC
Review Request 40592: Hive view doesn't show precision of types that
support it.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40592/
-----------------------------------------------------------
Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, and Rohit Choudhary.
Bugs: AMBARI-14010
https://issues.apache.org/jira/browse/AMBARI-14010
Repository: ambari
Description
-------
Earliar :
The precision and scale were not fetched and shown on UI
After Patch :
precision will be shown for char and varchar and precision and scale both will be shown for decimal
In Patch :
added new ember helper : format-column-type.js
changes in database-tree.hbs and database.js for fetching and showing precision and scale.
Diffs
-----
contrib/views/hive/src/main/resources/ui/hive-web/app/helpers/format-column-type.js PRE-CREATION
contrib/views/hive/src/main/resources/ui/hive-web/app/services/database.js 58789a3
contrib/views/hive/src/main/resources/ui/hive-web/app/templates/databases-tree.hbs 45a9b7f
Diff: https://reviews.apache.org/r/40592/diff/
Testing
-------
Manual testing on front end.
Manual testing on back end to ensure correct data is returned (already).
Thanks,
Nitiraj Rathore
Re: Review Request 40592: Hive view doesn't show precision of types
that support it.
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40592/#review108289
-----------------------------------------------------------
Ship it!
Ship It!
- Jaimin Jetly
On Nov. 23, 2015, 9:28 a.m., Nitiraj Rathore wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40592/
> -----------------------------------------------------------
>
> (Updated Nov. 23, 2015, 9:28 a.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, and Rohit Choudhary.
>
>
> Bugs: AMBARI-14010
> https://issues.apache.org/jira/browse/AMBARI-14010
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Earliar :
> The precision and scale were not fetched and shown on UI
>
> After Patch :
> precision will be shown for char and varchar and precision and scale both will be shown for decimal
>
> In Patch :
> added new ember helper : format-column-type.js
> changes in database-tree.hbs and database.js for fetching and showing precision and scale.
>
>
> Diffs
> -----
>
> contrib/views/hive/src/main/resources/ui/hive-web/app/helpers/format-column-type.js PRE-CREATION
> contrib/views/hive/src/main/resources/ui/hive-web/app/services/database.js 58789a3
> contrib/views/hive/src/main/resources/ui/hive-web/app/templates/databases-tree.hbs 45a9b7f
>
> Diff: https://reviews.apache.org/r/40592/diff/
>
>
> Testing
> -------
>
> Manual testing on front end.
> Manual testing on back end to ensure correct data is returned (already).
>
>
> Thanks,
>
> Nitiraj Rathore
>
>
Re: Review Request 40592: Hive view doesn't show precision of types
that support it.
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40592/#review108287
-----------------------------------------------------------
Ship it!
Ship It!
- Jaimin Jetly
On Nov. 23, 2015, 9:28 a.m., Nitiraj Rathore wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40592/
> -----------------------------------------------------------
>
> (Updated Nov. 23, 2015, 9:28 a.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, and Rohit Choudhary.
>
>
> Bugs: AMBARI-14010
> https://issues.apache.org/jira/browse/AMBARI-14010
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Earliar :
> The precision and scale were not fetched and shown on UI
>
> After Patch :
> precision will be shown for char and varchar and precision and scale both will be shown for decimal
>
> In Patch :
> added new ember helper : format-column-type.js
> changes in database-tree.hbs and database.js for fetching and showing precision and scale.
>
>
> Diffs
> -----
>
> contrib/views/hive/src/main/resources/ui/hive-web/app/helpers/format-column-type.js PRE-CREATION
> contrib/views/hive/src/main/resources/ui/hive-web/app/services/database.js 58789a3
> contrib/views/hive/src/main/resources/ui/hive-web/app/templates/databases-tree.hbs 45a9b7f
>
> Diff: https://reviews.apache.org/r/40592/diff/
>
>
> Testing
> -------
>
> Manual testing on front end.
> Manual testing on back end to ensure correct data is returned (already).
>
>
> Thanks,
>
> Nitiraj Rathore
>
>