[GitHub] [flink] wuchong commented on a change in pull request #13694: [FLINK-19720][table-api] Introduce new Providers and parallelism API

[GitBox <gi...@apache.org>]

wuchong commented on a change in pull request #13694:
URL: https://github.com/apache/flink/pull/13694#discussion_r508193816



##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/factories/FactoryUtil.java
##########
@@ -73,6 +73,12 @@
 			"Uniquely identifies the connector of a dynamic table that is used for accessing data in " +
 			"an external system. Its value is used during table source and table sink discovery.");
 
+	public static final ConfigOption<Integer> SINK_PARALLELISM = ConfigOptions
+			.key("sink.parallelism")
+			.intType()
+			.noDefaultValue()
+			.withDescription("Defines the user specified sink parallelism.");

Review comment:
       "Defines the user specified parallelism for the sink." ?

##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/ParallelismProvider.java
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.connector;
+
+import org.apache.flink.annotation.PublicEvolving;
+
+import java.util.Optional;
+
+/**
+ * Parallelism provider for connector providers.
+ * Now only works on {@code SinkFunctionProvider} and {@code OutputFormatProvider}.

Review comment:
       ```suggestion
    * 
    * <p>Note: currently, it only supports to work with {@code SinkFunctionProvider} and {@code OutputFormatProvider}.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org