[GitHub] merrimanr commented on a change in pull request #1330: METRON-1968: Messages are lost when a parser produces multiple messages and batch size is greater than 1

[GitBox <gi...@apache.org>]

merrimanr commented on a change in pull request #1330: METRON-1968: Messages are lost when a parser produces multiple messages and batch size is greater than 1
URL: https://github.com/apache/metron/pull/1330#discussion_r254289186
 
 

 ##########
 File path: metron-platform/metron-parsing/metron-parsing-storm/src/main/java/org/apache/metron/parsers/bolt/ParserBolt.java
 ##########
 @@ -326,6 +329,10 @@ protected void handleError(String sensorType, byte[] originalMessage, Tuple tupl
     ErrorUtils.handleError(collector, error);
   }
 
 
 Review comment:
   I agree and it's something I called out in the PR description.  What should we use?  We can't pass in a Tuple anymore, that's a fundamental change this PR introduces.  It's needs to be a String type and it needs to uniquely identify a message.  It's possible a Tuple results in multiple messages so that won't work.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services