You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by gg...@apache.org on 2016/09/04 06:11:13 UTC
logging-log4j2 git commit: Refactor duplicate code.
Repository: logging-log4j2
Updated Branches:
refs/heads/master cc4e9d21e -> 1f744571c
Refactor duplicate code.
Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/1f744571
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/1f744571
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/1f744571
Branch: refs/heads/master
Commit: 1f744571c988bd046a0bb34cded086c0ebc8426b
Parents: cc4e9d2
Author: ggregory <gg...@apache.org>
Authored: Sun Sep 4 02:11:10 2016 -0400
Committer: ggregory <gg...@apache.org>
Committed: Sun Sep 4 02:11:10 2016 -0400
----------------------------------------------------------------------
.../logging/log4j/core/net/TcpSocketManager.java | 15 +++++++++------
1 file changed, 9 insertions(+), 6 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/1f744571/log4j-core/src/main/java/org/apache/logging/log4j/core/net/TcpSocketManager.java
----------------------------------------------------------------------
diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/net/TcpSocketManager.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/net/TcpSocketManager.java
index 35364a1..5295894 100644
--- a/log4j-core/src/main/java/org/apache/logging/log4j/core/net/TcpSocketManager.java
+++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/net/TcpSocketManager.java
@@ -87,9 +87,7 @@ public class TcpSocketManager extends AbstractSocketManager {
this.immediateFail = immediateFail;
retry = delay > 0;
if (socket == null) {
- reconnector = new Reconnector(this);
- reconnector.setDaemon(true);
- reconnector.setPriority(Thread.MIN_PRIORITY);
+ reconnector = createReconnector();
reconnector.start();
}
}
@@ -138,9 +136,7 @@ public class TcpSocketManager extends AbstractSocketManager {
}
} catch (final IOException ex) {
if (retry && reconnector == null) {
- reconnector = new Reconnector(this);
- reconnector.setDaemon(true);
- reconnector.setPriority(Thread.MIN_PRIORITY);
+ reconnector = createReconnector();
reconnector.start();
}
final String msg = "Error writing to " + getName();
@@ -249,6 +245,13 @@ public class TcpSocketManager extends AbstractSocketManager {
}
}
+ private Reconnector createReconnector() {
+ Reconnector recon = new Reconnector(this);
+ recon.setDaemon(true);
+ recon.setPriority(Thread.MIN_PRIORITY);
+ return recon;
+ }
+
protected Socket createSocket(final InetAddress host, final int port) throws IOException {
return createSocket(host.getHostName(), port);
}