You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/10/20 06:56:28 UTC
[GitHub] [hudi] codope opened a new pull request #3830: [HUDI-2077] Set schema validation from main write config
codope opened a new pull request #3830:
URL: https://github.com/apache/hudi/pull/3830
## What is the purpose of the pull request
Set schema validation config for the metadata table from main write config. This is disabled by default. Note that this might not be the root cause of flakiness in `TestHoodieDeltaStreamer.testAsyncClusteringServiceWithCompaction`. Please see [this comment](https://issues.apache.org/jira/browse/HUDI-2077?focusedCommentId=17431004&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17431004).
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3830: [HUDI-2077] Set schema validation from main write config
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3830:
URL: https://github.com/apache/hudi/pull/3830#issuecomment-947384224
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f87b7e3c93ef0cca6a050052f4a76f42663a3b8c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f87b7e3c93ef0cca6a050052f4a76f42663a3b8c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f87b7e3c93ef0cca6a050052f4a76f42663a3b8c UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codope closed pull request #3830: [HUDI-2077] Set schema validation from main write config
Posted by GitBox <gi...@apache.org>.
codope closed pull request #3830:
URL: https://github.com/apache/hudi/pull/3830
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codope commented on pull request #3830: [HUDI-2077] Set schema validation from main write config
Posted by GitBox <gi...@apache.org>.
codope commented on pull request #3830:
URL: https://github.com/apache/hudi/pull/3830#issuecomment-957121442
> in general, I agree with your intention. but not for schema validation. Metadata is an impl detail. User does not even know whats the schema for metadata table. so, atleast for this config, we should decide by ourselves and not derive from data table configs.
Got it. I am going to close this PR. I'll keep an eye on CI for schema validation failure in testAsyncClusteringServiceWithCompaction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3830: [HUDI-2077] Set schema validation from main write config
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3830:
URL: https://github.com/apache/hudi/pull/3830#issuecomment-947384224
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f87b7e3c93ef0cca6a050052f4a76f42663a3b8c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2736",
"triggerID" : "f87b7e3c93ef0cca6a050052f4a76f42663a3b8c",
"triggerType" : "PUSH"
}, {
"hash" : "96e48d1466e8a8cf72d392fd2834880050362a16",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "96e48d1466e8a8cf72d392fd2834880050362a16",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f87b7e3c93ef0cca6a050052f4a76f42663a3b8c Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2736)
* 96e48d1466e8a8cf72d392fd2834880050362a16 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codope commented on pull request #3830: [HUDI-2077] Set schema validation from main write config
Posted by GitBox <gi...@apache.org>.
codope commented on pull request #3830:
URL: https://github.com/apache/hudi/pull/3830#issuecomment-951772398
> trying to understand why do we need this change? metadata table is something internally managed. I prefer to enable schema validation always.
I would prefer to validate the schema as well. This change is just to avoid the flakiness in [TestHoodieDeltaStreamer.testAsyncClusteringServiceWithCompaction](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_apis/build/builds/2725/logs/61). By default the schema validation is turned off. It was hardcoded to true for metadata table.
However, on a high level, my thinking is even though the metadata table is internally managed shouldn't we have the data table configs govern the metadata table configs as well instead of hardcoding values? This may not be true for all configs but for some we can inherit the configs directly from the data table. For instance, let's take the scehma validation config. For whatever reason (efficiency, or avoid validation failure), user wants it to be turned off doesn't it make sense to turn it off for the metadata table as well for those same reasons?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codope commented on pull request #3830: [HUDI-2077] Set schema validation from main write config
Posted by GitBox <gi...@apache.org>.
codope commented on pull request #3830:
URL: https://github.com/apache/hudi/pull/3830#issuecomment-957121442
> in general, I agree with your intention. but not for schema validation. Metadata is an impl detail. User does not even know whats the schema for metadata table. so, atleast for this config, we should decide by ourselves and not derive from data table configs.
Got it. I am going to close this PR. I'll keep an eye on CI for schema validation failure in testAsyncClusteringServiceWithCompaction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3830: [HUDI-2077] Set schema validation from main write config
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3830:
URL: https://github.com/apache/hudi/pull/3830#issuecomment-947384224
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f87b7e3c93ef0cca6a050052f4a76f42663a3b8c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2736",
"triggerID" : "f87b7e3c93ef0cca6a050052f4a76f42663a3b8c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f87b7e3c93ef0cca6a050052f4a76f42663a3b8c Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2736)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3830: [HUDI-2077] Set schema validation from main write config
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3830:
URL: https://github.com/apache/hudi/pull/3830#issuecomment-947384224
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f87b7e3c93ef0cca6a050052f4a76f42663a3b8c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2736",
"triggerID" : "f87b7e3c93ef0cca6a050052f4a76f42663a3b8c",
"triggerType" : "PUSH"
}, {
"hash" : "96e48d1466e8a8cf72d392fd2834880050362a16",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2742",
"triggerID" : "96e48d1466e8a8cf72d392fd2834880050362a16",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f87b7e3c93ef0cca6a050052f4a76f42663a3b8c Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2736)
* 96e48d1466e8a8cf72d392fd2834880050362a16 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2742)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3830: [HUDI-2077] Set schema validation from main write config
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3830:
URL: https://github.com/apache/hudi/pull/3830#issuecomment-947384224
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f87b7e3c93ef0cca6a050052f4a76f42663a3b8c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2736",
"triggerID" : "f87b7e3c93ef0cca6a050052f4a76f42663a3b8c",
"triggerType" : "PUSH"
}, {
"hash" : "96e48d1466e8a8cf72d392fd2834880050362a16",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2742",
"triggerID" : "96e48d1466e8a8cf72d392fd2834880050362a16",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 96e48d1466e8a8cf72d392fd2834880050362a16 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2742)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #3830: [HUDI-2077] Set schema validation from main write config
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #3830:
URL: https://github.com/apache/hudi/pull/3830#issuecomment-956525831
in general, I agree with your intention. but not for schema validation. Metadata is an impl detail. User does not even know whats the schema for metadata table. so, atleast for this config, we should decide by ourselves and not derive from data table configs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codope commented on pull request #3830: [HUDI-2077] Set schema validation from main write config
Posted by GitBox <gi...@apache.org>.
codope commented on pull request #3830:
URL: https://github.com/apache/hudi/pull/3830#issuecomment-957121442
> in general, I agree with your intention. but not for schema validation. Metadata is an impl detail. User does not even know whats the schema for metadata table. so, atleast for this config, we should decide by ourselves and not derive from data table configs.
Got it. I am going to close this PR. I'll keep an eye on CI for schema validation failure in testAsyncClusteringServiceWithCompaction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codope closed pull request #3830: [HUDI-2077] Set schema validation from main write config
Posted by GitBox <gi...@apache.org>.
codope closed pull request #3830:
URL: https://github.com/apache/hudi/pull/3830
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3830: [HUDI-2077] Set schema validation from main write config
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3830:
URL: https://github.com/apache/hudi/pull/3830#issuecomment-947384224
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f87b7e3c93ef0cca6a050052f4a76f42663a3b8c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2736",
"triggerID" : "f87b7e3c93ef0cca6a050052f4a76f42663a3b8c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f87b7e3c93ef0cca6a050052f4a76f42663a3b8c Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2736)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codope closed pull request #3830: [HUDI-2077] Set schema validation from main write config
Posted by GitBox <gi...@apache.org>.
codope closed pull request #3830:
URL: https://github.com/apache/hudi/pull/3830
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #3830: [HUDI-2077] Set schema validation from main write config
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #3830:
URL: https://github.com/apache/hudi/pull/3830#issuecomment-956525831
in general, I agree with your intention. but not for schema validation. Metadata is an impl detail. User does not even know whats the schema for metadata table. so, atleast for this config, we should decide by ourselves and not derive from data table configs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org