You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/07/05 23:10:00 UTC
[jira] [Commented] (FLINK-7109) HadoopUtils#getHadoopConfiguration
should not load global configuration
[ https://issues.apache.org/jira/browse/FLINK-7109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16075594#comment-16075594 ]
ASF GitHub Bot commented on FLINK-7109:
---------------------------------------
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/4265
[FLINK-7109] [hadoop] Remove GlobalConfiguration.loadConfiguration from HadoopUtils#getHadoopConfiguration
The HadoopUtils#getHadoopConfiguration should not load the global configuration. Instead
we pass it in as parameter.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink fixHadoopUtils
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4265.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4265
----
commit c0b7954a17417390de4ad2e38887ca1ec4d15409
Author: Till Rohrmann <tr...@apache.org>
Date: 2017-07-05T23:07:16Z
[FLINK-7109] [hadoop] Remove GlobalConfiguration.loadConfiguration from HadoopUtils#getHadoopConfiguration
The HadoopUtils#getHadoopConfiguration should not load the global configuration. Instead
we pass it in as parameter.
----
> HadoopUtils#getHadoopConfiguration should not load global configuration
> -----------------------------------------------------------------------
>
> Key: FLINK-7109
> URL: https://issues.apache.org/jira/browse/FLINK-7109
> Project: Flink
> Issue Type: Improvement
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Minor
> Fix For: 1.4.0
>
>
> The {{HadoopUtils#getHadoopConfiguration}} should not load the global configuration via {{GlobalConfiguration.loadConfiguration}}. Instead we should pass a valid Flink configuration to the static method. Otherwise, we will load the global configuration whenever {{HadoopUtils#getHadoopConfiguration}} is called.
> Usually {{HadoopUtils#getHadoopConfiguration}} is only used by {{HadoopInputFormatBase}}, for example. However with the addition of the {{SecurityConfiguration}}, also this class loads the Hadoop configuration.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)