You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/04 16:43:43 UTC
[GitHub] [flink] azagrebin commented on a change in pull request #10146:
[FLINK-14188][runtime] TaskExecutor derive and register with default slot
resource profile
azagrebin commented on a change in pull request #10146: [FLINK-14188][runtime] TaskExecutor derive and register with default slot resource profile
URL: https://github.com/apache/flink/pull/10146#discussion_r353304527
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
##########
@@ -218,9 +218,22 @@
.build());
// ------------------------------------------------------------------------
- // Memory Options
+ // Resource Options
// ------------------------------------------------------------------------
+ /**
+ * This config option describes number of cpu cores of task executors.
+ * In case of Yarn or Mesos, it is used to launch a container for the task executor.
+ */
+ public static final ConfigOption<Double> CPU_CORES =
+ key("taskmanager.cpu.cores")
+ .doubleType()
+ .noDefaultValue()
+ .withDescription("CPU cores for the TaskExecutors. In case of Yarn setups, this value has to be an integer. "
+ + "If not explicitly configured, legacy config options 'yarn.containers.vcores' and "
+ + "'mesos.resourcemanager.tasks.cpus' will be used for Yarn / Mesos setups, and number of slots "
+ + "(1 / default-slot-fraction) will be used for standalone setups.");
Review comment:
I would say:
`... for Yarn / Mesos setups, and 1 / 'taskmanager.default-slot-fraction' will be used for standalone setups (approximate number of slots).`
Also, the limitation of being an integer number for yarn can be mentioned
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services