You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/09/29 00:00:47 UTC
[GitHub] [incubator-pinot] mcvsubbu opened a new pull request #6069: [Issue 6068] Fixing the calls to Helix to throw exception if zk conne…
mcvsubbu opened a new pull request #6069:
URL: https://github.com/apache/incubator-pinot/pull/6069
…ction is broken
See Issue #6068
## Description
Add a description of your PR here.
A good description should include pointers to an issue or design document, etc.
## Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
* [ ] Yes (Please label as **<code>backward-incompat</code>**, and complete the section below on Release Notes)
Does this PR fix a zero-downtime upgrade introduced earlier?
* [ ] Yes (Please label this as **<code>backward-incompat</code>**, and complete the section below on Release Notes)
Does this PR otherwise need attention when creating release notes? Things to consider:
- New configuration options
- Deprecation of configurations
- Signature changes to public methods/interfaces
- New plugins added or old plugins removed
* [ ] Yes (Please label this PR as **<code>release-notes</code>** and complete the section on Release Notes)
## Release Notes
If you have tagged this as either backward-incompat or release-notes,
you MUST add text here that you would like to see appear in release notes of the
next release.
If you have a series of commits adding or enabling a feature, then
add this section only in final commit that marks the feature completed.
Refer to earlier release notes to see examples of text
## Documentation
If you have introduced a new feature or configuration, please add it to the documentation as well.
See https://docs.pinot.apache.org/developers/developers-and-contributors/update-document
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #6069: [Issue 6068] Fixing the calls to Helix to throw exception if zk conne…
Posted by GitBox <gi...@apache.org>.
mcvsubbu commented on a change in pull request #6069:
URL: https://github.com/apache/incubator-pinot/pull/6069#discussion_r499900482
##########
File path: pinot-common/src/main/java/org/apache/pinot/common/metadata/ZKMetadataProvider.java
##########
@@ -305,7 +308,7 @@ public static Schema getTableSchema(@Nonnull ZkHelixPropertyStore<ZNRecord> prop
ZkHelixPropertyStore<ZNRecord> propertyStore, String tableName) {
String offlineTableName = TableNameBuilder.OFFLINE.tableNameWithType(tableName);
String parentPath = constructPropertyStorePathForResource(offlineTableName);
- List<ZNRecord> znRecords = propertyStore.getChildren(parentPath, null, AccessOption.PERSISTENT);
+ List<ZNRecord> znRecords = propertyStore.getChildren(parentPath, null, AccessOption.PERSISTENT, ZK_OP_RETRY_COUNT, ZK_OP_RETRY_INTERVAL_MS);
Review comment:
We are working with the helix team to give us a new version with the API implemented. Since I took the trouble to trace all the APIs, I took the liberty to modify them so that when we upgrade to newer helix version, we have the right calls
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] Jackie-Jiang commented on pull request #6069: [Issue 6068] Fixing the calls to Helix to throw exception if zk conne…
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on pull request #6069:
URL: https://github.com/apache/incubator-pinot/pull/6069#issuecomment-703951253
@mcvsubbu The unexpected behavior I was referring to is that we explicitly set retry in the method, but Helix won't do the retry, and won't throw exception when the read fails. So I suggest not doing the explicit retry before upgrading the Helix version. But this is not critical. Feel free to merge
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] mcvsubbu commented on pull request #6069: [Issue 6068] Fixing the calls to Helix to throw exception if zk conne…
Posted by GitBox <gi...@apache.org>.
mcvsubbu commented on pull request #6069:
URL: https://github.com/apache/incubator-pinot/pull/6069#issuecomment-703938266
> @mcvsubbu We want both `getChildNames()` and `getChildren()` to have the same behavior, and should throw exception on failures. Since Helix does not have the correct APIs for `getChildren()` yet, I would suggest not changing `getChildren()` for now and wait until we upgrade to the new Helix version, or it will be very confusing for the developers because of the unexpected Helix behavior. Thoughts?
Since the new API has not been implemented yet, there will not be any unexpected behavior at this time, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] mcvsubbu commented on pull request #6069: [Issue 6068] Fixing the calls to Helix to throw exception if zk conne…
Posted by GitBox <gi...@apache.org>.
mcvsubbu commented on pull request #6069:
URL: https://github.com/apache/incubator-pinot/pull/6069#issuecomment-703297016
@Jackie-Jiang I made one more change. Can you take another look please? thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] mcvsubbu merged pull request #6069: [Issue 6068] Fixing the calls to Helix to throw exception if zk conne…
Posted by GitBox <gi...@apache.org>.
mcvsubbu merged pull request #6069:
URL: https://github.com/apache/incubator-pinot/pull/6069
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] Jackie-Jiang commented on pull request #6069: [Issue 6068] Fixing the calls to Helix to throw exception if zk conne…
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on pull request #6069:
URL: https://github.com/apache/incubator-pinot/pull/6069#issuecomment-703929767
@mcvsubbu We want both `getChildNames()` and `getChildren()` to have the same behavior, and should throw exception on failures. Since Helix does not have the correct APIs for `getChildren()` yet, I would suggest not changing `getChildren()` for now and wait until we upgrade to the new Helix version, or it will be very confusing for the developers because of the unexpected Helix behavior. Thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6069: [Issue 6068] Fixing the calls to Helix to throw exception if zk conne…
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on a change in pull request #6069:
URL: https://github.com/apache/incubator-pinot/pull/6069#discussion_r499809705
##########
File path: pinot-common/src/main/java/org/apache/pinot/common/metadata/ZKMetadataProvider.java
##########
@@ -305,7 +308,7 @@ public static Schema getTableSchema(@Nonnull ZkHelixPropertyStore<ZNRecord> prop
ZkHelixPropertyStore<ZNRecord> propertyStore, String tableName) {
String offlineTableName = TableNameBuilder.OFFLINE.tableNameWithType(tableName);
String parentPath = constructPropertyStorePathForResource(offlineTableName);
- List<ZNRecord> znRecords = propertyStore.getChildren(parentPath, null, AccessOption.PERSISTENT);
+ List<ZNRecord> znRecords = propertyStore.getChildren(parentPath, null, AccessOption.PERSISTENT, ZK_OP_RETRY_COUNT, ZK_OP_RETRY_INTERVAL_MS);
Review comment:
This won't take effect... Here is the Helix code for it (I would count it as a bug):
```
@Override
public List<T> getChildren(String parentPath, List<Stat> stats, int options, int retryCount,
int retryInterval) throws HelixException {
return getChildren(parentPath, stats, options);
}
```
I don't see an easy way to throw exception for this API unless we create the children paths manually.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org