You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/06/29 07:16:59 UTC
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4662: Feat/ram reservation
rhtyd commented on a change in pull request #4662:
URL: https://github.com/apache/cloudstack/pull/4662#discussion_r660343877
##########
File path: vmware-base/src/main/java/com/cloud/hypervisor/vmware/util/VmwareHelper.java
##########
@@ -549,12 +549,6 @@ public static void setBasicVmConfig(VirtualMachineConfigSpec vmConfig, int cpuCo
cpuInfo.setReservation((long)cpuReservedMhz);
vmConfig.setCpuAllocation(cpuInfo);
- if (cpuSpeedMHz != cpuReservedMhz) {
- vmConfig.setCpuHotAddEnabled(true);
- }
- if (memoryMB != memoryReserveMB) {
- vmConfig.setMemoryHotAddEnabled(true);
- }
Review comment:
I've my doubts on these changes, pinged vmware experts @harikrishna-patnala @nvazquez @sureshanaparti
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org