You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/09 16:12:08 UTC

[GitHub] [arrow] sweb opened a new pull request #8880: ARROW-10674: [Rust][Parquet] Add Decimal to ArrayBuilderReader WIP

sweb opened a new pull request #8880:
URL: https://github.com/apache/arrow/pull/8880


   This PR introduces capabilities to construct a `DecimalArray` from Parquet files.
   
   This PR requires #8784 to be merged - thus currently the new test will fail. I used the same JIRA issue here - I hope that this is okay.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] andygrove commented on pull request #8880: ARROW-10927: [Rust][Parquet] Add Decimal to ArrayBuilderReader

Posted by GitBox <gi...@apache.org>.
andygrove commented on pull request #8880:
URL: https://github.com/apache/arrow/pull/8880#issuecomment-746502221


   Thanks @sweb. I would like to assign the JIRA to you but need to add you to the contributor role there first but I'm there are multiple JIRA accounts with your name. Could you let me know which one is yours?
   
   ![florian](https://user-images.githubusercontent.com/934084/102370812-bfb80400-3f7a-11eb-9175-6967bd4bcd76.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] sweb commented on pull request #8880: ARROW-10674: [Rust][Parquet] Add Decimal to ArrayBuilderReader

Posted by GitBox <gi...@apache.org>.
sweb commented on pull request #8880:
URL: https://github.com/apache/arrow/pull/8880#issuecomment-743013788


   @seddonm1 @jorgecarleitao thank you for providing context! I will have a look and try to come up with a first implementation.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] andygrove closed pull request #8880: ARROW-10927: [Rust][Parquet] Add Decimal to ArrayBuilderReader

Posted by GitBox <gi...@apache.org>.
andygrove closed pull request #8880:
URL: https://github.com/apache/arrow/pull/8880


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] sweb commented on pull request #8880: ARROW-10674: [Rust][Parquet] Add Decimal to ArrayBuilderReader WIP

Posted by GitBox <gi...@apache.org>.
sweb commented on pull request #8880:
URL: https://github.com/apache/arrow/pull/8880#issuecomment-742488003


   > Also https://issues.apache.org/jira/browse/ARROW-10818
   
   @seddonm1 Thanks for mentioning this issue - I was not aware of it. Could you point me in the direction of some modules / tests I could use to get started with data fusion to help with it? Currently, `DecimalArray` is just a variant of `FixedSizeBinaryArray` that represents its value as `i128` and I assume that ARROW-10818 requires some numeric operations on decimal values.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] nevi-me commented on pull request #8880: ARROW-10927: [Rust][Parquet] Add Decimal to ArrayBuilderReader

Posted by GitBox <gi...@apache.org>.
nevi-me commented on pull request #8880:
URL: https://github.com/apache/arrow/pull/8880#issuecomment-745527239


   That's interesting. I tried reading a fixed size binary today (interval) but Spark complained that it doesn't support reading fixed size binary. So I thought decimal might be backed by something else.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] sweb commented on pull request #8880: ARROW-10927: [Rust][Parquet] Add Decimal to ArrayBuilderReader

Posted by GitBox <gi...@apache.org>.
sweb commented on pull request #8880:
URL: https://github.com/apache/arrow/pull/8880#issuecomment-746306300


   Interesting - now I need to find out why we are writing files in legacy mode ;)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] seddonm1 commented on pull request #8880: ARROW-10674: [Rust][Parquet] Add Decimal to ArrayBuilderReader

Posted by GitBox <gi...@apache.org>.
seddonm1 commented on pull request #8880:
URL: https://github.com/apache/arrow/pull/8880#issuecomment-742764143


   The TPC-H queries are fairly basic but do decimal operations like these which I think are all decimal type: 
   
   ```sql
                   sum(l_quantity) as sum_qty,
                   sum(l_extendedprice) as sum_base_price,
                   sum(l_extendedprice * (1 - l_discount)) as sum_disc_price,
                   sum(l_extendedprice * (1 - l_discount) * (1 + l_tax)) as sum_charge,
                   avg(l_quantity) as avg_qty,
                   avg(l_extendedprice) as avg_price,
                   avg(l_discount) as avg_disc,
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] andygrove commented on pull request #8880: ARROW-10927: [Rust][Parquet] Add Decimal to ArrayBuilderReader

Posted by GitBox <gi...@apache.org>.
andygrove commented on pull request #8880:
URL: https://github.com/apache/arrow/pull/8880#issuecomment-746609688


   Thanks @nevi-me I am looking now


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] jorgecarleitao edited a comment on pull request #8880: ARROW-10674: [Rust][Parquet] Add Decimal to ArrayBuilderReader

Posted by GitBox <gi...@apache.org>.
jorgecarleitao edited a comment on pull request #8880:
URL: https://github.com/apache/arrow/pull/8880#issuecomment-742959778


   @sweb , datafusion is built on top of the arrow crate, and relies on both the array types and the `compute` kernels.
   
   Different nodes in the logical plan require different `compute` kernels. For example, `cast`, `concat` and `take` for `sort`, hashing for group-by ops with the type (if applicable), `MutableArrayData` for the `join`.
   
   [here](https://github.com/apache/arrow/blob/master/rust/datafusion/tests/sql.rs#L1491) is an example of a test that does not check IO with CSV, only the execute in memory.
   
   I do not know if we have DecimalType on the files `ARROW_TEST_DATA`, but if yes, it is a matter of reading it in DataFusion and use it directly (and see where it breaks).
   
   Essentially, almost everything that has a `match datatype` needs to be covered for a complete implementation.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] nevi-me commented on pull request #8880: ARROW-10927: [Rust][Parquet] Add Decimal to ArrayBuilderReader

Posted by GitBox <gi...@apache.org>.
nevi-me commented on pull request #8880:
URL: https://github.com/apache/arrow/pull/8880#issuecomment-746618724


   The reason of the failure is not obvious to me. @sweb we'll need to rebase changes after we reopen this PR, so we can see what the issue is.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] jorgecarleitao commented on pull request #8880: ARROW-10674: [Rust][Parquet] Add Decimal to ArrayBuilderReader

Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #8880:
URL: https://github.com/apache/arrow/pull/8880#issuecomment-742959778


   @sweb , datafusion is built on top of the arrow crate, and relies on both the array types and the `compute` kernels.
   
   Different nodes in the logical plan require different `compute` kernels. For example, `cast`, `concat` and `take` for `sort`, hashing for group-by ops with the type (if applicable), `MutableArrayData` for the `join`.
   
   [here](https://github.com/apache/arrow/blob/master/rust/datafusion/tests/sql.rs#L1491) is an example of a test that does not check IO with CSV, only the execute in memory.
   
   I do not know if we have DecimalType on the files `ARROW_TEST_DATA`, but if yes, it is a matter of reading it in DataFusion and use it directly.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] sweb commented on pull request #8880: ARROW-10927: [Rust][Parquet] Add Decimal to ArrayBuilderReader

Posted by GitBox <gi...@apache.org>.
sweb commented on pull request #8880:
URL: https://github.com/apache/arrow/pull/8880#issuecomment-746697508


   @nevi-me @andygrove I will take a look at it and try to resolve it once master is stable and this PR is reopened.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] sweb commented on pull request #8880: ARROW-10927: [Rust][Parquet] Add Decimal to ArrayBuilderReader

Posted by GitBox <gi...@apache.org>.
sweb commented on pull request #8880:
URL: https://github.com/apache/arrow/pull/8880#issuecomment-746549299


   Thanks @andygrove. `florian.mueller` is the correct one!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #8880: ARROW-10927: [Rust][Parquet] Add Decimal to ArrayBuilderReader

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8880:
URL: https://github.com/apache/arrow/pull/8880#issuecomment-745452911


   https://issues.apache.org/jira/browse/ARROW-10927


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] nevi-me commented on pull request #8880: ARROW-10674: [Rust][Parquet] Add Decimal to ArrayBuilderReader

Posted by GitBox <gi...@apache.org>.
nevi-me commented on pull request #8880:
URL: https://github.com/apache/arrow/pull/8880#issuecomment-745280514


   > I used the same JIRA issue here - I hope that this is okay.
   
   Please open a separate JIRA 😃 
   
   The Parquet spec supports reading decimal data from a few other types (`i32`, `i64`, `binary`) https://github.com/apache/parquet-format/blob/master/LogicalTypes.md#decimal.
   
   I think reading from `FixedSizeList` is a good start, but we should tackle the other types at some point. Also see #8926 where I've made similar changes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] seddonm1 commented on pull request #8880: ARROW-10674: [Rust][Parquet] Add Decimal to ArrayBuilderReader WIP

Posted by GitBox <gi...@apache.org>.
seddonm1 commented on pull request #8880:
URL: https://github.com/apache/arrow/pull/8880#issuecomment-742066198


   Also https://issues.apache.org/jira/browse/ARROW-10818


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] sweb commented on pull request #8880: ARROW-10927: [Rust][Parquet] Add Decimal to ArrayBuilderReader

Posted by GitBox <gi...@apache.org>.
sweb commented on pull request #8880:
URL: https://github.com/apache/arrow/pull/8880#issuecomment-745447636


   > > I used the same JIRA issue here - I hope that this is okay.
   > 
   > Please open a separate JIRA 😃
   > 
   > The Parquet spec supports reading decimal data from a few other types (`i32`, `i64`, `binary`) https://github.com/apache/parquet-format/blob/master/LogicalTypes.md#decimal.
   > 
   > I think reading from `FixedSizeList` is a good start, but we should tackle the other types at some point. Also see #8926 where I've made similar changes.
   
   @nevi-me thank you for your review! I have opened a [new issue](https://issues.apache.org/jira/browse/ARROW-10926) with a [subtask](https://issues.apache.org/jira/browse/ARROW-10927) specific to this PR. I will try to provide implementations for missing types (I only considered fixed size binary, since this is what I get from Spark ;)) and add the corresponding writers as well.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] seddonm1 commented on pull request #8880: ARROW-10927: [Rust][Parquet] Add Decimal to ArrayBuilderReader

Posted by GitBox <gi...@apache.org>.
seddonm1 commented on pull request #8880:
URL: https://github.com/apache/arrow/pull/8880#issuecomment-745537155


   @nevi-me  Here are the links to the Spark Parquet docs which talk about "legacy" mode which I think is what you are bumping into: https://spark.apache.org/docs/latest/sql-data-sources-parquet.html#configuration


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] andygrove commented on pull request #8880: ARROW-10927: [Rust][Parquet] Add Decimal to ArrayBuilderReader

Posted by GitBox <gi...@apache.org>.
andygrove commented on pull request #8880:
URL: https://github.com/apache/arrow/pull/8880#issuecomment-746610857


   I will revert this PR for now


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] jorgecarleitao closed pull request #8880: ARROW-10927: [Rust][Parquet] Add Decimal to ArrayBuilderReader

Posted by GitBox <gi...@apache.org>.
jorgecarleitao closed pull request #8880:
URL: https://github.com/apache/arrow/pull/8880


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] sweb commented on pull request #8880: ARROW-10927: [Rust][Parquet] Add Decimal to ArrayBuilderReader

Posted by GitBox <gi...@apache.org>.
sweb commented on pull request #8880:
URL: https://github.com/apache/arrow/pull/8880#issuecomment-747305340


   @nevi-me @andygrove I fixed the issue. There is still a CI failure, though I think that this is unrelated and just a hickup. Is there a way to restart the CI job without whitespace-commit?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #8880: ARROW-10674: [Rust][Parquet] Add Decimal to ArrayBuilderReader WIP

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8880:
URL: https://github.com/apache/arrow/pull/8880#issuecomment-741897252


   https://issues.apache.org/jira/browse/ARROW-10674


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] nevi-me commented on pull request #8880: ARROW-10927: [Rust][Parquet] Add Decimal to ArrayBuilderReader

Posted by GitBox <gi...@apache.org>.
nevi-me commented on pull request #8880:
URL: https://github.com/apache/arrow/pull/8880#issuecomment-746604355


   @andygrove @sweb we've got CI failures, I suspect we merged too many changes without rebasing.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] codecov-io commented on pull request #8880: ARROW-10674: [Rust][Parquet] Add Decimal to ArrayBuilderReader WIP

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #8880:
URL: https://github.com/apache/arrow/pull/8880#issuecomment-741878772


   # [Codecov](https://codecov.io/gh/apache/arrow/pull/8880?src=pr&el=h1) Report
   > Merging [#8880](https://codecov.io/gh/apache/arrow/pull/8880?src=pr&el=desc) (6930c5c) into [master](https://codecov.io/gh/apache/arrow/commit/38cfdc3c95c0066b7b6a9b7fb5a47494decf7805?el=desc) (38cfdc3) will **increase** coverage by `2.10%`.
   > The diff coverage is `75.40%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/arrow/pull/8880/graphs/tree.svg?width=650&height=150&src=pr&token=LpTCFbqVT1)](https://codecov.io/gh/apache/arrow/pull/8880?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #8880      +/-   ##
   ==========================================
   + Coverage   52.92%   55.03%   +2.10%     
   ==========================================
     Files         172      170       -2     
     Lines       30710    30739      +29     
   ==========================================
   + Hits        16253    16916     +663     
   + Misses      14457    13823     -634     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/arrow/pull/8880?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [rust/parquet/src/arrow/array\_reader.rs](https://codecov.io/gh/apache/arrow/pull/8880/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9hcnJvdy9hcnJheV9yZWFkZXIucnM=) | `71.99% <52.38%> (+71.99%)` | :arrow_up: |
   | [rust/parquet/src/arrow/schema.rs](https://codecov.io/gh/apache/arrow/pull/8880/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9hcnJvdy9zY2hlbWEucnM=) | `91.29% <63.63%> (+91.29%)` | :arrow_up: |
   | [rust/parquet/src/arrow/converter.rs](https://codecov.io/gh/apache/arrow/pull/8880/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9hcnJvdy9jb252ZXJ0ZXIucnM=) | `62.62% <94.44%> (+62.62%)` | :arrow_up: |
   | [rust/parquet/src/arrow/arrow\_reader.rs](https://codecov.io/gh/apache/arrow/pull/8880/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9hcnJvdy9hcnJvd19yZWFkZXIucnM=) | `91.16% <100.00%> (+91.16%)` | :arrow_up: |
   | [rust/arrow/src/array/cast.rs](https://codecov.io/gh/apache/arrow/pull/8880/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvY2FzdC5ycw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [rust/arrow/src/array/equal/decimal.rs](https://codecov.io/gh/apache/arrow/pull/8880/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvZXF1YWwvZGVjaW1hbC5ycw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [rust/arrow/src/array/transform/utils.rs](https://codecov.io/gh/apache/arrow/pull/8880/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL3V0aWxzLnJz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [rust/arrow/src/compute/kernels/limit.rs](https://codecov.io/gh/apache/arrow/pull/8880/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL2xpbWl0LnJz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [rust/arrow/src/array/equal/fixed\_list.rs](https://codecov.io/gh/apache/arrow/pull/8880/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvZXF1YWwvZml4ZWRfbGlzdC5ycw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [rust/arrow/src/compute/kernels/length.rs](https://codecov.io/gh/apache/arrow/pull/8880/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL2xlbmd0aC5ycw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [107 more](https://codecov.io/gh/apache/arrow/pull/8880/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/8880?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/8880?src=pr&el=footer). Last update [38cfdc3...6930c5c](https://codecov.io/gh/apache/arrow/pull/8880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] codecov-io edited a comment on pull request #8880: ARROW-10927: [Rust][Parquet] Add Decimal to ArrayBuilderReader

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #8880:
URL: https://github.com/apache/arrow/pull/8880#issuecomment-741878772


   # [Codecov](https://codecov.io/gh/apache/arrow/pull/8880?src=pr&el=h1) Report
   > Merging [#8880](https://codecov.io/gh/apache/arrow/pull/8880?src=pr&el=desc) (f2fc213) into [master](https://codecov.io/gh/apache/arrow/commit/d65ba4ec5daeb93ca5031f883d08d559b68753b2?el=desc) (d65ba4e) will **decrease** coverage by `0.00%`.
   > The diff coverage is `75.40%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/arrow/pull/8880/graphs/tree.svg?width=650&height=150&src=pr&token=LpTCFbqVT1)](https://codecov.io/gh/apache/arrow/pull/8880?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #8880      +/-   ##
   ==========================================
   - Coverage   83.25%   83.24%   -0.01%     
   ==========================================
     Files         196      196              
     Lines       48116    48177      +61     
   ==========================================
   + Hits        40059    40106      +47     
   - Misses       8057     8071      +14     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/arrow/pull/8880?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [rust/parquet/src/arrow/array\_reader.rs](https://codecov.io/gh/apache/arrow/pull/8880/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9hcnJvdy9hcnJheV9yZWFkZXIucnM=) | `77.00% <52.38%> (-0.56%)` | :arrow_down: |
   | [rust/parquet/src/arrow/schema.rs](https://codecov.io/gh/apache/arrow/pull/8880/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9hcnJvdy9zY2hlbWEucnM=) | `91.31% <63.63%> (-0.50%)` | :arrow_down: |
   | [rust/parquet/src/arrow/converter.rs](https://codecov.io/gh/apache/arrow/pull/8880/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9hcnJvdy9jb252ZXJ0ZXIucnM=) | `68.68% <94.44%> (+5.72%)` | :arrow_up: |
   | [rust/parquet/src/arrow/arrow\_reader.rs](https://codecov.io/gh/apache/arrow/pull/8880/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9hcnJvdy9hcnJvd19yZWFkZXIucnM=) | `91.16% <100.00%> (+0.57%)` | :arrow_up: |
   | [rust/arrow/src/array/array\_binary.rs](https://codecov.io/gh/apache/arrow/pull/8880/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfYmluYXJ5LnJz) | `90.73% <0.00%> (+0.21%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/8880?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/8880?src=pr&el=footer). Last update [d65ba4e...56b643b](https://codecov.io/gh/apache/arrow/pull/8880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] nevi-me commented on pull request #8880: ARROW-10927: [Rust][Parquet] Add Decimal to ArrayBuilderReader

Posted by GitBox <gi...@apache.org>.
nevi-me commented on pull request #8880:
URL: https://github.com/apache/arrow/pull/8880#issuecomment-747311895


   I've restarted the job, we can merge this after CI is all green. Thanks @sweb 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org