You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2015/04/10 11:58:12 UTC
[jira] [Commented] (QPID-6485) Remove superfluous find/get methods
from the Broker configured object
[ https://issues.apache.org/jira/browse/QPID-6485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14489293#comment-14489293 ]
ASF subversion and git services commented on QPID-6485:
-------------------------------------------------------
Commit 1672602 from [~k-wall] in branch 'qpid/trunk'
[ https://svn.apache.org/r1672602 ]
QPID-6485: [Java Broker] Remove superfluous find/get methods from the Broker configured object
> Remove superfluous find/get methods from the Broker configured object
> ---------------------------------------------------------------------
>
> Key: QPID-6485
> URL: https://issues.apache.org/jira/browse/QPID-6485
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Keith Wall
> Assignee: Keith Wall
> Fix For: 6.0 [Java]
>
>
> The Broker object has a number of find/get methods which traverse deep into the model hierarchy, for instance, getSubjectCreator traverses Broker->Port->AuthenticationProvider->SubjectCreator.
> It turns out the callers of these methods already possess a more closer more suitable configured object within the model, for instance the ProtocolEngines already possess the Port.
> Refactor the code to remove these methods avoiding violating Demeter's Law quite so much.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org