[GitHub] [druid] zachjsh commented on a change in pull request #9306: implement Azure InputSource reader and deprecate Azure FireHose

[GitBox <gi...@apache.org>]

zachjsh commented on a change in pull request #9306: implement Azure InputSource reader and deprecate Azure FireHose
URL: https://github.com/apache/druid/pull/9306#discussion_r374384794
 
 

 ##########
 File path: core/src/main/java/org/apache/druid/data/input/impl/CloudObjectInputSource.java
 ##########
 @@ -40,6 +40,7 @@
 public abstract class CloudObjectInputSource<T extends InputEntity> extends AbstractInputSource
     implements SplittableInputSource<CloudObjectLocation>
 {
+  protected static final int MAX_LISTING_LENGTH = 1024;
 
 Review comment:
   I talked to @clintropolis  about the Google limit and that was a mistake, was meant to be 1024 as well. I figured since they are all 1024 now, we could abstract that to base class, and then override in the specific implementation if necessary, which right now it doesn't seem to be so. I agree that this should be configurable.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org