You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/01/21 09:36:56 UTC

[GitHub] [bookkeeper] StevenLuMT opened a new pull request #3006: improve rocksDB

StevenLuMT opened a new pull request #3006:
URL: https://github.com/apache/bookkeeper/pull/3006


   
   Descriptions of the changes in this PR:
   
   ### Motivation
   
   1. some old parameters in rocksDB is not configurable
   2. the rocksDB write/read has no rate limiter
   
   ### Changes
   
   1.rocks all old parameter change to be configurable
   2.add RateLimiter feature,default closed
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] zymap commented on pull request #3006: improve rocksDB

Posted by GitBox <gi...@apache.org>.
zymap commented on pull request #3006:
URL: https://github.com/apache/bookkeeper/pull/3006#issuecomment-1019702111


   I would suggest using the RocksDB config file directly. That will make us don't need to introduce extra configuration changes in the bookkeeper repo.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] StevenLuMT commented on pull request #3006: improve rocksDB

Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on pull request #3006:
URL: https://github.com/apache/bookkeeper/pull/3006#issuecomment-1018685019


   @eolivelli @pkumar-singh @zymap
   If you have time, please help me review it, thank you


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] StevenLuMT commented on pull request #3006: improve rocksDB

Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on pull request #3006:
URL: https://github.com/apache/bookkeeper/pull/3006#issuecomment-1018431012


   rerun failure checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] StevenLuMT commented on pull request #3006: improve rocksDB

Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on pull request #3006:
URL: https://github.com/apache/bookkeeper/pull/3006#issuecomment-1019016434


   > have you considered adding support to use the native RocksDB configuration file support? https://github.com/facebook/rocksdb/blob/main/java/src/main/java/org/rocksdb/OptionsUtil.java
   
   I think it's a good idea, finished this pr, I will research that direction 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] StevenLuMT closed pull request #3006: improve rocksDB

Posted by GitBox <gi...@apache.org>.
StevenLuMT closed pull request #3006:
URL: https://github.com/apache/bookkeeper/pull/3006


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] StevenLuMT removed a comment on pull request #3006: improve rocksDB

Posted by GitBox <gi...@apache.org>.
StevenLuMT removed a comment on pull request #3006:
URL: https://github.com/apache/bookkeeper/pull/3006#issuecomment-1018431012


   rerun failure checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] mauricebarnum commented on pull request #3006: improve rocksDB

Posted by GitBox <gi...@apache.org>.
mauricebarnum commented on pull request #3006:
URL: https://github.com/apache/bookkeeper/pull/3006#issuecomment-1019000276


   have you considered adding support to use the native RocksDB configuration file support? https://github.com/facebook/rocksdb/blob/main/java/src/main/java/org/rocksdb/OptionsUtil.java


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org