You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Navis (JIRA)" <ji...@apache.org> on 2012/06/06 04:58:22 UTC

[jira] [Created] (HIVE-3090) Timestamp type values not having nano-second part breaks row

Navis created HIVE-3090:
---------------------------

             Summary: Timestamp type values not having nano-second part breaks row
                 Key: HIVE-3090
                 URL: https://issues.apache.org/jira/browse/HIVE-3090
             Project: Hive
          Issue Type: Bug
          Components: Serializers/Deserializers
    Affects Versions: 0.10.0
            Reporter: Navis
            Assignee: Navis
            Priority: Critical


Timestamp values are reading additional one byte if nano-sec part is zero, breaking following columns.  
{noformat}
>create table timestamp_1 (t timestamp, key string, value string);
>insert overwrite table timestamp_1 select cast('2011-01-01 01:01:01' as timestamp), key, value from src limit 5;

>select t,key,value from timestamp_1;
2011-01-01 01:01:01		238
2011-01-01 01:01:01		86
2011-01-01 01:01:01		311
2011-01-01 01:01:01		27
2011-01-01 01:01:01		165

>select t,key,value from timestamp_1 distribute by t;
2011-01-01 01:01:01		
2011-01-01 01:01:01		
2011-01-01 01:01:01		
2011-01-01 01:01:01		
2011-01-01 01:01:01		
{noformat}


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-3090) Timestamp type values not having nano-second part breaks row

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-3090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294690#comment-13294690 ] 

Hudson commented on HIVE-3090:
------------------------------

Integrated in Hive-trunk-h0.21 #1485 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1485/])
    HIVE-3090 Timestamp types not having nano-second part breaks row (Navis via egc) (Revision 1349907)

     Result = FAILURE
ecapriolo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1349907
Files : 
* /hive/trunk/ql/src/test/queries/clientpositive/timestamp_lazy.q
* /hive/trunk/ql/src/test/results/clientpositive/timestamp_lazy.q.out
* /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/io/TimestampWritable.java

                
> Timestamp type values not having nano-second part breaks row
> ------------------------------------------------------------
>
>                 Key: HIVE-3090
>                 URL: https://issues.apache.org/jira/browse/HIVE-3090
>             Project: Hive
>          Issue Type: Bug
>          Components: Serializers/Deserializers
>    Affects Versions: 0.10.0
>            Reporter: Navis
>            Assignee: Navis
>            Priority: Critical
>             Fix For: 0.10.0
>
>         Attachments: hive-3090.1.patch.txt, hive-3090.1.patch.txt
>
>
> Timestamp values are reading additional one byte if nano-sec part is zero, breaking following columns.  
> {noformat}
> >create table timestamp_1 (t timestamp, key string, value string);
> >insert overwrite table timestamp_1 select cast('2011-01-01 01:01:01' as timestamp), key, value from src limit 5;
> >select t,key,value from timestamp_1;
> 2011-01-01 01:01:01		238
> 2011-01-01 01:01:01		86
> 2011-01-01 01:01:01		311
> 2011-01-01 01:01:01		27
> 2011-01-01 01:01:01		165
> >select t,key,value from timestamp_1 distribute by t;
> 2011-01-01 01:01:01		
> 2011-01-01 01:01:01		
> 2011-01-01 01:01:01		
> 2011-01-01 01:01:01		
> 2011-01-01 01:01:01		
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (HIVE-3090) Timestamp type values not having nano-second part breaks row

Posted by "Edward Capriolo (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-3090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edward Capriolo resolved HIVE-3090.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 0.10.0

Thanks Navis. 
                
> Timestamp type values not having nano-second part breaks row
> ------------------------------------------------------------
>
>                 Key: HIVE-3090
>                 URL: https://issues.apache.org/jira/browse/HIVE-3090
>             Project: Hive
>          Issue Type: Bug
>          Components: Serializers/Deserializers
>    Affects Versions: 0.10.0
>            Reporter: Navis
>            Assignee: Navis
>            Priority: Critical
>             Fix For: 0.10.0
>
>         Attachments: hive-3090.1.patch.txt, hive-3090.1.patch.txt
>
>
> Timestamp values are reading additional one byte if nano-sec part is zero, breaking following columns.  
> {noformat}
> >create table timestamp_1 (t timestamp, key string, value string);
> >insert overwrite table timestamp_1 select cast('2011-01-01 01:01:01' as timestamp), key, value from src limit 5;
> >select t,key,value from timestamp_1;
> 2011-01-01 01:01:01		238
> 2011-01-01 01:01:01		86
> 2011-01-01 01:01:01		311
> 2011-01-01 01:01:01		27
> 2011-01-01 01:01:01		165
> >select t,key,value from timestamp_1 distribute by t;
> 2011-01-01 01:01:01		
> 2011-01-01 01:01:01		
> 2011-01-01 01:01:01		
> 2011-01-01 01:01:01		
> 2011-01-01 01:01:01		
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-3090) Timestamp type values not having nano-second part breaks row

Posted by "Edward Capriolo (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-3090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294173#comment-13294173 ] 

Edward Capriolo commented on HIVE-3090:
---------------------------------------

+1 will commit. Your a patch machine superstar.
                
> Timestamp type values not having nano-second part breaks row
> ------------------------------------------------------------
>
>                 Key: HIVE-3090
>                 URL: https://issues.apache.org/jira/browse/HIVE-3090
>             Project: Hive
>          Issue Type: Bug
>          Components: Serializers/Deserializers
>    Affects Versions: 0.10.0
>            Reporter: Navis
>            Assignee: Navis
>            Priority: Critical
>
> Timestamp values are reading additional one byte if nano-sec part is zero, breaking following columns.  
> {noformat}
> >create table timestamp_1 (t timestamp, key string, value string);
> >insert overwrite table timestamp_1 select cast('2011-01-01 01:01:01' as timestamp), key, value from src limit 5;
> >select t,key,value from timestamp_1;
> 2011-01-01 01:01:01		238
> 2011-01-01 01:01:01		86
> 2011-01-01 01:01:01		311
> 2011-01-01 01:01:01		27
> 2011-01-01 01:01:01		165
> >select t,key,value from timestamp_1 distribute by t;
> 2011-01-01 01:01:01		
> 2011-01-01 01:01:01		
> 2011-01-01 01:01:01		
> 2011-01-01 01:01:01		
> 2011-01-01 01:01:01		
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-3090) Timestamp type values not having nano-second part breaks row

Posted by "Navis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-3090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Navis updated HIVE-3090:
------------------------

    Status: Patch Available  (was: Open)

https://reviews.facebook.net/D3501
                
> Timestamp type values not having nano-second part breaks row
> ------------------------------------------------------------
>
>                 Key: HIVE-3090
>                 URL: https://issues.apache.org/jira/browse/HIVE-3090
>             Project: Hive
>          Issue Type: Bug
>          Components: Serializers/Deserializers
>    Affects Versions: 0.10.0
>            Reporter: Navis
>            Assignee: Navis
>            Priority: Critical
>
> Timestamp values are reading additional one byte if nano-sec part is zero, breaking following columns.  
> {noformat}
> >create table timestamp_1 (t timestamp, key string, value string);
> >insert overwrite table timestamp_1 select cast('2011-01-01 01:01:01' as timestamp), key, value from src limit 5;
> >select t,key,value from timestamp_1;
> 2011-01-01 01:01:01		238
> 2011-01-01 01:01:01		86
> 2011-01-01 01:01:01		311
> 2011-01-01 01:01:01		27
> 2011-01-01 01:01:01		165
> >select t,key,value from timestamp_1 distribute by t;
> 2011-01-01 01:01:01		
> 2011-01-01 01:01:01		
> 2011-01-01 01:01:01		
> 2011-01-01 01:01:01		
> 2011-01-01 01:01:01		
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-3090) Timestamp type values not having nano-second part breaks row

Posted by "Edward Capriolo (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-3090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294509#comment-13294509 ] 

Edward Capriolo commented on HIVE-3090:
---------------------------------------

Your right the problem is that ivy cache issue. +1 will commit.
                
> Timestamp type values not having nano-second part breaks row
> ------------------------------------------------------------
>
>                 Key: HIVE-3090
>                 URL: https://issues.apache.org/jira/browse/HIVE-3090
>             Project: Hive
>          Issue Type: Bug
>          Components: Serializers/Deserializers
>    Affects Versions: 0.10.0
>            Reporter: Navis
>            Assignee: Navis
>            Priority: Critical
>
> Timestamp values are reading additional one byte if nano-sec part is zero, breaking following columns.  
> {noformat}
> >create table timestamp_1 (t timestamp, key string, value string);
> >insert overwrite table timestamp_1 select cast('2011-01-01 01:01:01' as timestamp), key, value from src limit 5;
> >select t,key,value from timestamp_1;
> 2011-01-01 01:01:01		238
> 2011-01-01 01:01:01		86
> 2011-01-01 01:01:01		311
> 2011-01-01 01:01:01		27
> 2011-01-01 01:01:01		165
> >select t,key,value from timestamp_1 distribute by t;
> 2011-01-01 01:01:01		
> 2011-01-01 01:01:01		
> 2011-01-01 01:01:01		
> 2011-01-01 01:01:01		
> 2011-01-01 01:01:01		
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-3090) Timestamp type values not having nano-second part breaks row

Posted by "Edward Capriolo (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-3090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edward Capriolo updated HIVE-3090:
----------------------------------

    Attachment: hive-3090.1.patch.txt

Final patch for inclusion
                
> Timestamp type values not having nano-second part breaks row
> ------------------------------------------------------------
>
>                 Key: HIVE-3090
>                 URL: https://issues.apache.org/jira/browse/HIVE-3090
>             Project: Hive
>          Issue Type: Bug
>          Components: Serializers/Deserializers
>    Affects Versions: 0.10.0
>            Reporter: Navis
>            Assignee: Navis
>            Priority: Critical
>         Attachments: hive-3090.1.patch.txt
>
>
> Timestamp values are reading additional one byte if nano-sec part is zero, breaking following columns.  
> {noformat}
> >create table timestamp_1 (t timestamp, key string, value string);
> >insert overwrite table timestamp_1 select cast('2011-01-01 01:01:01' as timestamp), key, value from src limit 5;
> >select t,key,value from timestamp_1;
> 2011-01-01 01:01:01		238
> 2011-01-01 01:01:01		86
> 2011-01-01 01:01:01		311
> 2011-01-01 01:01:01		27
> 2011-01-01 01:01:01		165
> >select t,key,value from timestamp_1 distribute by t;
> 2011-01-01 01:01:01		
> 2011-01-01 01:01:01		
> 2011-01-01 01:01:01		
> 2011-01-01 01:01:01		
> 2011-01-01 01:01:01		
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-3090) Timestamp type values not having nano-second part breaks row

Posted by "Navis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-3090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294241#comment-13294241 ] 

Navis commented on HIVE-3090:
-----------------------------

I've rebased to trunk, tested and confirmed that it works fine. Could you try it again after deleting hive-serde in local repository or cache?
                
> Timestamp type values not having nano-second part breaks row
> ------------------------------------------------------------
>
>                 Key: HIVE-3090
>                 URL: https://issues.apache.org/jira/browse/HIVE-3090
>             Project: Hive
>          Issue Type: Bug
>          Components: Serializers/Deserializers
>    Affects Versions: 0.10.0
>            Reporter: Navis
>            Assignee: Navis
>            Priority: Critical
>
> Timestamp values are reading additional one byte if nano-sec part is zero, breaking following columns.  
> {noformat}
> >create table timestamp_1 (t timestamp, key string, value string);
> >insert overwrite table timestamp_1 select cast('2011-01-01 01:01:01' as timestamp), key, value from src limit 5;
> >select t,key,value from timestamp_1;
> 2011-01-01 01:01:01		238
> 2011-01-01 01:01:01		86
> 2011-01-01 01:01:01		311
> 2011-01-01 01:01:01		27
> 2011-01-01 01:01:01		165
> >select t,key,value from timestamp_1 distribute by t;
> 2011-01-01 01:01:01		
> 2011-01-01 01:01:01		
> 2011-01-01 01:01:01		
> 2011-01-01 01:01:01		
> 2011-01-01 01:01:01		
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-3090) Timestamp type values not having nano-second part breaks row

Posted by "Edward Capriolo (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-3090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edward Capriolo updated HIVE-3090:
----------------------------------

    Attachment: hive-3090.1.patch.txt
    
> Timestamp type values not having nano-second part breaks row
> ------------------------------------------------------------
>
>                 Key: HIVE-3090
>                 URL: https://issues.apache.org/jira/browse/HIVE-3090
>             Project: Hive
>          Issue Type: Bug
>          Components: Serializers/Deserializers
>    Affects Versions: 0.10.0
>            Reporter: Navis
>            Assignee: Navis
>            Priority: Critical
>         Attachments: hive-3090.1.patch.txt, hive-3090.1.patch.txt
>
>
> Timestamp values are reading additional one byte if nano-sec part is zero, breaking following columns.  
> {noformat}
> >create table timestamp_1 (t timestamp, key string, value string);
> >insert overwrite table timestamp_1 select cast('2011-01-01 01:01:01' as timestamp), key, value from src limit 5;
> >select t,key,value from timestamp_1;
> 2011-01-01 01:01:01		238
> 2011-01-01 01:01:01		86
> 2011-01-01 01:01:01		311
> 2011-01-01 01:01:01		27
> 2011-01-01 01:01:01		165
> >select t,key,value from timestamp_1 distribute by t;
> 2011-01-01 01:01:01		
> 2011-01-01 01:01:01		
> 2011-01-01 01:01:01		
> 2011-01-01 01:01:01		
> 2011-01-01 01:01:01		
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-3090) Timestamp type values not having nano-second part breaks row

Posted by "Edward Capriolo (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-3090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edward Capriolo updated HIVE-3090:
----------------------------------

    Status: Open  (was: Patch Available)

Are you sure you have the most recent patch? I am not seeing the expected results. Please upload the patch to Jira.

[edward@tablitha trunk]$ diff -y  /home/edward/hive/trunk/build/ql/test/logs/clientpositive/timestamp_lazy.q.out /home/edward/hive/trunk/ql/src/test/results/clientpositive/timestamp_lazy.q.out

POSTHOOK: Lineage: timestamp_lazy.value SIMPLE [(src)src.Fiel	POSTHOOK: Lineage: timestamp_lazy.value SIMPLE [(src)src.Fiel
2011-01-01 01:01:01					      |	2011-01-01 01:01:01	238	val_238
2011-01-01 01:01:01					      |	2011-01-01 01:01:01	86	val_86
2011-01-01 01:01:01					      |	2011-01-01 01:01:01	311	val_311
2011-01-01 01:01:01					      |	2011-01-01 01:01:01	27	val_27
2011-01-01 01:01:01					      |	2011-01-01 01:01:01	165	val_165


                
> Timestamp type values not having nano-second part breaks row
> ------------------------------------------------------------
>
>                 Key: HIVE-3090
>                 URL: https://issues.apache.org/jira/browse/HIVE-3090
>             Project: Hive
>          Issue Type: Bug
>          Components: Serializers/Deserializers
>    Affects Versions: 0.10.0
>            Reporter: Navis
>            Assignee: Navis
>            Priority: Critical
>
> Timestamp values are reading additional one byte if nano-sec part is zero, breaking following columns.  
> {noformat}
> >create table timestamp_1 (t timestamp, key string, value string);
> >insert overwrite table timestamp_1 select cast('2011-01-01 01:01:01' as timestamp), key, value from src limit 5;
> >select t,key,value from timestamp_1;
> 2011-01-01 01:01:01		238
> 2011-01-01 01:01:01		86
> 2011-01-01 01:01:01		311
> 2011-01-01 01:01:01		27
> 2011-01-01 01:01:01		165
> >select t,key,value from timestamp_1 distribute by t;
> 2011-01-01 01:01:01		
> 2011-01-01 01:01:01		
> 2011-01-01 01:01:01		
> 2011-01-01 01:01:01		
> 2011-01-01 01:01:01		
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira