[GitHub] [tomcat-jakartaee-migration] aooohan commented on pull request #30: Exception in thread "main" java.util.zip.ZipException: Bad CRC checksum for entry

[GitBox <gi...@apache.org>]

aooohan commented on PR #30:
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/30#issuecomment-1208932186

   > If I am reading this correctly, a side-effect of this change is that entries that were previously `STORED` will now be `DEFLATED`.
   
   Yes, I now don't think that's very elegant, so I tried another way to handle the case where the archive entries is `STORED`. Although there is some performance loss in doing this, it will only affect archive entries that are `STORED`, but it is still faster than processing in memory.
   
   @markt-asf  Please review the new changes, thanks.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org