[jira] [Comment Edited] (RATIS-848) Failed UT: TestRaftSnapshotWithGrpc.testBasicInstallSnapshot

["Aravindan Vijayan (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/RATIS-848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097702#comment-17097702 ] 

Aravindan Vijayan edited comment on RATIS-848 at 5/1/20, 10:15 PM:
-------------------------------------------------------------------

+1 LGTM. [~yjxxtd] Thanks for working on this.  I will resolve the other JIRA as duplicate. 


was (Author: avijayan):
+1 LGTM. [~yjxxtd] Please close the other JIRA as duplicate. 

> Failed UT: TestRaftSnapshotWithGrpc.testBasicInstallSnapshot
> ------------------------------------------------------------
>
>                 Key: RATIS-848
>                 URL: https://issues.apache.org/jira/browse/RATIS-848
>             Project: Ratis
>          Issue Type: Sub-task
>          Components: test
>            Reporter: runzhiwang
>            Assignee: runzhiwang
>            Priority: Minor
>         Attachments: RATIS-848.001.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> *Why unit test TestRaftSnapshotWithGrpc.testBasicInstallSnapshot failed?*
> In the test, leader take snapshot, then add two followers, then [leader restart|https://github.com/apache/incubator-ratis/blob/master/ratis-server/src/test/java/org/apache/ratis/statemachine/RaftSnapshotBaseTest.java#L234], then [verifyTakeSnapshotMetric|https://github.com/apache/incubator-ratis/blob/master/ratis-server/src/test/java/org/apache/ratis/statemachine/RaftSnapshotBaseTest.java#L236]. 
> It must be failed when verifyTakeSnapshotMetric after restarting leader. Because restart leader will create a new instance of RaftServer, the metric of take snapshot is clean.
> *How to fix ?*
> verifyTakeSnapshotMetric after leader take snapshot.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)