[whimsy] 02/02: add commit and email to icla processing

[ru...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

rubys pushed a commit to branch master
in repository https://git-dual.apache.org/repos/asf/whimsy.git

commit cc3c90f08d1b9d1b73a5100fb22b4074840a2a02
Author: Sam Ruby <ru...@intertwingly.net>
AuthorDate: Mon Sep 12 13:44:21 2016 -0400

    add commit and email to icla processing
---
 www/secmail/server.rb                  |  3 +++
 www/secmail/views/actions/icla.json.rb | 20 ++++++++++++++++----
 2 files changed, 19 insertions(+), 4 deletions(-)

diff --git a/www/secmail/server.rb b/www/secmail/server.rb
index 9f5a92b..331d5ae 100644
--- a/www/secmail/server.rb
+++ b/www/secmail/server.rb
@@ -16,6 +16,9 @@ require_relative 'models/mailbox'
 require_relative 'models/safetemp'
 require_relative 'models/events'
 
+require 'whimsy/asf'
+ASF::Mail.configure
+
 class Wunderbar::JsonBuilder
   def _task(title, &block)
     if not @task
diff --git a/www/secmail/views/actions/icla.json.rb b/www/secmail/views/actions/icla.json.rb
index e831256..9ad022e 100644
--- a/www/secmail/views/actions/icla.json.rb
+++ b/www/secmail/views/actions/icla.json.rb
@@ -23,8 +23,13 @@ _task "svn commit documents/iclas/#@filename#{fileext}" do
     # create/add file(s)
     dest = message.write_svn("#{dir}/iclas", @filename, @selected, @signature)
 
-    # stub for now
+    # Show files to be added
     _.system 'svn', 'status', "#{dir}/iclas"
+
+    # commit changes
+    _.system! 'svn', 'commit', "#{dir}/iclas/#{@filename}",
+      ['--non-interactive', '--no-auth-cache'],
+      ['--username', env.user.untaint, '--password', env.password.untaint]
   end
 end
 
@@ -58,7 +63,13 @@ _task "svn commit foundation/officers/iclas.txt" do
     File.write dest, iclas_txt
 
     # show the changes
-    _.system 'svn', 'diff', dest
+    _.system! 'svn', 'diff', dest
+
+    # commit changes
+    _.system! 'svn', 'commit', dest,
+      ['--non-interactive', '--no-auth-cache'],
+      ['--username', env.user.untaint, '--password', env.password.untaint]
+
   end
 end
 
@@ -77,6 +88,7 @@ _task "email #@email" do
 
   # echo email
   _message mail.to_s
-end
 
-{result: "stub for ICLA, filename: #{@filename}"}
+  # deliver mail
+  mail.deliver!
+end

-- 
To stop receiving notification emails like this one, please contact
"commits@whimsical.apache.org" <co...@whimsical.apache.org>.