You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by shoebamer <gi...@git.apache.org> on 2017/09/19 20:18:13 UTC
[GitHub] storm pull request #2332: STORM-2745 : Added ClosingPolicy
GitHub user shoebamer opened a pull request:
https://github.com/apache/storm/pull/2332
STORM-2745 : Added ClosingPolicy
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shoebamer/storm master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2332.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2332
----
commit 9b49c46fb4a57fe98cb695961739f7538e63c6ba
Author: Shoeb Mohammed <sh...@target.com>
Date: 2017-09-19T20:16:23Z
STORM-2745 : Added ClosingPolicy
----
---
[GitHub] storm issue #2332: STORM-2745 : Added ClosingPolicy
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2332
Some newly added files are not having license header. Please add them.
- external/storm-hdfs/src/test/java/org/apache/storm/hdfs/bolt/rotation/TickTupleBasedClosingPolicyTest.java
- external/storm-hdfs/src/main/java/org/apache/storm/hdfs/bolt/rotation/ClosingFilesPolicy.java
- external/storm-hdfs/src/main/java/org/apache/storm/hdfs/bolt/rotation/TickTupleBasedClosingPolicy.java
---
[GitHub] storm issue #2332: STORM-2745 : Added ClosingPolicy
Posted by shoebamer <gi...@git.apache.org>.
Github user shoebamer commented on the issue:
https://github.com/apache/storm/pull/2332
Ok I can change it back.
On Thu, Sep 21, 2017 at 10:39 AM, Jungtaek Lim <no...@github.com>
wrote:
> I'm not familiar of storm-hdfs so may not be able to review, but I can see
> there're some style issues which requires you to increase max allowed
> violations. I encouraged you to track the warning message from checkstyle
> and fix it.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/storm/pull/2332#issuecomment-331195829>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/APutewl7wzgRUkahnzvOnVoE1VkGG5bdks5skoMpgaJpZM4Pc9Ko>
> .
>
---
[GitHub] storm pull request #2332: STORM-2745 : Added ClosingPolicy
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2332#discussion_r140277357
--- Diff: external/storm-hdfs/pom.xml ---
@@ -256,7 +256,7 @@
<artifactId>maven-checkstyle-plugin</artifactId>
<!--Note - the version would be inherited-->
<configuration>
- <maxAllowedViolations>2223</maxAllowedViolations>
+ <maxAllowedViolations>2250</maxAllowedViolations>
--- End diff --
Please don't modify the number. Ideally the number should be always equal or decreased.
---
[GitHub] storm issue #2332: STORM-2745 : Added ClosingPolicy
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2332
I'm not familiar of storm-hdfs so may not be able to review, but I can see there're some style issues which requires you to increase max allowed violations. I encouraged you to track the warning message from checkstyle and fix it.
---