[jira] [Commented] (HADOOP-8488) test-patch.sh gives +1 even if the native build fails.

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-8488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13291198#comment-13291198 ] 

Hadoop QA commented on HADOOP-8488:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12531282/HADOOP-8488.001.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 1 new or modified test files.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1093//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1093//console

This message is automatically generated.
                
> test-patch.sh gives +1 even if the native build fails.
> ------------------------------------------------------
>
>                 Key: HADOOP-8488
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8488
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Minor
>         Attachments: HADOOP-8488.001.patch
>
>
> It would be nice if Jenkins would compile with mvn compile -Pnative or a similar command line.
> Currently, we don't seem to build the native code at all when testing patches. Unfortunately, this allows patches that break the native parts of the build to go in without the usual testing.
> It's true that the Jenkins build would not catch all native code issues (it only compiles in one environment, and there may be #ifdefs). However, some testing is sure better than none. I believe with cmake the performance overhead of -Pnative should be very minimal.
> This would also allow us to run the junit tests which depend on native code, and the raw native unit tests in Jenkins.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira