You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/04/14 16:01:59 UTC

[GitHub] [beam] ibzib commented on a change in pull request #14534: BEAM-12166:Beam Sql - Combine Accumulator return Map fails with class…

ibzib commented on a change in pull request #14534:
URL: https://github.com/apache/beam/pull/14534#discussion_r613376077



##########
File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/utils/CalciteUtils.java
##########
@@ -280,7 +280,8 @@ private static RelDataType toRelDataType(
   /**
    * SQL-Java type mapping, with specified Beam rules: <br>
    * 1. redirect {@link AbstractInstant} to {@link Date} so Calcite can recognize it. <br>
-   * 2. For a list, the component type is needed to create a Sql array type.
+   * 2. For a list, the component type is needed to create a Sql array type. 3. For a Map, the

Review comment:
       Nit: add a line break before `3.`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org