You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/06/08 02:31:42 UTC
[GitHub] [fineract] percyashu opened a new pull request #1003: FINERACT-822 enable JodaPlusMinusLong error
percyashu opened a new pull request #1003:
URL: https://github.com/apache/fineract/pull/1003
FINERACT-822
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1003: FINERACT-822 enable JodaPlusMinusLong error
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1003:
URL: https://github.com/apache/fineract/pull/1003#issuecomment-643756837
Whoa! Nice. Another very real bug in Fineract caught by Error Prone!
https://errorprone.info/bugpattern/JodaPlusMinusLong
https://www.joda.org/joda-time/apidocs/org/joda/time/DateTime.html#plus-long-
FYI @ptuomola @awasum @thesmallstar @xurror
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on a change in pull request #1003: FINERACT-822 enable JodaPlusMinusLong error
Posted by GitBox <gi...@apache.org>.
vorburger commented on a change in pull request #1003:
URL: https://github.com/apache/fineract/pull/1003#discussion_r436460725
##########
File path: fineract-provider/src/main/java/org/apache/fineract/infrastructure/reportmailingjob/service/ReportMailingJobWritePlatformServiceImpl.java
##########
@@ -351,7 +352,7 @@ private DateTime createNextRecurringDateTime(final String recurrencePattern, fin
// the recurrence pattern/rule cannot be empty
if (StringUtils.isNotBlank(recurrencePattern) && startDateTime != null) {
- final LocalDate nextDayLocalDate = startDateTime.plus(1).toLocalDate();
+ final LocalDate nextDayLocalDate = startDateTime.plus(Duration.millis(1)).toLocalDate();
Review comment:
This looks suspicious/wrong.. if the variable is called next DAY, why add ONLY 1ms to Start?
@ptuomola wanna help to code review this change for correctness?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] percyashu commented on pull request #1003: FINERACT-822 enable JodaPlusMinusLong error
Posted by GitBox <gi...@apache.org>.
percyashu commented on pull request #1003:
URL: https://github.com/apache/fineract/pull/1003#issuecomment-643291558
@vorburger LGTY?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger merged pull request #1003: FINERACT-822 enable JodaPlusMinusLong error
Posted by GitBox <gi...@apache.org>.
vorburger merged pull request #1003:
URL: https://github.com/apache/fineract/pull/1003
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org