You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/04/29 21:34:16 UTC
[GitHub] [beam] Miuler opened a new pull request, #17512: [BEAM-14386] [Flink] Support for scala 2.12
Miuler opened a new pull request, #17512:
URL: https://github.com/apache/beam/pull/17512
feat(flink/BEAM-14386): Use flink for scala 2.12
Reviewed-by: @jbonofre
Refs: # (pull request) [[BEAM-14386](https://issues.apache.org/jira/browse/BEAM-14386)] (jira)
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [X] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [X] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [X] Update `CHANGES.md` with noteworthy changes.
- [X] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ibzib commented on pull request #17512: [BEAM-14386] [Flink] Support for scala 2.12
Posted by GitBox <gi...@apache.org>.
ibzib commented on PR #17512:
URL: https://github.com/apache/beam/pull/17512#issuecomment-1115506554
Can we add a note to CHANGES.md so users of the next Beam version can be aware of this change? https://github.com/apache/beam/blob/master/CHANGES.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #17512: [BEAM-14386] [Flink] Support for scala 2.12
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17512:
URL: https://github.com/apache/beam/pull/17512#issuecomment-1113766648
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #17512: [BEAM-14386] [Flink] Support for scala 2.12
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17512:
URL: https://github.com/apache/beam/pull/17512#issuecomment-1113766689
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #17512: [BEAM-14386] [Flink] Support for scala 2.12
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17512:
URL: https://github.com/apache/beam/pull/17512#issuecomment-1113766667
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Miuler commented on pull request #17512: [BEAM-14386] [Flink] Support for scala 2.12
Posted by GitBox <gi...@apache.org>.
Miuler commented on PR #17512:
URL: https://github.com/apache/beam/pull/17512#issuecomment-1116465897
The scala version 2.11 is deprecated in Flink and many more libraries for scala, the minimum version should by 2.12.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] y1chi merged pull request #17512: [BEAM-14386] [Flink] Support for scala 2.12
Posted by GitBox <gi...@apache.org>.
y1chi merged PR #17512:
URL: https://github.com/apache/beam/pull/17512
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] y1chi commented on a diff in pull request #17512: [BEAM-14386] [Flink] Support for scala 2.12
Posted by GitBox <gi...@apache.org>.
y1chi commented on code in PR #17512:
URL: https://github.com/apache/beam/pull/17512#discussion_r865135072
##########
CHANGES.md:
##########
@@ -81,6 +81,7 @@
## Deprecations
+* Support for flink scala 2.12, because most of the libraries support version 2.12 onwards. ([beam-14386](https://issues.apache.org/jira/browse/BEAM-14386))
Review Comment:
there was no change from your last commit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Miuler commented on pull request #17512: [BEAM-14386] [Flink] Support for scala 2.12
Posted by GitBox <gi...@apache.org>.
Miuler commented on PR #17512:
URL: https://github.com/apache/beam/pull/17512#issuecomment-1113763677
This is a update from PR #17331, I'm create the jira issue https://issues.apache.org/jira/browse/BEAM-14386
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Miuler commented on a diff in pull request #17512: [BEAM-14386] [Flink] Support for scala 2.12
Posted by GitBox <gi...@apache.org>.
Miuler commented on code in PR #17512:
URL: https://github.com/apache/beam/pull/17512#discussion_r865127727
##########
CHANGES.md:
##########
@@ -81,6 +81,7 @@
## Deprecations
+* Support for flink scala 2.12, because most of the libraries support version 2.12 onwards. ([beam-14386](https://issues.apache.org/jira/browse/BEAM-14386))
Review Comment:
I already moved it to the Breaking section
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Miuler commented on pull request #17512: [BEAM-14386] [Flink] Support for scala 2.12
Posted by GitBox <gi...@apache.org>.
Miuler commented on PR #17512:
URL: https://github.com/apache/beam/pull/17512#issuecomment-1113771664
@ibzib this is the PR from feature to master (https://github.com/apache/beam/pull/17331)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Miuler commented on pull request #17512: [BEAM-14386] [Flink] Support for scala 2.12
Posted by GitBox <gi...@apache.org>.
Miuler commented on PR #17512:
URL: https://github.com/apache/beam/pull/17512#issuecomment-1115691119
> Can we add a note to CHANGES.md so users of the next Beam version can be aware of this change? https://github.com/apache/beam/blob/master/CHANGES.md
Yes, I do appended in the CHANGES.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Miuler commented on pull request #17512: [BEAM-14386] [Flink] Support for scala 2.12
Posted by GitBox <gi...@apache.org>.
Miuler commented on PR #17512:
URL: https://github.com/apache/beam/pull/17512#issuecomment-1115693731
> > Can we add a note to CHANGES.md so users of the next Beam version can be aware of this change? https://github.com/apache/beam/blob/master/CHANGES.md
>
> @ibzib Yes, I do appended in the CHANGES.md 
mmm... should it be another message?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] y1chi commented on a diff in pull request #17512: [BEAM-14386] [Flink] Support for scala 2.12
Posted by GitBox <gi...@apache.org>.
y1chi commented on code in PR #17512:
URL: https://github.com/apache/beam/pull/17512#discussion_r864264842
##########
CHANGES.md:
##########
@@ -81,6 +81,7 @@
## Deprecations
+* Support for flink scala 2.12, because most of the libraries support version 2.12 onwards. ([beam-14386](https://issues.apache.org/jira/browse/BEAM-14386))
Review Comment:
Should this go to breaking changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #17512: [BEAM-14386] [Flink] Support for scala 2.12
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17512:
URL: https://github.com/apache/beam/pull/17512#issuecomment-1113764812
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #17512: [BEAM-14386] [Flink] Support for scala 2.12
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17512:
URL: https://github.com/apache/beam/pull/17512#issuecomment-1113766658
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org