You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "mrhhsg (via GitHub)" <gi...@apache.org> on 2023/03/10 16:51:09 UTC
[GitHub] [doris] mrhhsg opened a new pull request, #17684: improvement](predicate) Cache the dict code in ComparisonPredicate
mrhhsg opened a new pull request, #17684:
URL: https://github.com/apache/doris/pull/17684
# Proposed changes
revert #17674 and add one new implementation.
## Problem summary
Describe your changes.
## Checklist(Required)
* [ ] Does it affect the original behavior
* [ ] Has unit tests been added
* [ ] Has document been added or modified
* [ ] Does it need to update dependencies
* [ ] Is this PR support rollback (If NO, please explain WHY)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17684: improvement](predicate) Cache the dict code in ComparisonPredicate
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17684:
URL: https://github.com/apache/doris/pull/17684#issuecomment-1475104593
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17684: [improvement](predicate) Cache the dict code in ComparisonPredicate
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17684:
URL: https://github.com/apache/doris/pull/17684#issuecomment-1475106438
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei commented on pull request #17684: [improvement](predicate) Cache the dict code in ComparisonPredicate
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on PR #17684:
URL: https://github.com/apache/doris/pull/17684#issuecomment-1475106405
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei commented on a diff in pull request #17684: improvement](predicate) Cache the dict code in ComparisonPredicate
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on code in PR #17684:
URL: https://github.com/apache/doris/pull/17684#discussion_r1141238200
##########
be/src/olap/column_predicate.h:
##########
@@ -35,6 +35,7 @@ class Schema;
struct PredicateParams {
std::string value;
bool marked_by_runtime_filter = false;
+ uint32_t segment_id;
Review Comment:
useless
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17684: [improvement](predicate) Cache the dict code in ComparisonPredicate
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17684:
URL: https://github.com/apache/doris/pull/17684#issuecomment-1475106442
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17684: improvement](predicate) Cache the dict code in ComparisonPredicate
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17684:
URL: https://github.com/apache/doris/pull/17684#issuecomment-1464094832
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17684: improvement](predicate) Cache the dict code in ComparisonPredicate
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17684:
URL: https://github.com/apache/doris/pull/17684#issuecomment-1475104398
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei commented on a diff in pull request #17684: improvement](predicate) Cache the dict code in ComparisonPredicate
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on code in PR #17684:
URL: https://github.com/apache/doris/pull/17684#discussion_r1141238366
##########
be/src/vec/exec/join/vhash_join_node.cpp:
##########
@@ -598,6 +598,22 @@ Status HashJoinNode::get_next(RuntimeState* state, Block* output_block, bool* eo
*eos = true;
return Status::OK();
}
+
+ if (_join_op == TJoinOp::RIGHT_OUTER_JOIN) {
Review Comment:
Not in this pr. This code is already in master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei commented on pull request #17684: [improvement](predicate) Cache the dict code in ComparisonPredicate
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on PR #17684:
URL: https://github.com/apache/doris/pull/17684#issuecomment-1475175737
skip failed p0 because it is a know unstable test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] mrhhsg commented on pull request #17684: improvement](predicate) Cache the dict code in ComparisonPredicate
Posted by "mrhhsg (via GitHub)" <gi...@apache.org>.
mrhhsg commented on PR #17684:
URL: https://github.com/apache/doris/pull/17684#issuecomment-1464089059
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] cambyzju commented on pull request #17684: improvement](predicate) Cache the dict code in ComparisonPredicate
Posted by "cambyzju (via GitHub)" <gi...@apache.org>.
cambyzju commented on PR #17684:
URL: https://github.com/apache/doris/pull/17684#issuecomment-1465445696
please add some desc, why we need revert, and what's the difference of the new implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #17684: [improvement](predicate) Cache the dict code in ComparisonPredicate
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #17684:
URL: https://github.com/apache/doris/pull/17684#issuecomment-1475144624
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.84 seconds
stream load tsv: 466 seconds loaded 74807831229 Bytes, about 153 MB/s
stream load json: 24 seconds loaded 2358488459 Bytes, about 93 MB/s
stream load orc: 76 seconds loaded 1101869774 Bytes, about 13 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230319080516_clickbench_pr_116719.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17684: improvement](predicate) Cache the dict code in ComparisonPredicate
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17684:
URL: https://github.com/apache/doris/pull/17684#issuecomment-1464094392
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei commented on a diff in pull request #17684: improvement](predicate) Cache the dict code in ComparisonPredicate
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on code in PR #17684:
URL: https://github.com/apache/doris/pull/17684#discussion_r1141239080
##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -1186,6 +1187,13 @@ void SegmentIterator::_vec_init_lazy_materialization() {
_is_pred_column[cid] = true;
pred_column_ids.insert(cid);
+ if (predicate->need_to_clone()) {
Review Comment:
Not modify here, modify it in
Status SegmentIterator::init(const StorageReadOptions& opts) {
_opts = opts;
if (!opts.column_predicates.empty()) {
_col_predicates = opts.column_predicates;
}
during init process, I think we could clone predicates and replace it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #17684: [improvement](predicate) Cache the dict code in ComparisonPredicate
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #17684:
URL: https://github.com/apache/doris/pull/17684
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org