You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by pa...@apache.org on 2022/09/06 19:02:42 UTC

[arrow-nanoarrow] branch main updated: [C] Add layout for Map type (#41)

This is an automated email from the ASF dual-hosted git repository.

paleolimbot pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-nanoarrow.git


The following commit(s) were added to refs/heads/main by this push:
     new 7325d62  [C] Add layout for Map type (#41)
7325d62 is described below

commit 7325d629245c290bd96fb645a5d38e72bba2f8af
Author: David Li <li...@gmail.com>
AuthorDate: Tue Sep 6 15:02:38 2022 -0400

    [C] Add layout for Map type (#41)
---
 src/nanoarrow/schema_test.cc | 4 ++--
 src/nanoarrow/utils.c        | 1 +
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/nanoarrow/schema_test.cc b/src/nanoarrow/schema_test.cc
index 291c6fa..04a104b 100644
--- a/src/nanoarrow/schema_test.cc
+++ b/src/nanoarrow/schema_test.cc
@@ -1014,10 +1014,10 @@ TEST(SchemaViewTest, SchemaViewInitNestedMap) {
   ARROW_EXPECT_OK(ExportType(*map(int32(), int32()), &schema));
   EXPECT_EQ(ArrowSchemaViewInit(&schema_view, &schema, &error), NANOARROW_OK);
   EXPECT_EQ(schema_view.layout.buffer_type[0], NANOARROW_BUFFER_TYPE_VALIDITY);
-  EXPECT_EQ(schema_view.layout.buffer_type[1], NANOARROW_BUFFER_TYPE_NONE);
+  EXPECT_EQ(schema_view.layout.buffer_type[1], NANOARROW_BUFFER_TYPE_DATA_OFFSET);
   EXPECT_EQ(schema_view.layout.buffer_type[2], NANOARROW_BUFFER_TYPE_NONE);
   EXPECT_EQ(schema_view.layout.element_size_bits[0], 1);
-  EXPECT_EQ(schema_view.layout.element_size_bits[1], 0);
+  EXPECT_EQ(schema_view.layout.element_size_bits[1], 32);
   EXPECT_EQ(schema_view.layout.element_size_bits[2], 0);
   schema.release(&schema);
 }
diff --git a/src/nanoarrow/utils.c b/src/nanoarrow/utils.c
index f770bb8..a817853 100644
--- a/src/nanoarrow/utils.c
+++ b/src/nanoarrow/utils.c
@@ -68,6 +68,7 @@ void ArrowLayoutInit(struct ArrowLayout* layout, enum ArrowType storage_type) {
       break;
 
     case NANOARROW_TYPE_LIST:
+    case NANOARROW_TYPE_MAP:
       layout->buffer_type[1] = NANOARROW_BUFFER_TYPE_DATA_OFFSET;
       layout->element_size_bits[1] = 32;
       break;