You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by Colm O hEigeartaigh <co...@apache.org> on 2018/12/11 11:49:53 UTC
[VOTE] - Release Apache Kerby 2.0.0
This is a vote to release Apache Kerby 2.0.0.
Artifacts:
https://repository.apache.org/content/repositories/orgapachedirectory-1179/
Issues fixed:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310910&version=12342433
Git tag:
https://github.com/apache/directory-kerby/tree/kerby-all-2.0.0
+1 from me.
Colm.
--
Colm O hEigeartaigh
Talend Community Coder
http://coders.talend.com
Re: [VOTE] - Release Apache Kerby 2.0.0
Posted by Lucas Theisen <lu...@pastdev.com>.
+1
On Wed, Dec 12, 2018 at 10:15 AM Shawn McKinney <sm...@apache.org>
wrote:
>
> > On Dec 11, 2018, at 5:49 AM, Colm O hEigeartaigh <co...@apache.org>
> wrote:
> >
> > This is a vote to release Apache Kerby 2.0.0.
> >
>
> +1
>
> Downloaded kerby-all-2.0.0-source-release.zip, validated its signature,
> built on the OpenJDK Runtime Environment (build 1.8.0_191-b12) / CentOS
> Linux release 7.5.1804 -- passed all tests.
>
> As an aside, noticed your public key's not trusted... we could fix that
> for next time.
>
> — Shawn
>
Re: [VOTE] - Release Apache Kerby 2.0.0
Posted by Shawn McKinney <sm...@apache.org>.
> On Dec 11, 2018, at 5:49 AM, Colm O hEigeartaigh <co...@apache.org> wrote:
>
> This is a vote to release Apache Kerby 2.0.0.
>
+1
Downloaded kerby-all-2.0.0-source-release.zip, validated its signature, built on the OpenJDK Runtime Environment (build 1.8.0_191-b12) / CentOS Linux release 7.5.1804 -- passed all tests.
As an aside, noticed your public key's not trusted... we could fix that for next time.
— Shawn
[CANCELLED] - Re: [VOTE] - Release Apache Kerby 2.0.0
Posted by Colm O hEigeartaigh <co...@apache.org>.
The vote is cancelled until we address Stefan's concerns.
Colm.
On Mon, Dec 17, 2018 at 8:13 AM Li, Jiajia <ji...@intel.com> wrote:
> Hi Stefan,
>
> Thanks for the serious review.
>
> >The release includes binary artifacts of has-dist [1] which includes many
> third-party libraries, but the required license/notice files are missing in
> those dist packages.
>
> It's because N&L are not included in assembly.xml, I've fixed in the pull
> request[1]
>
> >The dist archives also include the jdk.tools-1.8.jar which I assume we
> are not allowed to distribute. It's a system dependency from
> hadoop-common/hadoop-annotatations lib, not sure if Hadoop includes it?
>
> I've checked Hadoop does not include jdk.tool in distribution, I've
> excluded it in [1]
>
> >PS: Dist packages of kdc-dist and tool-dist were not generated because
> their pom.xml use a Maven profile "-Pdist" which probably was not enabled
> during release build, but has-dist pom.xml does not inlude such a profile
> so artifacts were built and deployed.
>
> I've added the "dist" Maven profile in has-dist pom.xml in [1]
>
> Could you have a look at the pull request?
>
> [1] https://github.com/apache/directory-kerby/pull/43
>
> Thanks,
> Jiajia
>
> -----Original Message-----
> From: Stefan Seelmann [mailto:mail@stefan-seelmann.de]
> Sent: Sunday, December 16, 2018 5:08 AM
> To: Apache Directory Developers List <de...@directory.apache.org>;
> kerby@directory.apache.org
> Subject: Re: [VOTE] - Release Apache Kerby 2.0.0
>
> I'm afraid I have to give a -1.
>
> The release includes binary artifacts of has-dist [1] which includes many
> third-party libraries, but the required license/notice files are missing in
> those dist packages.
>
> The dist archives also include the jdk.tools-1.8.jar which I assume we are
> not allowed to distribute. It's a system dependency from
> hadoop-common/hadoop-annotatations lib, not sure if Hadoop includes it?
>
> PS: Dist packages of kdc-dist and tool-dist were not generated because
> their pom.xml use a Maven profile "-Pdist" which probably was not enabled
> during release build, but has-dist pom.xml does not inlude such a profile
> so artifacts were built and deployed.
>
> [1]
>
> https://repository.apache.org/content/repositories/orgapachedirectory-1179/org/apache/kerby/has-dist/2.0.0/
>
>
>
> On 12/11/18 12:49 PM, Colm O hEigeartaigh wrote:
> > This is a vote to release Apache Kerby 2.0.0.
> >
> > Artifacts:
> >
> > https://repository.apache.org/content/repositories/orgapachedirectory-
> > 1179/
> >
> > Issues fixed:
> >
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310
> > 910&version=12342433
> >
> > Git tag:
> >
> > https://github.com/apache/directory-kerby/tree/kerby-all-2.0.0
> >
> > +1 from me.
> >
> > Colm.
> >
> >
>
>
--
Colm O hEigeartaigh
Talend Community Coder
http://coders.talend.com
Re: [VOTE] - Release Apache Kerby 2.0.0
Posted by Stefan Seelmann <ma...@stefan-seelmann.de>.
On 12/17/18 9:05 AM, Li, Jiajia wrote:
> Thanks for the serious review.
>
>> The release includes binary artifacts of has-dist [1] which includes many third-party libraries, but the required license/notice files are missing in those dist packages.
>
> It's because N&L are not included in assembly.xml, I've fixed in the pull request[1]
>
>> The dist archives also include the jdk.tools-1.8.jar which I assume we are not allowed to distribute. It's a system dependency from hadoop-common/hadoop-annotatations lib, not sure if Hadoop includes it?
>
> I've checked Hadoop does not include jdk.tool in distribution, I've excluded it in [1]
>
>> PS: Dist packages of kdc-dist and tool-dist were not generated because their pom.xml use a Maven profile "-Pdist" which probably was not enabled during release build, but has-dist pom.xml does not inlude such a profile so artifacts were built and deployed.
>
> I've added the "dist" Maven profile in has-dist pom.xml in [1]
>
> Could you have a look at the pull request?
Looks good to me.
Please feel free to include the binary dist packages in the release if
they are useful for users. Other projects also include such. We just
need to be more careful with the legal requirements.
Kind Regards,
Stefan
Re: [VOTE] - Release Apache Kerby 2.0.0
Posted by Stefan Seelmann <ma...@stefan-seelmann.de>.
On 12/17/18 9:05 AM, Li, Jiajia wrote:
> Thanks for the serious review.
>
>> The release includes binary artifacts of has-dist [1] which includes many third-party libraries, but the required license/notice files are missing in those dist packages.
>
> It's because N&L are not included in assembly.xml, I've fixed in the pull request[1]
>
>> The dist archives also include the jdk.tools-1.8.jar which I assume we are not allowed to distribute. It's a system dependency from hadoop-common/hadoop-annotatations lib, not sure if Hadoop includes it?
>
> I've checked Hadoop does not include jdk.tool in distribution, I've excluded it in [1]
>
>> PS: Dist packages of kdc-dist and tool-dist were not generated because their pom.xml use a Maven profile "-Pdist" which probably was not enabled during release build, but has-dist pom.xml does not inlude such a profile so artifacts were built and deployed.
>
> I've added the "dist" Maven profile in has-dist pom.xml in [1]
>
> Could you have a look at the pull request?
Looks good to me.
Please feel free to include the binary dist packages in the release if
they are useful for users. Other projects also include such. We just
need to be more careful with the legal requirements.
Kind Regards,
Stefan
RE: [VOTE] - Release Apache Kerby 2.0.0
Posted by "Li, Jiajia" <ji...@intel.com>.
Hi Stefan,
Thanks for the serious review.
>The release includes binary artifacts of has-dist [1] which includes many third-party libraries, but the required license/notice files are missing in those dist packages.
It's because N&L are not included in assembly.xml, I've fixed in the pull request[1]
>The dist archives also include the jdk.tools-1.8.jar which I assume we are not allowed to distribute. It's a system dependency from hadoop-common/hadoop-annotatations lib, not sure if Hadoop includes it?
I've checked Hadoop does not include jdk.tool in distribution, I've excluded it in [1]
>PS: Dist packages of kdc-dist and tool-dist were not generated because their pom.xml use a Maven profile "-Pdist" which probably was not enabled during release build, but has-dist pom.xml does not inlude such a profile so artifacts were built and deployed.
I've added the "dist" Maven profile in has-dist pom.xml in [1]
Could you have a look at the pull request?
[1] https://github.com/apache/directory-kerby/pull/43
Thanks,
Jiajia
-----Original Message-----
From: Stefan Seelmann [mailto:mail@stefan-seelmann.de]
Sent: Sunday, December 16, 2018 5:08 AM
To: Apache Directory Developers List <de...@directory.apache.org>; kerby@directory.apache.org
Subject: Re: [VOTE] - Release Apache Kerby 2.0.0
I'm afraid I have to give a -1.
The release includes binary artifacts of has-dist [1] which includes many third-party libraries, but the required license/notice files are missing in those dist packages.
The dist archives also include the jdk.tools-1.8.jar which I assume we are not allowed to distribute. It's a system dependency from hadoop-common/hadoop-annotatations lib, not sure if Hadoop includes it?
PS: Dist packages of kdc-dist and tool-dist were not generated because their pom.xml use a Maven profile "-Pdist" which probably was not enabled during release build, but has-dist pom.xml does not inlude such a profile so artifacts were built and deployed.
[1]
https://repository.apache.org/content/repositories/orgapachedirectory-1179/org/apache/kerby/has-dist/2.0.0/
On 12/11/18 12:49 PM, Colm O hEigeartaigh wrote:
> This is a vote to release Apache Kerby 2.0.0.
>
> Artifacts:
>
> https://repository.apache.org/content/repositories/orgapachedirectory-
> 1179/
>
> Issues fixed:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310
> 910&version=12342433
>
> Git tag:
>
> https://github.com/apache/directory-kerby/tree/kerby-all-2.0.0
>
> +1 from me.
>
> Colm.
>
>
RE: [VOTE] - Release Apache Kerby 2.0.0
Posted by "Li, Jiajia" <ji...@intel.com>.
Hi Stefan,
Thanks for the serious review.
>The release includes binary artifacts of has-dist [1] which includes many third-party libraries, but the required license/notice files are missing in those dist packages.
It's because N&L are not included in assembly.xml, I've fixed in the pull request[1]
>The dist archives also include the jdk.tools-1.8.jar which I assume we are not allowed to distribute. It's a system dependency from hadoop-common/hadoop-annotatations lib, not sure if Hadoop includes it?
I've checked Hadoop does not include jdk.tool in distribution, I've excluded it in [1]
>PS: Dist packages of kdc-dist and tool-dist were not generated because their pom.xml use a Maven profile "-Pdist" which probably was not enabled during release build, but has-dist pom.xml does not inlude such a profile so artifacts were built and deployed.
I've added the "dist" Maven profile in has-dist pom.xml in [1]
Could you have a look at the pull request?
[1] https://github.com/apache/directory-kerby/pull/43
Thanks,
Jiajia
-----Original Message-----
From: Stefan Seelmann [mailto:mail@stefan-seelmann.de]
Sent: Sunday, December 16, 2018 5:08 AM
To: Apache Directory Developers List <de...@directory.apache.org>; kerby@directory.apache.org
Subject: Re: [VOTE] - Release Apache Kerby 2.0.0
I'm afraid I have to give a -1.
The release includes binary artifacts of has-dist [1] which includes many third-party libraries, but the required license/notice files are missing in those dist packages.
The dist archives also include the jdk.tools-1.8.jar which I assume we are not allowed to distribute. It's a system dependency from hadoop-common/hadoop-annotatations lib, not sure if Hadoop includes it?
PS: Dist packages of kdc-dist and tool-dist were not generated because their pom.xml use a Maven profile "-Pdist" which probably was not enabled during release build, but has-dist pom.xml does not inlude such a profile so artifacts were built and deployed.
[1]
https://repository.apache.org/content/repositories/orgapachedirectory-1179/org/apache/kerby/has-dist/2.0.0/
On 12/11/18 12:49 PM, Colm O hEigeartaigh wrote:
> This is a vote to release Apache Kerby 2.0.0.
>
> Artifacts:
>
> https://repository.apache.org/content/repositories/orgapachedirectory-
> 1179/
>
> Issues fixed:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310
> 910&version=12342433
>
> Git tag:
>
> https://github.com/apache/directory-kerby/tree/kerby-all-2.0.0
>
> +1 from me.
>
> Colm.
>
>
Re: [VOTE] - Release Apache Kerby 2.0.0
Posted by Stefan Seelmann <ma...@stefan-seelmann.de>.
I'm afraid I have to give a -1.
The release includes binary artifacts of has-dist [1] which includes
many third-party libraries, but the required license/notice files are
missing in those dist packages.
The dist archives also include the jdk.tools-1.8.jar which I assume we
are not allowed to distribute. It's a system dependency from
hadoop-common/hadoop-annotatations lib, not sure if Hadoop includes it?
PS: Dist packages of kdc-dist and tool-dist were not generated because
their pom.xml use a Maven profile "-Pdist" which probably was not
enabled during release build, but has-dist pom.xml does not inlude such
a profile so artifacts were built and deployed.
[1]
https://repository.apache.org/content/repositories/orgapachedirectory-1179/org/apache/kerby/has-dist/2.0.0/
On 12/11/18 12:49 PM, Colm O hEigeartaigh wrote:
> This is a vote to release Apache Kerby 2.0.0.
>
> Artifacts:
>
> https://repository.apache.org/content/repositories/orgapachedirectory-1179/
>
> Issues fixed:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310910&version=12342433
>
> Git tag:
>
> https://github.com/apache/directory-kerby/tree/kerby-all-2.0.0
>
> +1 from me.
>
> Colm.
>
>
Re: [VOTE] - Release Apache Kerby 2.0.0
Posted by Shawn McKinney <sm...@apache.org>.
> On Dec 11, 2018, at 5:49 AM, Colm O hEigeartaigh <co...@apache.org> wrote:
>
> This is a vote to release Apache Kerby 2.0.0.
>
+1
Downloaded kerby-all-2.0.0-source-release.zip, validated its signature, built on the OpenJDK Runtime Environment (build 1.8.0_191-b12) / CentOS Linux release 7.5.1804 -- passed all tests.
As an aside, noticed your public key's not trusted... we could fix that for next time.
— Shawn
Re: [VOTE] - Release Apache Kerby 2.0.0
Posted by Stefan Seelmann <ma...@stefan-seelmann.de>.
I'm afraid I have to give a -1.
The release includes binary artifacts of has-dist [1] which includes
many third-party libraries, but the required license/notice files are
missing in those dist packages.
The dist archives also include the jdk.tools-1.8.jar which I assume we
are not allowed to distribute. It's a system dependency from
hadoop-common/hadoop-annotatations lib, not sure if Hadoop includes it?
PS: Dist packages of kdc-dist and tool-dist were not generated because
their pom.xml use a Maven profile "-Pdist" which probably was not
enabled during release build, but has-dist pom.xml does not inlude such
a profile so artifacts were built and deployed.
[1]
https://repository.apache.org/content/repositories/orgapachedirectory-1179/org/apache/kerby/has-dist/2.0.0/
On 12/11/18 12:49 PM, Colm O hEigeartaigh wrote:
> This is a vote to release Apache Kerby 2.0.0.
>
> Artifacts:
>
> https://repository.apache.org/content/repositories/orgapachedirectory-1179/
>
> Issues fixed:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310910&version=12342433
>
> Git tag:
>
> https://github.com/apache/directory-kerby/tree/kerby-all-2.0.0
>
> +1 from me.
>
> Colm.
>
>
RE: [VOTE] - Release Apache Kerby 2.0.0
Posted by "Li, Jiajia" <ji...@intel.com>.
+1
Built successfully with java version "1.8.0_112", all tests passed.
Regards,
Jiajia
-----Original Message-----
From: Colm O hEigeartaigh [mailto:coheigea@apache.org]
Sent: Tuesday, December 11, 2018 7:50 PM
To: Apache Directory Developers List <de...@directory.apache.org>
Cc: kerby@directory.apache.org
Subject: [VOTE] - Release Apache Kerby 2.0.0
This is a vote to release Apache Kerby 2.0.0.
Artifacts:
https://repository.apache.org/content/repositories/orgapachedirectory-1179/
Issues fixed:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310910&version=12342433
Git tag:
https://github.com/apache/directory-kerby/tree/kerby-all-2.0.0
+1 from me.
Colm.
--
Colm O hEigeartaigh
Talend Community Coder
http://coders.talend.com
RE: [VOTE] - Release Apache Kerby 2.0.0
Posted by "Li, Jiajia" <ji...@intel.com>.
+1
Built successfully with java version "1.8.0_112", all tests passed.
Regards,
Jiajia
-----Original Message-----
From: Colm O hEigeartaigh [mailto:coheigea@apache.org]
Sent: Tuesday, December 11, 2018 7:50 PM
To: Apache Directory Developers List <de...@directory.apache.org>
Cc: kerby@directory.apache.org
Subject: [VOTE] - Release Apache Kerby 2.0.0
This is a vote to release Apache Kerby 2.0.0.
Artifacts:
https://repository.apache.org/content/repositories/orgapachedirectory-1179/
Issues fixed:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310910&version=12342433
Git tag:
https://github.com/apache/directory-kerby/tree/kerby-all-2.0.0
+1 from me.
Colm.
--
Colm O hEigeartaigh
Talend Community Coder
http://coders.talend.com