[jira] [Commented] (NIFI-305) Refactor base class from MergeContent

["Joseph Gresock (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14301760#comment-14301760 ] 

Joseph Gresock commented on NIFI-305:
-------------------------------------

Thanks for the patch, Mark, it looks good to me.  Did you want to somehow have BinFiles provide a default ordering of the properties and relationships that can be overridden?  I like that the PropertyDescriptors and Relationships are still declared in BinFiles, but it might be nice for every implementing class not to have to write the boilerplate code that adds them.

> Refactor base class from MergeContent
> -------------------------------------
>
>                 Key: NIFI-305
>                 URL: https://issues.apache.org/jira/browse/NIFI-305
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Core Framework
>    Affects Versions: 0.0.1
>            Reporter: Joseph Gresock
>            Priority: Minor
>         Attachments: 0001-NIFI-305-Slight-refactorings-to-provide-more-flexibi.patch
>
>
> The binning logic in MergeContent is extremely useful, and could be pulled out into an abstract superclass.  This would allow other processors to perform binning logic without being tied to a merged flow file.  For example, a processor may want to submit a batch request to a database like Solr, or to a REST endpoint.  
> The vast majority of the code in MergeContent would remain in the concrete class, but there are several points, such as the BinManager usage, that could be abstracted for easy extensibility.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)