You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/01/21 03:27:17 UTC

[GitHub] [shardingsphere] jingshanglu opened a new pull request #9112: add support alter sharding rule

jingshanglu opened a new pull request #9112:
URL: https://github.com/apache/shardingsphere/pull/9112


   Fixes #9046 .
   
   Changes proposed in this pull request:
   - fix create sharding rule grammar
   - add alter sharding rule grammar
   - add support for alter sharding rule
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero merged pull request #9112: add support alter sharding rule

Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #9112:
URL: https://github.com/apache/shardingsphere/pull/9112


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on a change in pull request #9112: add support alter sharding rule

Posted by GitBox <gi...@apache.org>.
tristaZero commented on a change in pull request #9112:
URL: https://github.com/apache/shardingsphere/pull/9112#discussion_r563675716



##########
File path: shardingsphere-distsql-parser/shardingsphere-distsql-parser-engine/src/main/java/org/apache/shardingsphere/distsql/parser/core/DistSQLVisitor.java
##########
@@ -103,13 +109,61 @@ public ASTNode visitDataSourceDefinition(final DataSourceDefinitionContext ctx)
     
     @Override
     public ASTNode visitCreateShardingRule(final CreateShardingRuleContext ctx) {
-        Collection<TableRuleSegment> tables = new LinkedList<>();
+        CreateShardingRuleStatement result;
+        if (null != ctx.defaultTableStrategy()) {
+            String defaultTableStrategyColumn = null != ctx.defaultTableStrategy().columnName() ? ctx.defaultTableStrategy().columnName().getText() : null;
+            result = new CreateShardingRuleStatement(defaultTableStrategyColumn, (FunctionSegment) visit(ctx.defaultTableStrategy()));
+        } else {
+            result = new CreateShardingRuleStatement(null, null);
+        }
         for (ShardingTableRuleDefinitionContext each : ctx.shardingTableRuleDefinition()) {
-            tables.add((TableRuleSegment) visit(each));
+            result.getTables().add((TableRuleSegment) visit(each));
+        }
+        if (null != ctx.bindingTables()) {
+            for (TableNamesContext each : ctx.bindingTables().tableNames()) {
+                Collection<String> tables = each.IDENTIFIER().stream().map(t -> new IdentifierValue(t.getText()).getValue()).collect(Collectors.toList());
+                result.getBindingTables().add(Joiner.on(",").join(tables));
+            }
         }
-        return new CreateShardingRuleStatement(tables);
+        if (null != ctx.broadcastTables()) {
+            for (TerminalNode each : ctx.broadcastTables().IDENTIFIER()) {
+                result.getBroadcastTables().add(new IdentifierValue(each.getText()).getValue());
+            }
+        }
+        return result;
     }
-
+    
+    @Override
+    public ASTNode visitAlterShardingRule(final AlterShardingRuleContext ctx) {
+        AlterShardingRuleStatement result;
+        if (null != ctx.defaultTableStrategy()) {
+            String defaultTableStrategyColumn = null != ctx.defaultTableStrategy().columnName() ? ctx.defaultTableStrategy().columnName().getText() : null;
+    

Review comment:
       Please remove it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-io commented on pull request #9112: add support alter sharding rule

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9112:
URL: https://github.com/apache/shardingsphere/pull/9112#issuecomment-764222356


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9112?src=pr&el=h1) Report
   > Merging [#9112](https://codecov.io/gh/apache/shardingsphere/pull/9112?src=pr&el=desc) (c79af69) into [master](https://codecov.io/gh/apache/shardingsphere/commit/2523fa0680d6324da7921241b614d52c3a9ca25b?el=desc) (2523fa0) will **decrease** coverage by `0.41%`.
   > The diff coverage is `7.78%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/9112/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/9112?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #9112      +/-   ##
   ============================================
   - Coverage     69.80%   69.39%   -0.42%     
   + Complexity      660      657       -3     
   ============================================
     Files          1643     1649       +6     
     Lines         26600    26786     +186     
     Branches       4630     4670      +40     
   ============================================
   + Hits          18569    18588      +19     
   - Misses         6745     6908     +163     
   - Partials       1286     1290       +4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/9112?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...dingsphere/distsql/parser/core/DistSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/9112/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGlzdHNxbC1wYXJzZXIvc2hhcmRpbmdzcGhlcmUtZGlzdHNxbC1wYXJzZXItZW5naW5lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kaXN0c3FsL3BhcnNlci9jb3JlL0Rpc3RTUUxWaXNpdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...stsql/rdl/AlterReplicaQueryRuleBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/9112/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmRsL0FsdGVyUmVwbGljYVF1ZXJ5UnVsZUJhY2tlbmRIYW5kbGVyLmphdmE=) | `10.00% <ø> (ø)` | `1.00 <0.00> (?)` | |
   | [...t/distsql/rdl/AlterShardingRuleBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/9112/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmRsL0FsdGVyU2hhcmRpbmdSdWxlQmFja2VuZEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...end/text/distsql/rdl/RDLBackendHandlerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/9112/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmRsL1JETEJhY2tlbmRIYW5kbGVyRmFjdG9yeS5qYXZh) | `85.71% <0.00%> (-6.60%)` | `0.00 <0.00> (ø)` | |
   | [...re/proxy/frontend/mysql/MySQLErrPacketFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/9112/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Byb3h5L2Zyb250ZW5kL215c3FsL015U1FMRXJyUGFja2V0RmFjdG9yeS5qYXZh) | `62.96% <0.00%> (-5.04%)` | `0.00 <0.00> (ø)` | |
   | [...ding/converter/ShardingRuleStatementConverter.java](https://codecov.io/gh/apache/shardingsphere/pull/9112/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9jb252ZXJ0ZXIvU2hhcmRpbmdSdWxlU3RhdGVtZW50Q29udmVydGVyLmphdmE=) | `66.66% <58.82%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rdingsphere/db/protocol/error/CommonErrorCode.java](https://codecov.io/gh/apache/shardingsphere/pull/9112/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGIvcHJvdG9jb2wvZXJyb3IvQ29tbW9uRXJyb3JDb2RlLmphdmE=) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...sql/rdl/impl/CreateShardingRuleBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/9112/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmRsL2ltcGwvQ3JlYXRlU2hhcmRpbmdSdWxlQmFja2VuZEhhbmRsZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
   | [...phere/governance/core/registry/RegistryCenter.java](https://codecov.io/gh/apache/shardingsphere/pull/9112/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29yZS9yZWdpc3RyeS9SZWdpc3RyeUNlbnRlci5qYXZh) | `44.44% <0.00%> (-2.23%)` | `0.00% <0.00%> (ø%)` | |
   | [...dingsphere/governance/core/lock/node/LockNode.java](https://codecov.io/gh/apache/shardingsphere/pull/9112/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29yZS9sb2NrL25vZGUvTG9ja05vZGUuamF2YQ==) | `100.00% <0.00%> (ø)` | `1.00% <0.00%> (ø%)` | |
   | ... and [13 more](https://codecov.io/gh/apache/shardingsphere/pull/9112/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9112?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9112?src=pr&el=footer). Last update [2523fa0...c79af69](https://codecov.io/gh/apache/shardingsphere/pull/9112?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-io commented on pull request #9112: add support alter sharding rule

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9112:
URL: https://github.com/apache/shardingsphere/pull/9112#issuecomment-764222356


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9112?src=pr&el=h1) Report
   > Merging [#9112](https://codecov.io/gh/apache/shardingsphere/pull/9112?src=pr&el=desc) (c79af69) into [master](https://codecov.io/gh/apache/shardingsphere/commit/2523fa0680d6324da7921241b614d52c3a9ca25b?el=desc) (2523fa0) will **decrease** coverage by `0.41%`.
   > The diff coverage is `7.78%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/9112/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/9112?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #9112      +/-   ##
   ============================================
   - Coverage     69.80%   69.39%   -0.42%     
   + Complexity      660      657       -3     
   ============================================
     Files          1643     1649       +6     
     Lines         26600    26786     +186     
     Branches       4630     4670      +40     
   ============================================
   + Hits          18569    18588      +19     
   - Misses         6745     6908     +163     
   - Partials       1286     1290       +4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/9112?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...dingsphere/distsql/parser/core/DistSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/9112/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGlzdHNxbC1wYXJzZXIvc2hhcmRpbmdzcGhlcmUtZGlzdHNxbC1wYXJzZXItZW5naW5lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kaXN0c3FsL3BhcnNlci9jb3JlL0Rpc3RTUUxWaXNpdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...stsql/rdl/AlterReplicaQueryRuleBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/9112/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmRsL0FsdGVyUmVwbGljYVF1ZXJ5UnVsZUJhY2tlbmRIYW5kbGVyLmphdmE=) | `10.00% <ø> (ø)` | `1.00 <0.00> (?)` | |
   | [...t/distsql/rdl/AlterShardingRuleBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/9112/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmRsL0FsdGVyU2hhcmRpbmdSdWxlQmFja2VuZEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...end/text/distsql/rdl/RDLBackendHandlerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/9112/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmRsL1JETEJhY2tlbmRIYW5kbGVyRmFjdG9yeS5qYXZh) | `85.71% <0.00%> (-6.60%)` | `0.00 <0.00> (ø)` | |
   | [...re/proxy/frontend/mysql/MySQLErrPacketFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/9112/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Byb3h5L2Zyb250ZW5kL215c3FsL015U1FMRXJyUGFja2V0RmFjdG9yeS5qYXZh) | `62.96% <0.00%> (-5.04%)` | `0.00 <0.00> (ø)` | |
   | [...ding/converter/ShardingRuleStatementConverter.java](https://codecov.io/gh/apache/shardingsphere/pull/9112/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9jb252ZXJ0ZXIvU2hhcmRpbmdSdWxlU3RhdGVtZW50Q29udmVydGVyLmphdmE=) | `66.66% <58.82%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rdingsphere/db/protocol/error/CommonErrorCode.java](https://codecov.io/gh/apache/shardingsphere/pull/9112/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGIvcHJvdG9jb2wvZXJyb3IvQ29tbW9uRXJyb3JDb2RlLmphdmE=) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...sql/rdl/impl/CreateShardingRuleBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/9112/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmRsL2ltcGwvQ3JlYXRlU2hhcmRpbmdSdWxlQmFja2VuZEhhbmRsZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
   | [...phere/governance/core/registry/RegistryCenter.java](https://codecov.io/gh/apache/shardingsphere/pull/9112/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29yZS9yZWdpc3RyeS9SZWdpc3RyeUNlbnRlci5qYXZh) | `44.44% <0.00%> (-2.23%)` | `0.00% <0.00%> (ø%)` | |
   | [...dingsphere/governance/core/lock/node/LockNode.java](https://codecov.io/gh/apache/shardingsphere/pull/9112/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29yZS9sb2NrL25vZGUvTG9ja05vZGUuamF2YQ==) | `100.00% <0.00%> (ø)` | `1.00% <0.00%> (ø%)` | |
   | ... and [13 more](https://codecov.io/gh/apache/shardingsphere/pull/9112/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9112?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9112?src=pr&el=footer). Last update [2523fa0...c79af69](https://codecov.io/gh/apache/shardingsphere/pull/9112?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on a change in pull request #9112: add support alter sharding rule

Posted by GitBox <gi...@apache.org>.
tristaZero commented on a change in pull request #9112:
URL: https://github.com/apache/shardingsphere/pull/9112#discussion_r563675716



##########
File path: shardingsphere-distsql-parser/shardingsphere-distsql-parser-engine/src/main/java/org/apache/shardingsphere/distsql/parser/core/DistSQLVisitor.java
##########
@@ -103,13 +109,61 @@ public ASTNode visitDataSourceDefinition(final DataSourceDefinitionContext ctx)
     
     @Override
     public ASTNode visitCreateShardingRule(final CreateShardingRuleContext ctx) {
-        Collection<TableRuleSegment> tables = new LinkedList<>();
+        CreateShardingRuleStatement result;
+        if (null != ctx.defaultTableStrategy()) {
+            String defaultTableStrategyColumn = null != ctx.defaultTableStrategy().columnName() ? ctx.defaultTableStrategy().columnName().getText() : null;
+            result = new CreateShardingRuleStatement(defaultTableStrategyColumn, (FunctionSegment) visit(ctx.defaultTableStrategy()));
+        } else {
+            result = new CreateShardingRuleStatement(null, null);
+        }
         for (ShardingTableRuleDefinitionContext each : ctx.shardingTableRuleDefinition()) {
-            tables.add((TableRuleSegment) visit(each));
+            result.getTables().add((TableRuleSegment) visit(each));
+        }
+        if (null != ctx.bindingTables()) {
+            for (TableNamesContext each : ctx.bindingTables().tableNames()) {
+                Collection<String> tables = each.IDENTIFIER().stream().map(t -> new IdentifierValue(t.getText()).getValue()).collect(Collectors.toList());
+                result.getBindingTables().add(Joiner.on(",").join(tables));
+            }
         }
-        return new CreateShardingRuleStatement(tables);
+        if (null != ctx.broadcastTables()) {
+            for (TerminalNode each : ctx.broadcastTables().IDENTIFIER()) {
+                result.getBroadcastTables().add(new IdentifierValue(each.getText()).getValue());
+            }
+        }
+        return result;
     }
-
+    
+    @Override
+    public ASTNode visitAlterShardingRule(final AlterShardingRuleContext ctx) {
+        AlterShardingRuleStatement result;
+        if (null != ctx.defaultTableStrategy()) {
+            String defaultTableStrategyColumn = null != ctx.defaultTableStrategy().columnName() ? ctx.defaultTableStrategy().columnName().getText() : null;
+    

Review comment:
       Please remove it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero merged pull request #9112: add support alter sharding rule

Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #9112:
URL: https://github.com/apache/shardingsphere/pull/9112


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org