You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2023/02/17 21:00:06 UTC
[GitHub] [ozone] adoroszlai opened a new pull request, #4284: HDDS-7988. Run S3 tests with HA Proxy
adoroszlai opened a new pull request, #4284:
URL: https://github.com/apache/ozone/pull/4284
## What changes were proposed in this pull request?
HDDS-1972 added a docker-compose example for HA Proxy in front of multiple S3 Gateways. The example only runs basic, non-S3 tests. This change replaces it with S3 tests, to verify S3 Gateway works with such setup.
https://issues.apache.org/jira/browse/HDDS-7988
## How was this patch tested?
https://github.com/adoroszlai/hadoop-ozone/actions/runs/4205557222/jobs/7298351301#step:5:849
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kerneltime commented on a diff in pull request #4284: HDDS-7988. Run S3 tests with HA Proxy
Posted by "kerneltime (via GitHub)" <gi...@apache.org>.
kerneltime commented on code in PR #4284:
URL: https://github.com/apache/ozone/pull/4284#discussion_r1110821715
##########
hadoop-ozone/dist/src/main/compose/ozones3-haproxy/test.sh:
##########
@@ -18,12 +18,14 @@
COMPOSE_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"
export COMPOSE_DIR
+export SECURITY_ENABLED=false
Review Comment:
https://issues.apache.org/jira/browse/HDDS-7990
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai merged pull request #4284: HDDS-7988. Run S3 tests with HA Proxy
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #4284:
URL: https://github.com/apache/ozone/pull/4284
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kerneltime commented on a diff in pull request #4284: HDDS-7988. Run S3 tests with HA Proxy
Posted by "kerneltime (via GitHub)" <gi...@apache.org>.
kerneltime commented on code in PR #4284:
URL: https://github.com/apache/ozone/pull/4284#discussion_r1110766822
##########
hadoop-ozone/dist/src/main/compose/ozones3-haproxy/test.sh:
##########
@@ -18,12 +18,14 @@
COMPOSE_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"
export COMPOSE_DIR
+export SECURITY_ENABLED=false
Review Comment:
We do run robot tests for S3 in a secure environment. We should file a jira or do the work to include HTTPS and secure S3 tests for sample HA Proxy and testing of HA Proxy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on a diff in pull request #4284: HDDS-7988. Run S3 tests with HA Proxy
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #4284:
URL: https://github.com/apache/ozone/pull/4284#discussion_r1110791383
##########
hadoop-ozone/dist/src/main/compose/ozones3-haproxy/test.sh:
##########
@@ -18,12 +18,14 @@
COMPOSE_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"
export COMPOSE_DIR
+export SECURITY_ENABLED=false
Review Comment:
Each environment is either secure or not (see `ozone` vs. `ozonesecure`). This one is not, which is not changed by this PR. The `SECURITY_ENABLED` variable is required for the S3 tests to decide whether to run the secure-specific commands. Please file a Jira if you would like to add the security-related containers and settings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kerneltime commented on a diff in pull request #4284: HDDS-7988. Run S3 tests with HA Proxy
Posted by "kerneltime (via GitHub)" <gi...@apache.org>.
kerneltime commented on code in PR #4284:
URL: https://github.com/apache/ozone/pull/4284#discussion_r1110815997
##########
hadoop-ozone/dist/src/main/compose/ozones3-haproxy/test.sh:
##########
@@ -18,12 +18,14 @@
COMPOSE_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"
export COMPOSE_DIR
+export SECURITY_ENABLED=false
Review Comment:
Yup, I saw that. The goal of this change is to test the HA Proxy setup with S3G, and most of the exciting bits are related to security. I will file a Jira...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org