You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@yetus.apache.org by "Allen Wittenauer (JIRA)" <ji...@apache.org> on 2016/03/30 16:31:25 UTC

[jira] [Commented] (YETUS-359) shellcheck needs UTF-8 protection

    [ https://issues.apache.org/jira/browse/YETUS-359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15218037#comment-15218037 ] 

Allen Wittenauer commented on YETUS-359:
----------------------------------------

Hadoop is generating the following:

{code}
Running shellcheck against all identifiable shell scripts
./dev-support/create-release.sh: ./dev-support/create-release.sh: hGetContents: invalid argument (invalid byte sequence)
{code}

This was caused by some dev using smart quotes in a comment.  Reading up on this message, it would appear that hGetContents tends to throw this error if the locale isn't UTF-8 and it is given a string it can't handle.  So we likely can make this issue go away if we detect the current locale settings are not UTF-8 and temporarily run shellcheck in one.

> shellcheck needs UTF-8 protection
> ---------------------------------
>
>                 Key: YETUS-359
>                 URL: https://issues.apache.org/jira/browse/YETUS-359
>             Project: Yetus
>          Issue Type: Bug
>          Components: Test Patch
>            Reporter: Allen Wittenauer
>
> We should make sure that shellcheck is running in a UTF-8 environment to avoid some Haskell issues when dealing with non-ASCII input.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)