You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martin Grigorov (JIRA)" <ji...@apache.org> on 2016/07/16 08:52:20 UTC

[jira] [Resolved] (WICKET-6203) Rename IModel#mapWith() to IModel#combineWith() and reorder the parameters

     [ https://issues.apache.org/jira/browse/WICKET-6203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Grigorov resolved WICKET-6203.
-------------------------------------
       Resolution: Fixed
         Assignee: Martin Grigorov
    Fix Version/s: 8.0.0-M2

> Rename IModel#mapWith() to IModel#combineWith() and reorder the parameters
> --------------------------------------------------------------------------
>
>                 Key: WICKET-6203
>                 URL: https://issues.apache.org/jira/browse/WICKET-6203
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 8.0.0-M1
>            Reporter: Matthias Metzger
>            Assignee: Martin Grigorov
>            Priority: Trivial
>              Labels: newbie
>             Fix For: 8.0.0-M2
>
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> The IModel#mapWith method actually combines two models using a BiFunction. Thus another name like 'combineWith' would be much more descriptive of the actual task. 
> Furthermore providing the BiFunction to combine the two models as the first argument of 'mapWith'/'combineWith' might obscure the other Model used for longer lambda expressions, since it will be provided after the lambda expression. It might be better to provide the other Model as a first argument.
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)