You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/07/01 07:09:09 UTC
[GitHub] [iotdb] ijihang opened a new pull request #3480: [IOTDB-1416] Maintanance command support in cluster mode
ijihang opened a new pull request #3480:
URL: https://github.com/apache/iotdb/pull/3480
such as CREATE SNAPSHOT FOR SCHEMA, CLEAR CACHE MERGE,Maintanance command support in cluster mode
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] neuyilan commented on a change in pull request #3480: [IOTDB-1416] Maintanance command support in cluster mode
Posted by GitBox <gi...@apache.org>.
neuyilan commented on a change in pull request #3480:
URL: https://github.com/apache/iotdb/pull/3480#discussion_r665152063
##########
File path: server/src/main/java/org/apache/iotdb/db/qp/physical/PhysicalPlan.java
##########
@@ -436,6 +448,9 @@ public static PhysicalPlan create(ByteBuffer buffer) throws IOException, Illegal
DROP_TRIGGER,
START_TRIGGER,
STOP_TRIGGER,
+ MERGE,
+ CREATE_SNAPSHOT,
+ CLEARCACHE,
CREATE_CONTINUOUS_QUERY,
DROP_CONTINUOUS_QUERY,
SHOW_CONTINUOUS_QUERIES
Review comment:
```
MERGE,
CREATE_SNAPSHOT,
CLEARCACHE,
```
Move above codes to the end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] wangchao316 merged pull request #3480: [IOTDB-1416] Maintanance command support in cluster mode
Posted by GitBox <gi...@apache.org>.
wangchao316 merged pull request #3480:
URL: https://github.com/apache/iotdb/pull/3480
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #3480: [IOTDB-1416] Maintanance command support in cluster mode
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3480:
URL: https://github.com/apache/iotdb/pull/3480#issuecomment-872019723
[](https://coveralls.io/builds/41034436)
Coverage increased (+0.02%) to 67.949% when pulling **74c34aa4e1539c5f26fc8607d08055959a656e3c on ijihang:maintananceCommand** into **b44915da9caf6473b0edb6b753c5d38feedab951 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] wangchao316 commented on a change in pull request #3480: [IOTDB-1416] Maintanance command support in cluster mode
Posted by GitBox <gi...@apache.org>.
wangchao316 commented on a change in pull request #3480:
URL: https://github.com/apache/iotdb/pull/3480#discussion_r667754879
##########
File path: server/src/main/java/org/apache/iotdb/db/qp/physical/sys/ClearCachePlan.java
##########
@@ -35,4 +39,17 @@ public ClearCachePlan() {
public List<PartialPath> getPaths() {
return Collections.emptyList();
}
+
+ @Override
+ public void serialize(DataOutputStream stream) throws IOException {
+ stream.writeByte((byte) PhysicalPlanType.CLEARCACHE.ordinal());
+ }
+
+ @Override
+ public void serialize(ByteBuffer buffer) {
+ buffer.put((byte) PhysicalPlanType.CLEARCACHE.ordinal());
+ }
+
+ @Override
+ public void deserialize(ByteBuffer buffer) throws IllegalPathException {}
Review comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #3480: [IOTDB-1416] Maintanance command support in cluster mode
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3480:
URL: https://github.com/apache/iotdb/pull/3480#issuecomment-872019723
[](https://coveralls.io/builds/41176849)
Coverage increased (+0.2%) to 68.099% when pulling **b62a05d8ebbe71b94f2f3c28943d9716bffda49a on ijihang:maintananceCommand** into **b44915da9caf6473b0edb6b753c5d38feedab951 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] ijihang commented on a change in pull request #3480: [IOTDB-1416] Maintanance command support in cluster mode
Posted by GitBox <gi...@apache.org>.
ijihang commented on a change in pull request #3480:
URL: https://github.com/apache/iotdb/pull/3480#discussion_r668399951
##########
File path: cluster/src/test/java/org/apache/iotdb/cluster/log/applier/DataLogApplierTest.java
##########
@@ -374,4 +376,20 @@ public void testApplyCreateMultiTimeseiresWithPulling() throws MetadataException
assertTrue(IoTDB.metaManager.getAllStorageGroupPaths().contains(new PartialPath("root.sg2")));
assertNull(log.getException());
}
+
Review comment:
thanks, i will add testcontainer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #3480: [IOTDB-1416] Maintanance command support in cluster mode
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3480:
URL: https://github.com/apache/iotdb/pull/3480#issuecomment-872019723
[](https://coveralls.io/builds/41315130)
Coverage decreased (-0.004%) to 68.17% when pulling **b48ef1fffbb7df89ff741cebdd73af9fdddb9b1c on ijihang:maintananceCommand** into **80aa392bb8b26749804103ccabfb793623196035 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #3480: [IOTDB-1416] Maintanance command support in cluster mode
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3480:
URL: https://github.com/apache/iotdb/pull/3480#issuecomment-872019723
[](https://coveralls.io/builds/41035255)
Coverage decreased (-0.01%) to 67.919% when pulling **74c34aa4e1539c5f26fc8607d08055959a656e3c on ijihang:maintananceCommand** into **b44915da9caf6473b0edb6b753c5d38feedab951 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls commented on pull request #3480: [IOTDB-1416] Maintanance command support in cluster mode
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #3480:
URL: https://github.com/apache/iotdb/pull/3480#issuecomment-872019723
[](https://coveralls.io/builds/41034403)
Coverage decreased (-0.003%) to 67.928% when pulling **74c34aa4e1539c5f26fc8607d08055959a656e3c on ijihang:maintananceCommand** into **b44915da9caf6473b0edb6b753c5d38feedab951 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] ijihang commented on a change in pull request #3480: [IOTDB-1416] Maintanance command support in cluster mode
Posted by GitBox <gi...@apache.org>.
ijihang commented on a change in pull request #3480:
URL: https://github.com/apache/iotdb/pull/3480#discussion_r666612040
##########
File path: server/src/main/java/org/apache/iotdb/db/qp/physical/sys/ClearCachePlan.java
##########
@@ -35,4 +39,17 @@ public ClearCachePlan() {
public List<PartialPath> getPaths() {
return Collections.emptyList();
}
+
+ @Override
+ public void serialize(DataOutputStream stream) throws IOException {
+ stream.writeByte((byte) PhysicalPlanType.CLEARCACHE.ordinal());
+ }
+
+ @Override
+ public void serialize(ByteBuffer buffer) {
+ buffer.put((byte) PhysicalPlanType.CLEARCACHE.ordinal());
+ }
+
+ @Override
+ public void deserialize(ByteBuffer buffer) throws IllegalPathException {}
Review comment:
There are no fields to deserialize
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #3480: [IOTDB-1416] Maintanance command support in cluster mode
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3480:
URL: https://github.com/apache/iotdb/pull/3480#issuecomment-872019723
[](https://coveralls.io/builds/41317979)
Coverage decreased (-0.02%) to 68.156% when pulling **92a2d7eef578b23e18d665f4ee21ce6563dc4922 on ijihang:maintananceCommand** into **80aa392bb8b26749804103ccabfb793623196035 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] wangchao316 commented on a change in pull request #3480: [IOTDB-1416] Maintanance command support in cluster mode
Posted by GitBox <gi...@apache.org>.
wangchao316 commented on a change in pull request #3480:
URL: https://github.com/apache/iotdb/pull/3480#discussion_r665905068
##########
File path: server/src/main/java/org/apache/iotdb/db/qp/physical/sys/MergePlan.java
##########
@@ -39,4 +43,17 @@ public MergePlan() {
public List<PartialPath> getPaths() {
return Collections.emptyList();
}
+
+ @Override
+ public void serialize(DataOutputStream stream) throws IOException {
+ stream.writeByte((byte) PhysicalPlanType.MERGE.ordinal());
+ }
+
+ @Override
+ public void serialize(ByteBuffer buffer) {
+ buffer.put((byte) PhysicalPlanType.MERGE.ordinal());
+ }
+
+ @Override
+ public void deserialize(ByteBuffer buffer) throws IllegalPathException {}
Review comment:
why deserialize do not implementation？ How to deserialize this execution plan?
##########
File path: cluster/src/test/java/org/apache/iotdb/cluster/log/applier/DataLogApplierTest.java
##########
@@ -374,4 +376,20 @@ public void testApplyCreateMultiTimeseiresWithPulling() throws MetadataException
assertTrue(IoTDB.metaManager.getAllStorageGroupPaths().contains(new PartialPath("root.sg2")));
assertNull(log.getException());
}
+
Review comment:
Good Job.
Generally, the testcontainer needs to be added to implement the functions of the cluster edition.
##########
File path: server/src/main/java/org/apache/iotdb/db/qp/physical/sys/ClearCachePlan.java
##########
@@ -35,4 +39,17 @@ public ClearCachePlan() {
public List<PartialPath> getPaths() {
return Collections.emptyList();
}
+
+ @Override
+ public void serialize(DataOutputStream stream) throws IOException {
+ stream.writeByte((byte) PhysicalPlanType.CLEARCACHE.ordinal());
+ }
+
+ @Override
+ public void serialize(ByteBuffer buffer) {
+ buffer.put((byte) PhysicalPlanType.CLEARCACHE.ordinal());
+ }
+
+ @Override
+ public void deserialize(ByteBuffer buffer) throws IllegalPathException {}
Review comment:
why deserialize do not implementation？ How to deserialize this execution plan?
##########
File path: server/src/main/java/org/apache/iotdb/db/qp/physical/sys/CreateSnapshotPlan.java
##########
@@ -36,4 +40,17 @@ public CreateSnapshotPlan() {
public List<PartialPath> getPaths() {
return Collections.emptyList();
}
+
+ @Override
+ public void serialize(DataOutputStream stream) throws IOException {
+ stream.writeByte((byte) PhysicalPlanType.CREATE_SNAPSHOT.ordinal());
+ }
+
+ @Override
+ public void serialize(ByteBuffer buffer) {
+ buffer.put((byte) PhysicalPlanType.CREATE_SNAPSHOT.ordinal());
+ }
+
+ @Override
+ public void deserialize(ByteBuffer buffer) throws IllegalPathException {}
Review comment:
why deserialize do not implementation？ How to deserialize this execution plan?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org