You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2023/01/04 21:27:11 UTC
[GitHub] [ozone] sodonnel commented on a diff in pull request #4014: HDDS-7560. Placement Policy Interface changes to handle Overreplication
sodonnel commented on code in PR #4014:
URL: https://github.com/apache/ozone/pull/4014#discussion_r1061896005
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/SCMCommonPlacementPolicy.java:
##########
@@ -503,4 +508,72 @@ public Set<ContainerReplica> replicasToCopyToFixMisreplication(
protected Node getPlacementGroup(DatanodeDetails dn) {
return nodeManager.getClusterNetworkTopologyMap().getAncestor(dn, 1);
}
+
+ @Override
+ public Set<ContainerReplica> replicasToRemoveToFixOverreplication(
Review Comment:
There are no comments or description about what algorithm is being used to remove the replicas and how it also ensure the placement policy is not violated etc. Can you please describe the algorithm used here, perhaps in a javadoc comment above the method and add some comments indicating what is going on in the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org