You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by "dexter-cuijian (via GitHub)" <gi...@apache.org> on 2025/06/04 11:09:03 UTC
[PR] fix: When showMinLabel&showMaxLabel are set to true, the second item will be hidden(#20997) [echarts]
dexter-cuijian opened a new pull request, #21013:
URL: https://github.com/apache/echarts/pull/21013
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [x] bug fixing
- [ ] new feature
- [ ] others
### What does this PR do?
When showMinLabel&showMaxLabel are set to true, the second item will be hidden(
<!-- USE ONE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
### Fixed issues
- #20997
## Details
### Before: What was the problem?
<!-- DESCRIBE THE BUG OR REQUIREMENT HERE. -->
<!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
### After: How does it behave after the fixing?
<!-- THE RESULT AFTER FIXING AND A SIMPLE EXPLANATION ABOUT HOW IT IS FIXED. -->
<!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
## Document Info
One of the following should be checked.
- [x] This PR doesn't relate to document changes
- [ ] The document should be updated later
- [ ] The document changes have been made in apache/echarts-doc#xxx
## Misc
### ZRender Changes
- [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).
### Related test cases or examples to use the new APIs
N.A.
## Others
### Merging options
- [ ] Please squash the commits into a single one when merging.
### Other information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [PR] fix: When showMinLabel&showMaxLabel are set to true, the second item will be hidden(#20997) [echarts]
Posted by "Ovilia (via GitHub)" <gi...@apache.org>.
Ovilia commented on PR #21013:
URL: https://github.com/apache/echarts/pull/21013#issuecomment-2968834840
Why do I have different result (110% being hidden) when the container height is small before the change of this PR?
<img width="1011" alt="image" src="https://github.com/user-attachments/assets/4aeaa472-5e8a-4274-b1b2-d05dee0986d9" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [PR] fix: When showMinLabel&showMaxLabel are set to true, the second item will be hidden(#20997) [echarts]
Posted by "dexter-cuijian (via GitHub)" <gi...@apache.org>.
dexter-cuijian commented on PR #21013:
URL: https://github.com/apache/echarts/pull/21013#issuecomment-2969227158
I found that there is axisLabel.interval, which forces all labels to be displayed when this value is 0. But now it only takes effect for axis.type = 'category', I think it should take effect for all types
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [PR] fix: When showMinLabel&showMaxLabel are set to true, the second item will be hidden(#20997) [echarts]
Posted by "echarts-bot[bot] (via GitHub)" <gi...@apache.org>.
echarts-bot[bot] commented on PR #21013:
URL: https://github.com/apache/echarts/pull/21013#issuecomment-2939608853
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [PR] fix: When showMinLabel&showMaxLabel are set to true, the second item will be hidden(#20997) [echarts]
Posted by "zeyongTsai (via GitHub)" <gi...@apache.org>.
zeyongTsai commented on PR #21013:
URL: https://github.com/apache/echarts/pull/21013#issuecomment-3384537125
Is this PR ready to be merged? thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [PR] fix: When showMinLabel&showMaxLabel are set to true, the second item will be hidden(#20997) [echarts]
Posted by "dexter-cuijian (via GitHub)" <gi...@apache.org>.
dexter-cuijian commented on PR #21013:
URL: https://github.com/apache/echarts/pull/21013#issuecomment-2968849426
> Why do I have different result (110% being hidden) when the container height is small before the change of this PR? <img alt="image" width="1011" src="https://private-user-images.githubusercontent.com/779050/454666900-4aeaa472-5e8a-4274-b1b2-d05dee0986d9.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDk3ODQwMTYsIm5iZiI6MTc0OTc4MzcxNiwicGF0aCI6Ii83NzkwNTAvNDU0NjY2OTAwLTRhZWFhNDcyLTVlOGEtNDI3NC1iMWIyLWQwNWRlZTA5ODZkOS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwNjEzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDYxM1QwMzAxNTZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT05Mzc4YTViOGZkOGNkNWIwZGJkNWFhOTZkYjhlMTk2OTI0Mjc3NjcyMDYwZDUxMmUyZTRjMThiMjAyM2VkNDdhJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.HtfI4cYvS70To28KQDEATSASN-RS8dLxiKoiLy2jPUo">
[yAxis.axisLabel.showMinLabel
](https://echarts.apache.org/en/option.html#yAxis.axisLabel.showMinLabel)
It can be seen from the API that showMinLabel and showMaxLabel are defined under axisLabel
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [PR] fix: When showMinLabel&showMaxLabel are set to true, the second item will be hidden(#20997) [echarts]
Posted by "Ovilia (via GitHub)" <gi...@apache.org>.
Ovilia commented on PR #21013:
URL: https://github.com/apache/echarts/pull/21013#issuecomment-2969438432
I think the reason why it only supports category is that for value axis, it's meaningless to display labels with interval 0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org