You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/10/24 16:24:56 UTC

[GitHub] dubee closed pull request #181: remove unused auth variable

dubee closed pull request #181: remove unused auth variable
URL: https://github.com/apache/incubator-openwhisk-package-cloudant/pull/181
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/provider/lib/utils.js b/provider/lib/utils.js
index 3e3ab61..4f085308 100644
--- a/provider/lib/utils.js
+++ b/provider/lib/utils.js
@@ -191,11 +191,10 @@ module.exports = function(logger, triggerDB, redisClient) {
 
         logger.info(method, 'firing trigger', triggerData.id, 'with db update');
 
-        var host = 'https://' + self.routerHost + ':' + 443;
+        var host = 'https://' + self.routerHost;
         var uri = host + '/api/v1/namespaces/' + triggerObj.namespace + '/triggers/' + triggerObj.name;
-        var auth = triggerData.apikey.split(':');
 
-        postTrigger(triggerData, form, uri, auth, 0)
+        postTrigger(triggerData, form, uri, 0)
         .then(triggerId => {
             logger.info(method, 'Trigger', triggerId, 'was successfully fired');
             if (isMonitoringTrigger(triggerData.monitor, triggerId)) {
@@ -216,7 +215,7 @@ module.exports = function(logger, triggerDB, redisClient) {
         });
     }
 
-    function postTrigger(triggerData, form, uri, auth, retryCount) {
+    function postTrigger(triggerData, form, uri, retryCount) {
         var method = 'postTrigger';
 
         return new Promise(function(resolve, reject) {
@@ -250,7 +249,7 @@ module.exports = function(logger, triggerDB, redisClient) {
                                 var timeout = response && response.statusCode === 429 && retryCount === 0 ? 60000 : 1000 * Math.pow(retryCount + 1, 2);
                                 logger.info(method, 'attempting to fire trigger again', triggerData.id, 'Retry Count:', (retryCount + 1));
                                 setTimeout(function () {
-                                    postTrigger(triggerData, form, uri, auth, (retryCount + 1))
+                                    postTrigger(triggerData, form, uri, (retryCount + 1))
                                     .then(triggerId => {
                                         resolve(triggerId);
                                     })


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services