You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "zhuqi-lucas (via GitHub)" <gi...@apache.org> on 2024/12/22 03:39:58 UTC
[PR] Consolidate Example: dataframe_output.rs into dataframe.rs [datafusion]
zhuqi-lucas opened a new pull request, #13877:
URL: https://github.com/apache/datafusion/pull/13877
## Which issue does this PR close?
Closes [#13844)](https://github.com/apache/datafusion/issues/13844)
## Rationale for this change
Part of https://github.com/apache/datafusion/issues/11172
The large number of small examples in DataFusion leads to multiple problems:
Unnecessarily large amounts of temporary disk space (each example binary takes 100+ MB)
Larger cargo t time (each binary must be linked / created)
Makes it harder to find the relevant examples
Thus I think the fewer examples we have the
faster our dev experience will be
easier it will be to find the relevant examples
## What changes are included in this PR?
Consolidate the contents of https://github.com/apache/datafusion/blob/main/datafusion-examples/examples/dataframe_output.rs
Into https://github.com/apache/datafusion/blob/main/datafusion-examples/examples/dataframe.rs
Then update the readme page:
https://github.com/apache/datafusion/blob/main/datafusion-examples/README.md
## Are these changes tested?
Yes
## Are there any user-facing changes?
Readme changes for example about write out data to local storage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Consolidate Example: dataframe_output.rs into dataframe.rs [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #13877:
URL: https://github.com/apache/datafusion/pull/13877
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Consolidate Example: dataframe_output.rs into dataframe.rs [datafusion]
Posted by "zhuqi-lucas (via GitHub)" <gi...@apache.org>.
zhuqi-lucas commented on PR #13877:
URL: https://github.com/apache/datafusion/pull/13877#issuecomment-2558747940
Thank you @alamb for review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org