You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "Tracy Snell (JIRA)" <ji...@apache.org> on 2009/12/15 03:17:52 UTC
[jira] Created: (CAMEL-2291) Add support for channel keys to the
IRC component
Add support for channel keys to the IRC component
-------------------------------------------------
Key: CAMEL-2291
URL: https://issues.apache.org/activemq/browse/CAMEL-2291
Project: Apache Camel
Issue Type: Improvement
Affects Versions: 2.2.0
Reporter: Tracy Snell
Priority: Minor
Fix For: 2.2.0
The IRC component needs to support channels with keys.
I have it working and as soon as I figure out how to write a test for it I'll submit the patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-2291) Add support for channel keys to the
IRC component
Posted by "Tracy Snell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tracy Snell updated CAMEL-2291:
-------------------------------
Attachment: doc.txt
Here's some documentation. The first line should add fine in edit mode (but still needs formatting markup, wasn't sure which confluence tag you guys use).
ICLA on the way later today.
> Add support for channel keys to the IRC component
> -------------------------------------------------
>
> Key: CAMEL-2291
> URL: https://issues.apache.org/activemq/browse/CAMEL-2291
> Project: Apache Camel
> Issue Type: Improvement
> Affects Versions: 2.2.0
> Reporter: Tracy Snell
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 2.2.0
>
> Attachments: doc.txt, keypatch.txt
>
>
> The IRC component needs to support channels with keys.
> I have it working and as soon as I figure out how to write a test for it I'll submit the patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2291) Add support for channel keys to the
IRC component
Posted by "Tracy Snell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=56459#action_56459 ]
Tracy Snell commented on CAMEL-2291:
------------------------------------
Should be good to go. Assuming my code meets the standards if not just tell me what to fix and I will.
> Add support for channel keys to the IRC component
> -------------------------------------------------
>
> Key: CAMEL-2291
> URL: https://issues.apache.org/activemq/browse/CAMEL-2291
> Project: Apache Camel
> Issue Type: Improvement
> Affects Versions: 2.2.0
> Reporter: Tracy Snell
> Priority: Minor
> Fix For: 2.2.0
>
> Attachments: keypatch.txt
>
>
> The IRC component needs to support channels with keys.
> I have it working and as soon as I figure out how to write a test for it I'll submit the patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (CAMEL-2291) Add support for channel
keys to the IRC component
Posted by "Tracy Snell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=56459#action_56459 ]
Tracy Snell edited comment on CAMEL-2291 at 12/15/09 12:39 PM:
---------------------------------------------------------------
Should be good to go. Assuming my code meets the standards if not just tell me what to fix and I will.
If it's good to go I can update the wiki if someone gives me an account.
Check with Jeff Genender is you need a reference on me.
was (Author: tjsnell):
Should be good to go. Assuming my code meets the standards if not just tell me what to fix and I will.
> Add support for channel keys to the IRC component
> -------------------------------------------------
>
> Key: CAMEL-2291
> URL: https://issues.apache.org/activemq/browse/CAMEL-2291
> Project: Apache Camel
> Issue Type: Improvement
> Affects Versions: 2.2.0
> Reporter: Tracy Snell
> Priority: Minor
> Fix For: 2.2.0
>
> Attachments: keypatch.txt
>
>
> The IRC component needs to support channels with keys.
> I have it working and as soon as I figure out how to write a test for it I'll submit the patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2291) Add support for channel keys to the
IRC component
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=56463#action_56463 ]
Claus Ibsen commented on CAMEL-2291:
------------------------------------
trunk: 891143.
Applied patch with thanks. I did polish the code a bit.
Tracy do you mind working on the documentation as well?
> Add support for channel keys to the IRC component
> -------------------------------------------------
>
> Key: CAMEL-2291
> URL: https://issues.apache.org/activemq/browse/CAMEL-2291
> Project: Apache Camel
> Issue Type: Improvement
> Affects Versions: 2.2.0
> Reporter: Tracy Snell
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 2.2.0
>
> Attachments: keypatch.txt
>
>
> The IRC component needs to support channels with keys.
> I have it working and as soon as I figure out how to write a test for it I'll submit the patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Resolved: (CAMEL-2291) Add support for channel keys to the
IRC component
Posted by Claus Ibsen <cl...@gmail.com>.
There is an example later in the wiki page.
I dont think we should clutter the table with multiple examples. So I
prefer to write examples below.
There should be an example with some having a key and others doesnt
On Wed, Dec 16, 2009 at 4:34 PM, Tracy Snell <ts...@gmail.com> wrote:
> I'd add the second example that shows multiple channels with some not having a key just so it's clear.
>
> irc:nick@irc.server.org?channels=#chan1,#chan2,#chan3&keys=chan1Key,,chan3key
>
> As a side note there are 3 formats that work for the uri:
>
> The two at the top of the documentation:
> irc:nick@host[:port]/#room[?options]
> irc:nick@host[:port]?channels=#channel1,#channel2,#channel3[?options]
>
> And the one in the examples that omits the / on the first format:
> irc:MyUser@irc.server.org#channel
>
> They all three work fine. If the intention is to always support the third format I'll add a test for it in IrcConfigurationTest.
>
>
> On Dec 16, 2009, at 9:53 AM, Claus Ibsen (JIRA) wrote:
>
>>
>> [ https://issues.apache.org/activemq/browse/CAMEL-2291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>>
>> Claus Ibsen resolved CAMEL-2291.
>> --------------------------------
>>
>> Resolution: Fixed
>>
>> Thanks a lot Tracy
>>
>> I have updated the wiki page
>> http://cwiki.apache.org/confluence/display/CAMEL/IRC
>>
>> Does it look alright?
>>
>>> Add support for channel keys to the IRC component
>>> -------------------------------------------------
>>>
>>> Key: CAMEL-2291
>>> URL: https://issues.apache.org/activemq/browse/CAMEL-2291
>>> Project: Apache Camel
>>> Issue Type: Improvement
>>> Affects Versions: 2.2.0
>>> Reporter: Tracy Snell
>>> Assignee: Claus Ibsen
>>> Priority: Minor
>>> Fix For: 2.2.0
>>>
>>> Attachments: doc.txt, keypatch.txt
>>>
>>>
>>> The IRC component needs to support channels with keys.
>>> I have it working and as soon as I figure out how to write a test for it I'll submit the patch.
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> You can reply to this email to add a comment to the issue online.
>>
>
>
--
Claus Ibsen
Apache Camel Committer
Author of Camel in Action: http://www.manning.com/ibsen/
Open Source Integration: http://fusesource.com
Blog: http://davsclaus.blogspot.com/
Twitter: http://twitter.com/davsclaus
Re: [jira] Resolved: (CAMEL-2291) Add support for channel keys to the IRC component
Posted by Tracy Snell <ts...@gmail.com>.
I'd add the second example that shows multiple channels with some not having a key just so it's clear.
irc:nick@irc.server.org?channels=#chan1,#chan2,#chan3&keys=chan1Key,,chan3key
As a side note there are 3 formats that work for the uri:
The two at the top of the documentation:
irc:nick@host[:port]/#room[?options]
irc:nick@host[:port]?channels=#channel1,#channel2,#channel3[?options]
And the one in the examples that omits the / on the first format:
irc:MyUser@irc.server.org#channel
They all three work fine. If the intention is to always support the third format I'll add a test for it in IrcConfigurationTest.
On Dec 16, 2009, at 9:53 AM, Claus Ibsen (JIRA) wrote:
>
> [ https://issues.apache.org/activemq/browse/CAMEL-2291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Claus Ibsen resolved CAMEL-2291.
> --------------------------------
>
> Resolution: Fixed
>
> Thanks a lot Tracy
>
> I have updated the wiki page
> http://cwiki.apache.org/confluence/display/CAMEL/IRC
>
> Does it look alright?
>
>> Add support for channel keys to the IRC component
>> -------------------------------------------------
>>
>> Key: CAMEL-2291
>> URL: https://issues.apache.org/activemq/browse/CAMEL-2291
>> Project: Apache Camel
>> Issue Type: Improvement
>> Affects Versions: 2.2.0
>> Reporter: Tracy Snell
>> Assignee: Claus Ibsen
>> Priority: Minor
>> Fix For: 2.2.0
>>
>> Attachments: doc.txt, keypatch.txt
>>
>>
>> The IRC component needs to support channels with keys.
>> I have it working and as soon as I figure out how to write a test for it I'll submit the patch.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
[jira] Resolved: (CAMEL-2291) Add support for channel keys to the
IRC component
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen resolved CAMEL-2291.
--------------------------------
Resolution: Fixed
Thanks a lot Tracy
I have updated the wiki page
http://cwiki.apache.org/confluence/display/CAMEL/IRC
Does it look alright?
> Add support for channel keys to the IRC component
> -------------------------------------------------
>
> Key: CAMEL-2291
> URL: https://issues.apache.org/activemq/browse/CAMEL-2291
> Project: Apache Camel
> Issue Type: Improvement
> Affects Versions: 2.2.0
> Reporter: Tracy Snell
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 2.2.0
>
> Attachments: doc.txt, keypatch.txt
>
>
> The IRC component needs to support channels with keys.
> I have it working and as soon as I figure out how to write a test for it I'll submit the patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2291) Add support for channel keys to the
IRC component
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=56462#action_56462 ]
Claus Ibsen commented on CAMEL-2291:
------------------------------------
Tracy thanks for the patch.
To be able to edit wiki pages you need to sign a ICLA. See more here
http://camel.apache.org/how-do-i-edit-the-website.html
In the mean time you can e.g. write some documentation in a text file and attach to this JIRA with the "grant ASF license" ticket. Then we can use your documentation.
> Add support for channel keys to the IRC component
> -------------------------------------------------
>
> Key: CAMEL-2291
> URL: https://issues.apache.org/activemq/browse/CAMEL-2291
> Project: Apache Camel
> Issue Type: Improvement
> Affects Versions: 2.2.0
> Reporter: Tracy Snell
> Priority: Minor
> Fix For: 2.2.0
>
> Attachments: keypatch.txt
>
>
> The IRC component needs to support channels with keys.
> I have it working and as soon as I figure out how to write a test for it I'll submit the patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CAMEL-2291) Add support for channel keys to the
IRC component
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen reassigned CAMEL-2291:
----------------------------------
Assignee: Claus Ibsen
> Add support for channel keys to the IRC component
> -------------------------------------------------
>
> Key: CAMEL-2291
> URL: https://issues.apache.org/activemq/browse/CAMEL-2291
> Project: Apache Camel
> Issue Type: Improvement
> Affects Versions: 2.2.0
> Reporter: Tracy Snell
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 2.2.0
>
> Attachments: keypatch.txt
>
>
> The IRC component needs to support channels with keys.
> I have it working and as soon as I figure out how to write a test for it I'll submit the patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-2291) Add support for channel keys to the
IRC component
Posted by "Tracy Snell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tracy Snell updated CAMEL-2291:
-------------------------------
Attachment: keypatch.txt
Changes to IrcConsumer, IrcProducer and IrcConfiguration as well as some rudimentary tests. Let me know if this is enough.
> Add support for channel keys to the IRC component
> -------------------------------------------------
>
> Key: CAMEL-2291
> URL: https://issues.apache.org/activemq/browse/CAMEL-2291
> Project: Apache Camel
> Issue Type: Improvement
> Affects Versions: 2.2.0
> Reporter: Tracy Snell
> Priority: Minor
> Fix For: 2.2.0
>
> Attachments: keypatch.txt
>
>
> The IRC component needs to support channels with keys.
> I have it working and as soon as I figure out how to write a test for it I'll submit the patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.