You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/11/18 08:35:37 UTC
[GitHub] [pinot] siddharthteotia commented on a change in pull request #7724: Split thread cpu time into three metrics
siddharthteotia commented on a change in pull request #7724:
URL: https://github.com/apache/pinot/pull/7724#discussion_r752010167
##########
File path: pinot-common/src/main/java/org/apache/pinot/common/response/BrokerResponse.java
##########
@@ -143,17 +133,91 @@ String toJsonString()
List<QueryProcessingException> getProcessingExceptions();
/**
- * Get the total thread cpu time used against realtime table in request handling, into the broker response.
+ * Get the total number of rows in result set
*/
- long getRealtimeThreadCpuTimeNs();
+ int getNumRowsResultSet();
/**
- * Get the total thread cpu time used against offline table in request handling, into the broker response.
+ * Set the total thread cpu time used against offline table in request handling, into the broker response.
+ */
+ void setOfflineThreadCpuTimeNs(long offlineThreadCpuTimeNs);
+
+ /**
+ * Get the thread cpu time used against offline table in request handling, from the broker response.
*/
long getOfflineThreadCpuTimeNs();
/**
- * Get the total number of rows in result set
+ * Get the thread cpu time used against realtime table in request handling, from the broker response.
*/
- int getNumRowsResultSet();
+ long getRealtimeThreadCpuTimeNs();
+
+ /**
+ * Set the total thread cpu time used against realtime table in request handling, into the broker response.
+ */
+ void setRealtimeThreadCpuTimeNs(long realtimeThreadCpuTimeNs);
+
+ /**
+ * Get the system activities cpu time used against offline table in request handling, from the broker response.
+ */
+ long getOfflineSystemActivitiesCpuTimeNs();
+
+ /**
+ * Set the system activities cpu time used against offline table in request handling, into the broker response.
+ */
+ void setOfflineSystemActivitiesCpuTimeNs(long offlineSystemActivitiesCpuTimeNs);
+
+ /**
+ * Get the system activities cpu time used against realtime table in request handling, from the broker response.
+ */
+ long getRealtimeSystemActivitiesCpuTimeNs();
+
+ /**
+ * Set the system activities cpu time used against realtime table in request handling, into the broker response.
+ */
+ void setRealtimeSystemActivitiesCpuTimeNs(long realtimeSystemActivitiesCpuTimeNs);
+
+ /**
+ * Get the response serialization cpu time used against offline table in request handling, from the broker response.
+ */
+ long getOfflineResponseSerializationCpuTimeNs();
+
+ /**
+ * Set the response serialization cpu time used against offline table in request handling, into the broker response.
+ */
+ void setOfflineResponseSerializationCpuTimeNs(long offlineResponseSerializationCpuTimeNs);
+
+ /**
+ * Get the response serialization cpu time used against realtime table in request handling, from the broker response.
+ */
+ long getRealtimeResponseSerializationCpuTimeNs();
+
+ /**
+ * Set the response serialization cpu time used against realtime table in request handling, into the broker response.
+ */
+ void setRealtimeResponseSerializationCpuTimeNs(long realtimeResponseSerializationCpuTimeNs);
+
+ /**
+ * Get the total cpu time(thread cpu time + system activities cpu time + response serialization cpu time) used
+ * against offline table in request handling, from the broker response.
+ */
+ long getOfflineTotalCpuTimeNs();
+
+ /**
+ * Set the total cpu time(thread cpu time + system activities cpu time + response serialization cpu time) used
+ * against offline table in request handling, into the broker response.
+ */
+ void setOfflineTotalCpuTimeNs(long realtimeResponseSerializationCpuTimeNs);
Review comment:
Argument name is incorrect
##########
File path: pinot-common/src/main/java/org/apache/pinot/common/response/BrokerResponse.java
##########
@@ -143,17 +133,91 @@ String toJsonString()
List<QueryProcessingException> getProcessingExceptions();
/**
- * Get the total thread cpu time used against realtime table in request handling, into the broker response.
+ * Get the total number of rows in result set
*/
- long getRealtimeThreadCpuTimeNs();
+ int getNumRowsResultSet();
/**
- * Get the total thread cpu time used against offline table in request handling, into the broker response.
+ * Set the total thread cpu time used against offline table in request handling, into the broker response.
+ */
+ void setOfflineThreadCpuTimeNs(long offlineThreadCpuTimeNs);
+
+ /**
+ * Get the thread cpu time used against offline table in request handling, from the broker response.
*/
long getOfflineThreadCpuTimeNs();
/**
- * Get the total number of rows in result set
+ * Get the thread cpu time used against realtime table in request handling, from the broker response.
*/
- int getNumRowsResultSet();
+ long getRealtimeThreadCpuTimeNs();
+
+ /**
+ * Set the total thread cpu time used against realtime table in request handling, into the broker response.
+ */
+ void setRealtimeThreadCpuTimeNs(long realtimeThreadCpuTimeNs);
+
+ /**
+ * Get the system activities cpu time used against offline table in request handling, from the broker response.
+ */
+ long getOfflineSystemActivitiesCpuTimeNs();
+
+ /**
+ * Set the system activities cpu time used against offline table in request handling, into the broker response.
+ */
+ void setOfflineSystemActivitiesCpuTimeNs(long offlineSystemActivitiesCpuTimeNs);
+
+ /**
+ * Get the system activities cpu time used against realtime table in request handling, from the broker response.
+ */
+ long getRealtimeSystemActivitiesCpuTimeNs();
+
+ /**
+ * Set the system activities cpu time used against realtime table in request handling, into the broker response.
+ */
+ void setRealtimeSystemActivitiesCpuTimeNs(long realtimeSystemActivitiesCpuTimeNs);
+
+ /**
+ * Get the response serialization cpu time used against offline table in request handling, from the broker response.
+ */
+ long getOfflineResponseSerializationCpuTimeNs();
+
+ /**
+ * Set the response serialization cpu time used against offline table in request handling, into the broker response.
+ */
+ void setOfflineResponseSerializationCpuTimeNs(long offlineResponseSerializationCpuTimeNs);
+
+ /**
+ * Get the response serialization cpu time used against realtime table in request handling, from the broker response.
+ */
+ long getRealtimeResponseSerializationCpuTimeNs();
+
+ /**
+ * Set the response serialization cpu time used against realtime table in request handling, into the broker response.
+ */
+ void setRealtimeResponseSerializationCpuTimeNs(long realtimeResponseSerializationCpuTimeNs);
+
+ /**
+ * Get the total cpu time(thread cpu time + system activities cpu time + response serialization cpu time) used
+ * against offline table in request handling, from the broker response.
+ */
+ long getOfflineTotalCpuTimeNs();
+
+ /**
+ * Set the total cpu time(thread cpu time + system activities cpu time + response serialization cpu time) used
+ * against offline table in request handling, into the broker response.
+ */
+ void setOfflineTotalCpuTimeNs(long realtimeResponseSerializationCpuTimeNs);
+
+ /**
+ * Get the total cpu time(thread cpu time + system activities cpu time + response serialization cpu time) used
+ * against realtime table in request handling, from the broker response.
+ */
+ long getRealtimeTotalCpuTimeNs();
+
+ /**
+ * Set the total cpu time(thread cpu time + system activities cpu time + response serialization cpu time) used
+ * against realtime table in request handling, into the broker response.
+ */
+ void setRealtimeTotalCpuTimeNs(long realtimeResponseSerializationCpuTimeNs);
Review comment:
Same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org