[jira] [Commented] (TC-103) GET /update/:host_name should return boolean values

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TC-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15838159#comment-15838159 ] 

ASF GitHub Bot commented on TC-103:
-----------------------------------

GitHub user mitchell852 opened a pull request:

    https://github.com/apache/incubator-trafficcontrol/pull/231

    [TC-103] - casts 0|1 to bools in GET /update/:host_name route

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mitchell852/incubator-trafficcontrol tc-103

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafficcontrol/pull/231.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #231
    
----
commit 3bed680e6b08ba8ce57843a062d5f574bfab7f77
Author: Jeremy Mitchell <mi...@gmail.com>
Date:   2017-01-25T17:11:01Z

    casts 0|1 to bools (tc-103)

----


> GET /update/:host_name should return boolean values
> ---------------------------------------------------
>
>                 Key: TC-103
>                 URL: https://issues.apache.org/jira/browse/TC-103
>             Project: Traffic Control
>          Issue Type: Improvement
>          Components: Traffic Ops, Traffic Ops API, Traffic Ops ORT
>    Affects Versions: 2.0.0
>            Reporter: Jeremy Mitchell
>            Assignee: Jeremy Mitchell
>            Priority: Minor
>              Labels: postgres
>             Fix For: 2.0.0
>
>
> GET /update/:host_name returns
> [ { "upd_pending": 0, "parent_pending": "0", "status": "REPORTED",  "host_id": 22,  "host_name": "foo-bar" } ]
> it should return
> [ { "upd_pending": true|false, "parent_pending": true|false, "status": "REPORTED",  "host_id": 22,  "host_name": "foo-bar" } ]
> since TO ORT relies heavily on this endpoint, ensure that ORT can handle booleans as opposed to int/string 0|1



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)