You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/24 15:31:38 UTC

[GitHub] [arrow] js8544 commented on a diff in pull request #14486: ARROW-18144: [C++] Improve JSONTypeError error message in testing

js8544 commented on code in PR #14486:
URL: https://github.com/apache/arrow/pull/14486#discussion_r1003460820


##########
cpp/src/arrow/ipc/json_simple.cc:
##########
@@ -63,10 +63,11 @@ using ::arrow::internal::checked_pointer_cast;
 namespace {
 
 constexpr auto kParseFlags = rj::kParseFullPrecisionFlag | rj::kParseNanAndInfFlag;
-
+constexpr std::array<const char*, 7> kJsonTypeNames{"null",  "false",  "true",  "object",
+                                                    "array", "string", "number"};

Review Comment:
   Makes sense. Changed to a function.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org