You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Stu Hood (JIRA)" <ji...@apache.org> on 2010/07/26 21:19:15 UTC

[jira] Created: (CASSANDRA-1320) Convert AccessLevel to Set

Convert AccessLevel to Set<Permission>
--------------------------------------

                 Key: CASSANDRA-1320
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1320
             Project: Cassandra
          Issue Type: Improvement
            Reporter: Stu Hood
            Assignee: Stu Hood
             Fix For: 0.7 beta 1


Level based permissions are very limiting, and are likely to become restrictive. The original reasoning behind using levels seems to be that Thrift didn't allow an easy way to specify bitset permissions, but a Set<Enums> works equally well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-1320) Convert AccessLevel to Set

Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stu Hood updated CASSANDRA-1320:
--------------------------------

    Attachment:     (was: 0003-Use-Permission-checks-rather-than-AccessLevel-checks.patch)

> Convert AccessLevel to Set<Permission>
> --------------------------------------
>
>                 Key: CASSANDRA-1320
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1320
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Stu Hood
>            Assignee: Stu Hood
>
> Level based permissions are very limiting, and are likely to become restrictive. The original reasoning behind using levels seems to be that Thrift didn't allow an easy way to specify bitset permissions, but a Set<Enums> works equally well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-1320) Convert AccessLevel to Set

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-1320:
--------------------------------------

    Fix Version/s: 0.7.0
                       (was: 0.7 beta 1)

> Convert AccessLevel to Set<Permission>
> --------------------------------------
>
>                 Key: CASSANDRA-1320
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1320
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Stu Hood
>            Assignee: Stu Hood
>             Fix For: 0.7.0
>
>         Attachments: 0001-Avro-and-Thrift-interface-changes.patch, 0002-Convert-AccessLevel-to-Set-Permission.patch, 0003-Use-Permission-checks-rather-than-AccessLevel-checks.patch
>
>
> Level based permissions are very limiting, and are likely to become restrictive. The original reasoning behind using levels seems to be that Thrift didn't allow an easy way to specify bitset permissions, but a Set<Enums> works equally well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-1320) Convert AccessLevel to Set

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12908541#action_12908541 ] 

Hudson commented on CASSANDRA-1320:
-----------------------------------

Integrated in Cassandra #533 (See [https://hudson.apache.org/hudson/job/Cassandra/533/])
    

> Convert AccessLevel to Set<Permission>
> --------------------------------------
>
>                 Key: CASSANDRA-1320
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1320
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Stu Hood
>            Assignee: Stu Hood
>             Fix For: 0.7.0
>
>         Attachments: 0001-Remove-AccessLevel-from-the-client-API.patch, 0002-Convert-AccessLevel-to-Set-Permission.patch, 0003-Convert-to-Permission-usage-in-Thrift-Avro-servers.patch
>
>
> Level based permissions are very limiting, and are likely to become restrictive. The original reasoning behind using levels seems to be that Thrift didn't allow an easy way to specify bitset permissions, but a Set<Enums> works equally well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-1320) Convert AccessLevel to Set

Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stu Hood updated CASSANDRA-1320:
--------------------------------

    Attachment:     (was: 0003-Use-Permission-checks-rather-than-AccessLevel-checks.patch)

> Convert AccessLevel to Set<Permission>
> --------------------------------------
>
>                 Key: CASSANDRA-1320
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1320
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Stu Hood
>            Assignee: Stu Hood
>             Fix For: 0.7 beta 1
>
>
> Level based permissions are very limiting, and are likely to become restrictive. The original reasoning behind using levels seems to be that Thrift didn't allow an easy way to specify bitset permissions, but a Set<Enums> works equally well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (CASSANDRA-1320) Convert AccessLevel to Set

Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903574#action_12903574 ] 

Stu Hood edited comment on CASSANDRA-1320 at 8/28/10 2:34 AM:
--------------------------------------------------------------

Converts AccessLevel to EnumSet<Permission> (with semantics from CASSANDRA-1271), but does not add or remove any authorize() calls. 1271 will add the new resources, and probably add a few authorize calls.

      was (Author: stuhood):
    Converts AccessLevel to EnumSet<Permission> (with semantics from CASSANDRA-1320), but does not add or remove any authorize() calls. 1320 will add the new resources, and probably add a few authorize calls.
  
> Convert AccessLevel to Set<Permission>
> --------------------------------------
>
>                 Key: CASSANDRA-1320
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1320
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Stu Hood
>            Assignee: Stu Hood
>             Fix For: 0.7.0
>
>         Attachments: 0001-Remove-AccessLevel-from-the-client-API.patch, 0002-Convert-AccessLevel-to-Set-Permission.patch, 0003-Convert-to-Permission-usage-in-Thrift-Avro-servers.patch
>
>
> Level based permissions are very limiting, and are likely to become restrictive. The original reasoning behind using levels seems to be that Thrift didn't allow an easy way to specify bitset permissions, but a Set<Enums> works equally well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-1320) Convert AccessLevel to Set

Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stu Hood updated CASSANDRA-1320:
--------------------------------

    Attachment:     (was: 0001-Avro-and-Thrift-interface-changes.patch)

> Convert AccessLevel to Set<Permission>
> --------------------------------------
>
>                 Key: CASSANDRA-1320
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1320
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Stu Hood
>            Assignee: Stu Hood
>
> Level based permissions are very limiting, and are likely to become restrictive. The original reasoning behind using levels seems to be that Thrift didn't allow an easy way to specify bitset permissions, but a Set<Enums> works equally well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-1320) Convert AccessLevel to Set

Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stu Hood updated CASSANDRA-1320:
--------------------------------

    Attachment: 0001-Avro-and-Thrift-interface-changes.patch
                0002-Convert-AccessLevel-to-Set-Permission.patch
                0003-Use-Permission-checks-rather-than-AccessLevel-checks.patch

Rebased for changes in 1237

> Convert AccessLevel to Set<Permission>
> --------------------------------------
>
>                 Key: CASSANDRA-1320
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1320
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Stu Hood
>            Assignee: Stu Hood
>             Fix For: 0.7 beta 1
>
>         Attachments: 0001-Avro-and-Thrift-interface-changes.patch, 0002-Convert-AccessLevel-to-Set-Permission.patch, 0003-Use-Permission-checks-rather-than-AccessLevel-checks.patch
>
>
> Level based permissions are very limiting, and are likely to become restrictive. The original reasoning behind using levels seems to be that Thrift didn't allow an easy way to specify bitset permissions, but a Set<Enums> works equally well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-1320) Convert AccessLevel to Set

Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stu Hood updated CASSANDRA-1320:
--------------------------------

    Attachment:     (was: 0001-Avro-and-Thrift-interface-changes.patch)

> Convert AccessLevel to Set<Permission>
> --------------------------------------
>
>                 Key: CASSANDRA-1320
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1320
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Stu Hood
>            Assignee: Stu Hood
>             Fix For: 0.7 beta 1
>
>
> Level based permissions are very limiting, and are likely to become restrictive. The original reasoning behind using levels seems to be that Thrift didn't allow an easy way to specify bitset permissions, but a Set<Enums> works equally well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-1320) Convert AccessLevel to Set

Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stu Hood updated CASSANDRA-1320:
--------------------------------

    Attachment:     (was: 0002-Convert-AccessLevel-to-Set-Permission.patch)

> Convert AccessLevel to Set<Permission>
> --------------------------------------
>
>                 Key: CASSANDRA-1320
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1320
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Stu Hood
>            Assignee: Stu Hood
>             Fix For: 0.7 beta 1
>
>
> Level based permissions are very limiting, and are likely to become restrictive. The original reasoning behind using levels seems to be that Thrift didn't allow an easy way to specify bitset permissions, but a Set<Enums> works equally well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-1320) Convert AccessLevel to Set

Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stu Hood updated CASSANDRA-1320:
--------------------------------

    Attachment:     (was: 0002-Convert-AccessLevel-to-Set-Permission.patch)

> Convert AccessLevel to Set<Permission>
> --------------------------------------
>
>                 Key: CASSANDRA-1320
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1320
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Stu Hood
>            Assignee: Stu Hood
>
> Level based permissions are very limiting, and are likely to become restrictive. The original reasoning behind using levels seems to be that Thrift didn't allow an easy way to specify bitset permissions, but a Set<Enums> works equally well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-1320) Convert AccessLevel to Set

Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric Evans updated CASSANDRA-1320:
----------------------------------

    Reviewer: urandom

> Convert AccessLevel to Set<Permission>
> --------------------------------------
>
>                 Key: CASSANDRA-1320
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1320
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Stu Hood
>            Assignee: Stu Hood
>             Fix For: 0.7.0
>
>         Attachments: 0001-Remove-AccessLevel-from-the-client-API.patch, 0002-Convert-AccessLevel-to-Set-Permission.patch, 0003-Convert-to-Permission-usage-in-Thrift-Avro-servers.patch
>
>
> Level based permissions are very limiting, and are likely to become restrictive. The original reasoning behind using levels seems to be that Thrift didn't allow an easy way to specify bitset permissions, but a Set<Enums> works equally well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-1320) Convert AccessLevel to Set

Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stu Hood updated CASSANDRA-1320:
--------------------------------

    Attachment: 0001-Remove-AccessLevel-from-the-client-API.patch
                0002-Convert-AccessLevel-to-Set-Permission.patch
                0003-Convert-to-Permission-usage-in-Thrift-Avro-servers.patch

Converts AccessLevel to EnumSet<Permission> (with semantics from CASSANDRA-1320), but does not add or remove any authorize() calls. 1320 will add the new resources, and probably add a few authorize calls.

> Convert AccessLevel to Set<Permission>
> --------------------------------------
>
>                 Key: CASSANDRA-1320
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1320
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Stu Hood
>            Assignee: Stu Hood
>             Fix For: 0.7.0
>
>         Attachments: 0001-Remove-AccessLevel-from-the-client-API.patch, 0002-Convert-AccessLevel-to-Set-Permission.patch, 0003-Convert-to-Permission-usage-in-Thrift-Avro-servers.patch
>
>
> Level based permissions are very limiting, and are likely to become restrictive. The original reasoning behind using levels seems to be that Thrift didn't allow an easy way to specify bitset permissions, but a Set<Enums> works equally well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-1320) Convert AccessLevel to Set

Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stu Hood updated CASSANDRA-1320:
--------------------------------

    Attachment: 0001-Avro-and-Thrift-interface-changes.patch
                0002-Convert-AccessLevel-to-Set-Permission.patch
                0003-Use-Permission-checks-rather-than-AccessLevel-checks.patch

Applies on top of CASSANDRA-1237, and converts AccessLevel to Set<Permission>.

We'd like to get this change into 0.7-beta, since it changes the disk format for KSMetaData.

> Convert AccessLevel to Set<Permission>
> --------------------------------------
>
>                 Key: CASSANDRA-1320
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1320
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Stu Hood
>            Assignee: Stu Hood
>             Fix For: 0.7 beta 1
>
>         Attachments: 0001-Avro-and-Thrift-interface-changes.patch, 0002-Convert-AccessLevel-to-Set-Permission.patch, 0003-Use-Permission-checks-rather-than-AccessLevel-checks.patch
>
>
> Level based permissions are very limiting, and are likely to become restrictive. The original reasoning behind using levels seems to be that Thrift didn't allow an easy way to specify bitset permissions, but a Set<Enums> works equally well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.