You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by GitBox <gi...@apache.org> on 2020/03/10 16:18:22 UTC
[GitHub] [beam] TheNeuralBit opened a new pull request #11093: Exclude
signature files from expansion service test dependencies
TheNeuralBit opened a new pull request #11093: Exclude signature files from expansion service test dependencies
URL: https://github.com/apache/beam/pull/11093
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/)
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/)
XLang | --- | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/)
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] lukecwik commented on issue #11093: Exclude signature files
from expansion service test dependencies
Posted by GitBox <gi...@apache.org>.
lukecwik commented on issue #11093: Exclude signature files from expansion service test dependencies
URL: https://github.com/apache/beam/pull/11093#issuecomment-597199629
You
> > Note that this is a problem in SQL as well for the shadowJar and the testShadowJar:
>
> I was under the impression that SQL was ok because it uses `shadowJar` directly. But I'll admit I'm not well versed in how all this works. I'll look into whether we're pulling in signatures in the sql jars.
Even if you may not be pulling them in right now, you may start pulling them in the future with a dependency change.
Also, there are other flags that should be set like zip64. Take a look at the shadowJar and shadowTestJar tasks in BeamModulePlugin.groovy
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] Ardagan commented on issue #11093: [BEAM-9481] Exclude
signature files from expansion service test dependencies
Posted by GitBox <gi...@apache.org>.
Ardagan commented on issue #11093: [BEAM-9481] Exclude signature files from expansion service test dependencies
URL: https://github.com/apache/beam/pull/11093#issuecomment-597361408
I suggest to merge this PR now to mitigate issue and add further improvements later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] lukecwik commented on issue #11093: Exclude signature files
from expansion service test dependencies
Posted by GitBox <gi...@apache.org>.
lukecwik commented on issue #11093: Exclude signature files from expansion service test dependencies
URL: https://github.com/apache/beam/pull/11093#issuecomment-597184902
JIRA?
Note that this is a problem in SQL as well for the shadowJar and the testShadowJar:
https://github.com/apache/beam/blob/1988284a89b10b60eea48325f8a3b370b551c77c/sdks/java/extensions/sql/jdbc/build.gradle#L56
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] TheNeuralBit commented on issue #11093: Exclude signature
files from expansion service test dependencies
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on issue #11093: Exclude signature files from expansion service test dependencies
URL: https://github.com/apache/beam/pull/11093#issuecomment-597196534
> Note that this is a problem in SQL as well for the shadowJar and the testShadowJar:
I was under the impression that SQL was ok because it uses `shadowJar` directly. But I'll admit I'm not well versed in how all this works. I'll look into whether we're pulling in signatures in the sql jars.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] lukecwik commented on a change in pull request #11093:
Exclude signature files from expansion service test dependencies
Posted by GitBox <gi...@apache.org>.
lukecwik commented on a change in pull request #11093: Exclude signature files from expansion service test dependencies
URL: https://github.com/apache/beam/pull/11093#discussion_r390444979
##########
File path: sdks/java/testing/expansion-service/build.gradle
##########
@@ -49,7 +49,7 @@ task buildTestExpansionServiceJar(type: ShadowJar) {
)
}
exclude 'META-INF/*.RSA', 'META-INF/*.SF','META-INF/*.DSA'
Review comment:
```suggestion
exclude "META-INF/INDEX.LIST"
exclude "META-INF/*.SF"
exclude "META-INF/*.DSA"
exclude "META-INF/*.RSA"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] TheNeuralBit merged pull request #11093: [BEAM-9481] Exclude
signature files from expansion service test dependencies
Posted by GitBox <gi...@apache.org>.
TheNeuralBit merged pull request #11093: [BEAM-9481] Exclude signature files from expansion service test dependencies
URL: https://github.com/apache/beam/pull/11093
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] lukecwik commented on a change in pull request #11093:
Exclude signature files from expansion service test dependencies
Posted by GitBox <gi...@apache.org>.
lukecwik commented on a change in pull request #11093: Exclude signature files from expansion service test dependencies
URL: https://github.com/apache/beam/pull/11093#discussion_r390444686
##########
File path: sdks/java/testing/expansion-service/build.gradle
##########
@@ -49,7 +49,7 @@ task buildTestExpansionServiceJar(type: ShadowJar) {
)
}
exclude 'META-INF/*.RSA', 'META-INF/*.SF','META-INF/*.DSA'
- from { project.configurations.testRuntime.collect { it.isDirectory() ? it : zipTree(it) }}
+ from { project.configurations.testRuntime.collect { it.isDirectory() ? it : zipTree(it) }} { exclude 'META-INF/*.RSA', 'META-INF/*.SF', 'META-INF/*.DSA' }
Review comment:
```suggestion
configurations = [
project.configurations.testRuntime
]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] Ardagan edited a comment on issue #11093: Exclude signature
files from expansion service test dependencies
Posted by GitBox <gi...@apache.org>.
Ardagan edited a comment on issue #11093: Exclude signature files from expansion service test dependencies
URL: https://github.com/apache/beam/pull/11093#issuecomment-597209829
I created jira for this
https://issues.apache.org/jira/browse/BEAM-9481
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] Ardagan commented on issue #11093: Exclude signature files
from expansion service test dependencies
Posted by GitBox <gi...@apache.org>.
Ardagan commented on issue #11093: Exclude signature files from expansion service test dependencies
URL: https://github.com/apache/beam/pull/11093#issuecomment-597209829
I created jira for this
https://issues.apache.org/jira/browse/BEAM-8919
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] TheNeuralBit edited a comment on issue #11093: Exclude
signature files from expansion service test dependencies
Posted by GitBox <gi...@apache.org>.
TheNeuralBit edited a comment on issue #11093: Exclude signature files from expansion service test dependencies
URL: https://github.com/apache/beam/pull/11093#issuecomment-597196534
> Note that this is a problem in SQL as well for the shadowJar and the testShadowJar:
I was under the impression that SQL was ok because it uses `shadowJar` directly. But I'll admit I'm not well versed in how all this works. I'll look into whether we're pulling in signatures in the sql jars.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services