You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/02/05 20:10:03 UTC
[GitHub] [hbase] ndimiduk opened a new pull request #1127: HBASE-23802
Remove unnecessary Configuration instantiation in LossyAccounting
ndimiduk opened a new pull request #1127: HBASE-23802 Remove unnecessary Configuration instantiation in LossyAccounting
URL: https://github.com/apache/hbase/pull/1127
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk commented on issue #1127: HBASE-23802 Remove
unnecessary Configuration instantiation in LossyAccounting
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on issue #1127: HBASE-23802 Remove unnecessary Configuration instantiation in LossyAccounting
URL: https://github.com/apache/hbase/pull/1127#issuecomment-582590150
Unwind the `Configuration` creation, and cleanup a bunch of warnings along the way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1127: HBASE-23802 Remove
unnecessary Configuration instantiation in LossyAccounting
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1127: HBASE-23802 Remove unnecessary Configuration instantiation in LossyAccounting
URL: https://github.com/apache/hbase/pull/1127#issuecomment-582653086
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 27s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 57s | master passed |
| +1 :green_heart: | compile | 1m 0s | master passed |
| +1 :green_heart: | checkstyle | 1m 15s | master passed |
| +1 :green_heart: | shadedjars | 5m 4s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 38s | master passed |
| +0 :ok: | spotbugs | 4m 31s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 4m 29s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 26s | the patch passed |
| +1 :green_heart: | compile | 1m 0s | the patch passed |
| +1 :green_heart: | javac | 1m 0s | the patch passed |
| +1 :green_heart: | checkstyle | 1m 12s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 5m 4s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 17m 15s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| +1 :green_heart: | javadoc | 0m 35s | the patch passed |
| +1 :green_heart: | findbugs | 4m 45s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 95m 22s | hbase-server in the patch failed. |
| +1 :green_heart: | asflicense | 0m 28s | The patch does not generate ASF License warnings. |
| | | 156m 45s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.hbase.replication.TestReplicationSmallTests |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1127/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1127 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 1eb80b166c49 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1127/out/precommit/personality/provided.sh |
| git revision | master / b49ec58073 |
| Default Java | 1.8.0_181 |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1127/1/artifact/out/patch-unit-hbase-server.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1127/1/testReport/ |
| Max. process+thread count | 6598 (vs. ulimit of 10000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1127/1/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk commented on a change in pull request #1127:
HBASE-23802 Remove unnecessary Configuration instantiation in LossyAccounting
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on a change in pull request #1127: HBASE-23802 Remove unnecessary Configuration instantiation in LossyAccounting
URL: https://github.com/apache/hbase/pull/1127#discussion_r375548802
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/util/LossyCounting.java
##########
@@ -80,9 +79,12 @@ public LossyCounting(double errorRate, String name, LossyCountingListener listen
new ThreadFactoryBuilder().setDaemon(true).setNameFormat("lossy-count-%d").build());
}
- public LossyCounting(String name, LossyCountingListener listener) {
- this(HBaseConfiguration.create().getDouble(HConstants.DEFAULT_LOSSY_COUNTING_ERROR_RATE, 0.02),
Review comment:
Indeed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk merged pull request #1127: HBASE-23802 Remove
unnecessary Configuration instantiation in LossyAccounting
Posted by GitBox <gi...@apache.org>.
ndimiduk merged pull request #1127: HBASE-23802 Remove unnecessary Configuration instantiation in LossyAccounting
URL: https://github.com/apache/hbase/pull/1127
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1127:
HBASE-23802 Remove unnecessary Configuration instantiation in LossyAccounting
Posted by GitBox <gi...@apache.org>.
saintstack commented on a change in pull request #1127: HBASE-23802 Remove unnecessary Configuration instantiation in LossyAccounting
URL: https://github.com/apache/hbase/pull/1127#discussion_r375522343
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/util/LossyCounting.java
##########
@@ -80,9 +79,12 @@ public LossyCounting(double errorRate, String name, LossyCountingListener listen
new ThreadFactoryBuilder().setDaemon(true).setNameFormat("lossy-count-%d").build());
}
- public LossyCounting(String name, LossyCountingListener listener) {
- this(HBaseConfiguration.create().getDouble(HConstants.DEFAULT_LOSSY_COUNTING_ERROR_RATE, 0.02),
Review comment:
Ouch. To read a single config.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services