[jira] Commented: (DERBY-3921) Replication: Test replication of encrypted databases

["Rick Hillegas (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DERBY-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12680177#action_12680177 ] 

Rick Hillegas commented on DERBY-3921:
--------------------------------------

Thanks for the patch Ole. The replication suite ran cleanly for me after applying these changes. I have a couple small comments on the patch:

Style: In a number of these tests, the setUp() and tearDown() overrides don't seem to do anything. I'd be inclined to remove these methods.

Headers: I like the fact that some of the test cases have JIRA numbers embedded in their names. This helps connect the test cases with the issues. It would be even more helpful if the test cases had header comments which explained more about what was being tested.

Factoring: I see a lot of instances of code like this, which I'd recommend abstracting into a shared method:

+           URL = DB_PROTOCOL
+                +"://"+masterServerHost
+                +":"+masterServerPort+"/"
+                +masterDatabasePath+FS+masterDbSubPath+FS+replicatedDb
+                +useEncryption(false);

Thanks.



> Replication: Test replication of encrypted databases
> ----------------------------------------------------
>
>                 Key: DERBY-3921
>                 URL: https://issues.apache.org/jira/browse/DERBY-3921
>             Project: Derby
>          Issue Type: Test
>          Components: Replication, Test
>    Affects Versions: 10.5.0.0
>            Reporter: Jørgen Løland
>            Assignee: Ole Solberg
>         Attachments: DERBY-3921_diff.txt, DERBY-3921_stat.txt
>
>
> It should be possible to replicate encrypted databases. Tests are needed to ensure that this works.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.