You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/05/03 13:56:20 UTC
[GitHub] [incubator-nuttx] SimonFilgis opened a new pull request, #6202: MCAN_INT_ACKE must be on the list of MCAN_TXERR_INTS to be properly h…
SimonFilgis opened a new pull request, #6202:
URL: https://github.com/apache/incubator-nuttx/pull/6202
…andeled
## Summary
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6202: MCAN_INT_ACKE must be on the list of MCAN_TXERR_INTS to be properly h…
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #6202:
URL: https://github.com/apache/incubator-nuttx/pull/6202#discussion_r863808027
##########
arch/arm/src/samv7/sam_mcan.c:
##########
@@ -777,7 +777,7 @@
MCAN_INT_TEFL)
#define MCAN_TXDEDBUF_INTS MCAN_TXCOMMON_INTS
-#define MCAN_TXERR_INTS (MCAN_INT_TEFL | MCAN_INT_PEA | MCAN_INT_PED)
+#define MCAN_TXERR_INTS (MCAN_INT_TEFL | MCAN_INT_PEA | MCAN_INT_PED | MCAN_INT_ACKE)
Review Comment:
```suggestion
#define MCAN_TXERR_INTS (MCAN_INT_TEFL | MCAN_INT_PEA | MCAN_INT_PED | \
MCAN_INT_ACKE)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] SimonFilgis commented on pull request #6202: MCAN_INT_ACKE must be on the list of MCAN_TXERR_INTS to be properly h…
Posted by GitBox <gi...@apache.org>.
SimonFilgis commented on PR #6202:
URL: https://github.com/apache/incubator-nuttx/pull/6202#issuecomment-1116174373
rebased against correct branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #6202: MCAN_INT_ACKE must be on the list of MCAN_TXERR_INTS to be properly h…
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on PR #6202:
URL: https://github.com/apache/incubator-nuttx/pull/6202#issuecomment-1116152008
Please squash commits into one:
```
git checkout bugfix/can_add_acke_int2listOfTxErrors_cherry
git rebase -i master
-- mark first ans "pick" and other as "sqash"
git rebase --continue
git push -f origin bugfix/can_add_acke_int2listOfTxErrors_cherry
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] SimonFilgis closed pull request #6202: MCAN_INT_ACKE must be on the list of MCAN_TXERR_INTS to be properly h…
Posted by GitBox <gi...@apache.org>.
SimonFilgis closed pull request #6202: MCAN_INT_ACKE must be on the list of MCAN_TXERR_INTS to be properly h…
URL: https://github.com/apache/incubator-nuttx/pull/6202
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org