You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by cfmcgrady <gi...@git.apache.org> on 2015/04/22 09:01:18 UTC

[GitHub] incubator-zeppelin pull request: Zeppelin 26

GitHub user cfmcgrady opened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/47

    Zeppelin 26

    Base on this branch(https://github.com/Leemoonsoo/incubator-zeppelin/tree/ZEPPELIN-26). add HDFSNotebookRepo.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cfmcgrady/incubator-zeppelin ZEPPELIN-26

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/47.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #47
    
----
commit 1d63234a6b76c33a867ed41a800b50e7791fde8a
Author: Lee moon soo <mo...@apache.org>
Date:   2015-04-21T04:18:54Z

    Add notebook storage abstraction and implementation based on commons-vfs2

commit 44d6a6fb304d31cb44e06cf67bff9bf0fbc49f26
Author: Lee moon soo <mo...@apache.org>
Date:   2015-04-21T04:49:44Z

    ZEPPELIN-26 let implementation configurable

commit 47f280b9ef5bf53e3b56b2538f5ae4b891d83e54
Author: omega cloud account <cf...@gmail.com>
Date:   2015-04-22T04:51:25Z

    add HDFSNotebookRepo

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Zeppelin 26

Posted by jongyoul <gi...@git.apache.org>.

Github user jongyoul commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/47#issuecomment-188638762
  
    @cfmcgrady Do you have any update for this? Otherwise, Could you please close this PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Zeppelin 26

Posted by Leemoonsoo <gi...@git.apache.org>.

Github user Leemoonsoo commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/47#issuecomment-97614848
  
    @cfmcgrady I think using maven property is an option for making HDFS version configurable. For example spark interpreter is already doing it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Zeppelin 26

Posted by cfmcgrady <gi...@git.apache.org>.

Github user cfmcgrady commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/47#issuecomment-97351970
  
    @Leemoonsoo.
    so which is better way make version of HDFS configurable.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Zeppelin 26

Posted by Leemoonsoo <gi...@git.apache.org>.

Github user Leemoonsoo commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/47#issuecomment-97295608
  
    Hi, @cfmcgrady. Thanks for contribution.
    
    Constructor type for NotebookRepo is slightly changed.
    from NotebookRepo(ZeppelinConfiguration conf, URI uri) to NotebookRepo(ZeppelinConfiguration conf). Please rebase this branch with master branch.
    
    One concern is  
    Currently zeppelin-daemon process and interpreter process uses common.sh to construct it's classpath.
    Once zeppelin-daemon have HDFS dependencies, then by common.sh, it'll be also loaded into every interpreter process. Especially spark include HDFS related dependency, too, they'll conflict.
    
    And version of HDFS related dependency's is fixed. i think it'll be better if it is configurable.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---