You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by al...@apache.org on 2021/04/24 03:04:47 UTC
[kudu] 02/02: [client] fix typos on metacache lookup timing
This is an automated email from the ASF dual-hosted git repository.
alexey pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git
commit b9d144abd4b6becc7d2f0b64ea8b5f90871a54f0
Author: Alexey Serbin <al...@apache.org>
AuthorDate: Fri Apr 23 16:42:01 2021 -0700
[client] fix typos on metacache lookup timing
Before this patch, the logs on slow metacache lookup looked like
the following:
Time spent slow lookup of entry by key: ...
Now it's
Time spent looking up entry by key: ...
This patch doesn't contain any functional changes.
This is a follow-up to 44d687caf3633d75b0cc64f1a25f444484ce43ad.
Change-Id: I0699337b25a702c86a780e0b42ebd3ab0e15b1ef
Reviewed-on: http://gerrit.cloudera.org:8080/17336
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
src/kudu/client/meta_cache.cc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/kudu/client/meta_cache.cc b/src/kudu/client/meta_cache.cc
index 6f3d839..fdbfe08 100644
--- a/src/kudu/client/meta_cache.cc
+++ b/src/kudu/client/meta_cache.cc
@@ -1181,7 +1181,7 @@ Status MetaCache::ProcessGetTableLocationsResponse(const KuduTable* table,
bool MetaCache::LookupEntryByKeyFastPath(const KuduTable* table,
const string& partition_key,
MetaCacheEntry* entry) {
- SCOPED_LOG_SLOW_EXECUTION(WARNING, 50, "slow lookup of entry by key");
+ SCOPED_LOG_SLOW_EXECUTION(WARNING, 50, "looking up entry by key");
shared_lock<rw_spinlock> l(lock_.get_lock());
const TabletMap* tablets = FindOrNull(tablets_by_table_and_key_, table->id());
if (PREDICT_FALSE(!tablets)) {
@@ -1234,7 +1234,7 @@ Status MetaCache::DoFastPathLookup(const KuduTable* table,
bool MetaCache::LookupEntryByIdFastPath(const string& tablet_id,
MetaCacheEntry* entry) {
- SCOPED_LOG_SLOW_EXECUTION(WARNING, 50, "slow lookup of entry by ID");
+ SCOPED_LOG_SLOW_EXECUTION(WARNING, 50, "looking up entry by ID");
shared_lock<rw_spinlock> l(lock_.get_lock());
const auto* cache_entry = FindOrNull(entry_by_tablet_id_, tablet_id);
if (PREDICT_FALSE(!cache_entry)) {