You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by weifensh <gi...@git.apache.org> on 2017/07/26 12:36:05 UTC
[GitHub] incubator-trafficcontrol pull request #754: Configure session tracking on TO...
GitHub user weifensh opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/754
Configure session tracking on TO side
This PR work together with PR #643
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/weifensh/incubator-trafficcontrol master-session-tracking-ops-4
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafficcontrol/pull/754.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #754
----
commit 16baac241ed2f254bbd6b8cf816a85570aada538
Author: John Shen <we...@cisco.com>
Date: 2017-07-26T12:26:11Z
Config session tracking on TO side
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #754: Configure session tracking on TO side
Posted by weifensh <gi...@git.apache.org>.
Github user weifensh commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/754
@limited Thanks Eric. The white spaces and tabs are mostly introduced by perltidy. Some are caused by reformatting with the new code. And others are because it appears some original files are not following the formatting conventions at https://trafficcontrol.incubator.apache.org/docs/latest/development/traffic_ops.html and thus they are reformatted by perltidy in this PR. I might be asked to run perltidy if I reduce the diff;-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #754: Configure session tracking on TO side
Posted by limited <gi...@git.apache.org>.
Github user limited commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/754
There's 2 fields- a boolean and a list of the keys to use from the cookie. The list is expected to be short, just a few entries long. No session metadata is stored in the TO DB.
I agree we need better approach to DS options, but I don't think this is the PR to hinge things on.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #754: Configure session tracking on TO side
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/754
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #754: Configure session tracking on TO side
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/754
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/14/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #754: Configure session tracking on TO side
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/754
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #754: Configure session tracking on TO side
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/754
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #754: Configure session tracking on TO side
Posted by dewrich <gi...@git.apache.org>.
Github user dewrich commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/754
@limited @weifensh Is there a way we can prevent adding yet another field to the Delivery Service Table? If we are tracking sessions, maybe that should be a separate table (with the session metadata we care about) that points back to the Delivery Service table.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #754: Configure session tracking on TO side
Posted by limited <gi...@git.apache.org>.
Github user limited commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/754
Thanks John-
The diff is quite large, mostly because of whitespace and some formatting related changes.
Can you please try to minimize the size of the diff to just changes directly related to the Session Tracking code so that its easier to review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #754: Configure session tracking on TO side
Posted by mitchell852 <gi...@git.apache.org>.
Github user mitchell852 commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/754
and was this discussed on the ML because i'm a pretty hard -1 on more DS table columns (if possible). That table is way out of control imo (50+ columns already?). @knutsel did introduce ds profiles...maybe that could be leveraged instead? i don't know.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---